| Message ID | 20230507201225.89694-1-matti.lehtimaki@gmail.com |
|---|---|
| Headers | show |
| Series | Enable MSM8226 TSENS support | expand |
On Mon, 8 May 2023 at 00:11, Matti Lehtimäki <matti.lehtimaki@gmail.com> wrote: > > On 7.5.2023 23.40, Dmitry Baryshkov wrote: > > On 07/05/2023 23:12, Matti Lehtimäki wrote: > >> The MSM8226 TSENS IP has 6 thermal sensors in a TSENS v0.1 block. > >> The thermal sensors use non-standard slope values. > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > Note, the driver from 3.10 also provides custom data for non-calibrated mode. We can either ignore that (in the hope that all devices leaving the factory are calibrated), or fix it in the manner close to 8x74. > > That is true, 3.10 kernel does support non-calibrated mode. I can add support for that in a new version if that is wanted. If there are no other comments, I'd suggest sending that as a follow up (if sending it at all). The tsens driver provides some default values for non-calibrated mode, so it is a minor issue.
On 7.05.2023 23:25, Rob Herring wrote: > > On Sun, 07 May 2023 23:12:19 +0300, Matti Lehtimäki wrote: >> Document QFPROM compatible for MSM8226. >> >> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> >> --- >> Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 + >> 1 file changed, 1 insertion(+) >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.example.dtb: pcie-ep@33800000: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected) > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is too short > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml > > doc reference errors (make refcheckdocs): > Documentation/usb/gadget_uvc.rst: Documentation/userspace-api/media/v4l/pixfmt-packed.yuv.rst > MAINTAINERS: Documentation/devicetree/bindings/pwm/pwm-apple.yaml Rob, your bot seems to have picked up a false positive Konrad > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230507201225.89694-2-matti.lehtimaki@gmail.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
On 07/05/2023 22:12, Matti Lehtimäki wrote: > Document QFPROM compatible for MSM8226. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > --- > Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 + Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Bot's errors can be ignored. Best regards, Krzysztof
On 07/05/2023 22:12, Matti Lehtimäki wrote: > The MSM8226 TSENS IP has 6 thermal sensors in a TSENS v0.1 block. > The thermal sensors use non-standard slope values. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > --- Applied, thanks
On Sun, 7 May 2023 23:12:18 +0300, Matti Lehtimäki wrote: > Add support for tsens in MSM8226. Add qfprom compatible for MSM8226. > Add device tree nodes for qfprom, tsens and thermal zones for MSM8226. > > Matti Lehtimäki (6): > dt-bindings: nvmem: qfprom: Add compatible for MSM8226 > dt-bindings: thermal: tsens: Add compatible for MSM8226 > thermal/drivers/qcom/tsens-v0_1: Add support for MSM8226 > ARM: dts: msm8226: Add qfprom node > ARM: dts: msm8226: Add tsens node and related nvmem cells > ARM: dts: msm8226: Add thermal zones node > > [...] Applied, thanks! [4/6] ARM: dts: msm8226: Add qfprom node commit: 16a9fa7ab27b69be3a34b97ff8c7b034fcc73b88 [5/6] ARM: dts: msm8226: Add tsens node and related nvmem cells commit: 0f8861c9fc7cc9af6d6f65d6657aa9cf2531b29c [6/6] ARM: dts: msm8226: Add thermal zones node commit: 8d4236f62f3acbc6a0def79106c13fe7344d8238 Best regards,
On 07/05/2023 21:12, Matti Lehtimäki wrote: > Document QFPROM compatible for MSM8226. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > --- Applied thanks, --srini > Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > index 2173fe82317d..0baf7819ab46 100644 > --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > @@ -20,6 +20,7 @@ properties: > - qcom,apq8084-qfprom > - qcom,ipq8064-qfprom > - qcom,ipq8074-qfprom > + - qcom,msm8226-qfprom > - qcom,msm8916-qfprom > - qcom,msm8974-qfprom > - qcom,msm8976-qfprom