| Message ID | 20230406194703.495836-1-brgl@bgdev.pl |
|---|---|
| Headers | show |
| Series | arm64: qcom: sa8775p: add support for UFS | expand |
On 06/04/2023 21:46, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add the compatible string for the UFS on sa8775p platforms. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 06/04/2023 21:47, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add a new compatible for the QMP UFS PHY found on sa8775p platforms and > update the clocks property to accommodate three clocks. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > .../phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 26 ++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml > index cd0fbbd3593d..5bc93acccbad 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml > @@ -16,6 +16,7 @@ description: > properties: > compatible: > enum: > + - qcom,sa8775p-qmp-ufs-phy > - qcom,sc8280xp-qmp-ufs-phy > - qcom,sm6125-qmp-ufs-phy > - qcom,sm7150-qmp-ufs-phy > @@ -25,12 +26,15 @@ properties: > maxItems: 1 > > clocks: > - maxItems: 2 > + minItems: 2 > + maxItems: 3 > > clock-names: > + minItems: 2 > items: > - const: ref > - const: ref_aux > + - const: qref > > power-domains: > maxItems: 1 > @@ -52,6 +56,26 @@ properties: > "#phy-cells": > const: 0 > > +allOf: I should notice wrong different placement before. allOf: blocks goes just like in example-schema, so after required:. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sa8775p-qmp-ufs-phy > + then: > + properties: > + clocks: > + maxItems: 3 > + clock-names: > + maxItems: 3 > + else: > + properties: > + clocks: > + maxItems: 2 > + clock-names: > + maxItems: 2 > + > required: > - compatible > - reg Best regards, Krzysztof
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Update relevant DT bindings, add new config to the driver and add UFS and PHY nodes to the .dtsi and enable them in the board .dts for sa8775p-ride. v1 -> v2: - order new compatibles alphabetically - rework the UFS PHY bindings to accomodate more clocks - add a comment in the .dts regarding a non-standard clock used by the UFS PHY Bartosz Golaszewski (5): dt-bindings: ufs: qcom: add compatible for sa8775p dt-bindings: phy: qmp-ufs: describe the UFS PHY for sa8775p phy: qualcomm: phy-qcom-qmp-ufs: add definitions for sa8775p arm64: dts: qcom: sa8775p: add UFS nodes arm64: dts: qcom: sa8775p-ride: enable UFS .../phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 26 ++++++++- .../devicetree/bindings/ufs/qcom,ufs.yaml | 2 + arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 19 ++++++ arch/arm64/boot/dts/qcom/sa8775p.dtsi | 58 +++++++++++++++++++ drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 38 ++++++++++++ 5 files changed, 142 insertions(+), 1 deletion(-)