| Message ID | 20230406145850.357296-1-bryan.odonoghue@linaro.org |
|---|---|
| Headers | show |
| Series | drivers/thermal/qcom/tsens: Add ability to read and shift-in non-contiguous calibration data | expand |
On 06/04/2023 17:58, Bryan O'Donoghue wrote: > Add in some dev_dbg() to aid in viewing of raw calibration data extracted. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > drivers/thermal/qcom/tsens.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On 06/04/2023 17:20, Stephan Gerhold wrote: >> Reviewed-by: Bryan O'Donoghue<bryan.odonoghue@linaro.org> > So with sensor hwid=10 disabled, I think this patch series is actually > not needed? 😄 I can hardly be expected to remember back to January .. dropping
On MSM8939 the last sensor has calibration data that cannot be extracted in one big read. Rather than have a lot of MSM8939 specific code this series makes a generic modification to allow any other calibration data that is non-contiguous to be extracted and recovered. For example s9-p2 takes bits 1-5 from @4b and bit 13 from @4d. The bit from bit13 then becomes the sixth bit in the calibration data. tsens_s9_p2: s9-p2@4b { reg = <0x4b 0x1>; bits = <1 5>; }; tsens_s9_p2_msb: s9-p2-msb@4d { reg = <0x4d 0x1>; bits = <13 1>; }; A register desciptor is introduced in the driver which takes the place of the previous unsigned int hw_ids array in struct tsens_plat_data. This new structure contains the previous hardware id and two variables p1_shift and p2_shift. If p1_shift or p2_shift is non-zero then this tells tsens_read_calibration() to search for sX-pY-msb where msb means "most significant bits". The value at p1_shift/p2_shift is then used to right shift the value read from sX-pY-msb and or that value into the base value from sX-pY. The nvmem 'bits' field provides the mask. Bryan O'Donoghue (3): thermal/drivers/tsens: Add error/debug prints to calibration read thermal/drivers/tsens: Describe sensor registers via a structure thermal/drivers/tsens: Extract and shift-in optional MSB drivers/thermal/qcom/tsens-v0_1.c | 56 +++++++++++++++++++++++++++++-- drivers/thermal/qcom/tsens.c | 50 ++++++++++++++++++++++++--- drivers/thermal/qcom/tsens.h | 16 ++++++++- 3 files changed, 115 insertions(+), 7 deletions(-)