| Message ID | 20230405072836.1690248-1-bhupesh.sharma@linaro.org |
|---|---|
| Headers | show |
| Series | arm64: qcom: Enable Crypto Engine for a few Qualcomm SoCs | expand |
On 5.04.2023 09:28, Bhupesh Sharma wrote: > Add crypto engine (CE) and CE BAM related nodes and definitions to > 'sm6115.dtsi'. > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Tested-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sm6115.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi > index 2a51c938bbcb..ebac026b4cc7 100644 > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi > @@ -650,6 +650,28 @@ usb_hsphy: phy@1613000 { > status = "disabled"; > }; > > + cryptobam: dma-controller@1b04000 { > + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > + reg = <0x0 0x01b04000 0x0 0x24000>; > + interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>; > + #dma-cells = <1>; > + qcom,ee = <0>; > + qcom,controlled-remotely; > + num-channels = <8>; > + qcom,num-ees = <2>; > + iommus = <&apps_smmu 0x94 0x11>, > + <&apps_smmu 0x96 0x11>; > + }; > + > + crypto: crypto@1b3a000 { > + compatible = "qcom,sm6115-qce", "qcom,sm8150-qce", "qcom,qce"; > + reg = <0x0 0x01b3a000 0x0 0x6000>; > + dmas = <&cryptobam 6>, <&cryptobam 7>; > + dma-names = "rx", "tx"; > + iommus = <&apps_smmu 0x94 0x11>, > + <&apps_smmu 0x96 0x11>; > + }; > + > qfprom@1b40000 { > compatible = "qcom,sm6115-qfprom", "qcom,qfprom"; > reg = <0x0 0x01b40000 0x0 0x7000>;
On 5.04.2023 09:28, Bhupesh Sharma wrote: > Add crypto engine (CE) and CE BAM related nodes and definitions to > 'sm8250.dtsi'. > > Co-developed-by and Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index 7b78761f2041..2f6b8d4a2d41 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -2222,6 +2222,28 @@ ufs_mem_phy_lanes: phy@1d87400 { > }; > }; > > + cryptobam: dma-controller@1dc4000 { > + compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0"; > + reg = <0 0x01dc4000 0 0x24000>; > + interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>; > + #dma-cells = <1>; > + qcom,ee = <0>; > + qcom,controlled-remotely; > + iommus = <&apps_smmu 0x594 0x0011>, > + <&apps_smmu 0x596 0x0011>; > + }; > + > + crypto: crypto@1dfa000 { > + compatible = "qcom,sm8250-qce", "qcom,sm8150-qce", "qcom,qce"; > + reg = <0 0x01dfa000 0 0x6000>; > + dmas = <&cryptobam 4>, <&cryptobam 5>; > + dma-names = "rx", "tx"; > + iommus = <&apps_smmu 0x594 0x0011>, > + <&apps_smmu 0x596 0x0011>; > + interconnects = <&aggre2_noc MASTER_CRYPTO_CORE_0 &mc_virt SLAVE_EBI_CH0>; > + interconnect-names = "memory"; Shouldn't we also attach the contexts from qcom_cedev_ns_cb{}? Konrad > + }; > + > tcsr_mutex: hwlock@1f40000 { > compatible = "qcom,tcsr-mutex"; > reg = <0x0 0x01f40000 0x0 0x40000>;
> This patchset enables Crypto Engine support for Qualcomm SoCs like > SM6115, SM8150, SM8250, SM8350 and SM8450. > > Note that: > - SM8250 crypto engine patch utilizes the work already done by myself and > Vladimir. > - SM8350 crypto engine patch utilizes the work already done by Robert. > - SM8450 crypto engine patch utilizes the work already done by Neil. > > Also this patchset is rebased on linux-next/master. These patches tested on top of Linux next-20230406. Tested-by: Anders Roxell <anders.roxell@linaro.org> Tested-by: Linux Kernel Functional Testing <lkft@linaro.org> -- Linaro LKFT https://lkft.linaro.org
Changes since v5: ----------------- - v5 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230402100509.1154220-1-bhupesh.sharma@linaro.org/ - Collected Ack from Rob for [PATCH 01/11]. - Addressed Georgi's comment about interconnect cells in [PATCH 10/11]. Changes since v4: ----------------- - v4 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230331164323.729093-1-bhupesh.sharma@linaro.org/ - Collected R-Bs from Konrad for a couple of patches sent in v4. - Fixed incorrect email IDs for a couple of patches sent in v3, which I used for some patches created on a different work machine. - No functional changes since v3. Changes since v3: ----------------- - v3 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230328092815.292665-1-bhupesh.sharma@linaro.org/ - Collected Acks from Krzysztof for a couple of patches sent in v3. - Fixed review comments from Krzysztof regarding DMA binding document and also added a couple of new patches which are required to fix the 'dtbs_check' errors highlighted after this fix. Changes since v2: ----------------- - v2 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230322114519.3412469-1-bhupesh.sharma@linaro.org/ - No functional change since v2. As the sdm845 patch from v1 was accepted in linux-next, dropped it from this version. Changes since v1: ----------------- - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20230321190118.3327360-1-bhupesh.sharma@linaro.org/ - Folded the BAM DMA dt-binding change. (sent earlier as: https://lore.kernel.org/linux-arm-msm/20230321184811.3325725-1-bhupesh.sharma@linaro.org/) - Folded the QCE dt-binding change. (sent earlier as: https://lore.kernel.org/linux-arm-msm/20230320073816.3012198-1-bhupesh.sharma@linaro.org/) - Folded Neil's SM8450 dts patch in this series. - Addressed review comments from Rob, Stephan and Konrad. - Collected Konrad's R-B for [PATCH 5/9]. This patchset enables Crypto Engine support for Qualcomm SoCs like SM6115, SM8150, SM8250, SM8350 and SM8450. Note that: - SM8250 crypto engine patch utilizes the work already done by myself and Vladimir. - SM8350 crypto engine patch utilizes the work already done by Robert. - SM8450 crypto engine patch utilizes the work already done by Neil. Also this patchset is rebased on linux-next/master. Bhupesh Sharma (10): dt-bindings: dma: Add support for SM6115 and QCM2290 SoCs dt-bindings: dma: Increase iommu maxItems for BAM DMA arm64: dts: qcom: sdm8550: Fix the BAM DMA engine compatible string arm64: dts: qcom: sdm845: Fix the slimbam DMA engine compatible string dt-bindings: qcom-qce: Fix compatible combinations for SM8150 and IPQ4019 SoCs dt-bindings: qcom-qce: Add compatibles for SM6115 and QCM2290 arm64: dts: qcom: sm6115: Add Crypto Engine support arm64: dts: qcom: sm8150: Add Crypto Engine support arm64: dts: qcom: sm8250: Add Crypto Engine support arm64: dts: qcom: sm8350: Add Crypto Engine support Neil Armstrong (1): arm64: dts: qcom: sm8450: add crypto nodes .../devicetree/bindings/crypto/qcom-qce.yaml | 8 ++++++ .../devicetree/bindings/dma/qcom,bam-dma.yaml | 22 +++++++++------ arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm6115.dtsi | 22 +++++++++++++++ arch/arm64/boot/dts/qcom/sm8150.dtsi | 22 +++++++++++++++ arch/arm64/boot/dts/qcom/sm8250.dtsi | 22 +++++++++++++++ arch/arm64/boot/dts/qcom/sm8350.dtsi | 22 +++++++++++++++ arch/arm64/boot/dts/qcom/sm8450.dtsi | 28 +++++++++++++++++++ arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +- 9 files changed, 140 insertions(+), 10 deletions(-)