[v4,00/12] drm/i915: move DSC RC tables to drm_dsc_helper.c

Message ID	20230403092313.235320-1-dmitry.baryshkov@linaro.org
Headers	show Return-Path: <linux-arm-msm-owner@vger.kernel.org> From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Jani Nikula <jani.nikula@linux.intel.com>, Suraj Kandpal <suraj.kandpal@intel.com>, Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Sean Paul <sean@poorly.run>, Marijn Suijten <marijn.suijten@somainline.org> Cc: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: [PATCH v4 00/12] drm/i915: move DSC RC tables to drm_dsc_helper.c Date: Mon, 3 Apr 2023 12:23:01 +0300 Message-Id: <20230403092313.235320-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	drm/i915: move DSC RC tables to drm_dsc_helper.c \| expand [v4,00/12] drm/i915: move DSC RC tables to drm_dsc_helper.c [v4,01/12] drm/i915/dsc: change DSC param tables to follow the DSC model [v4,02/12] drm/i915/dsc: move rc_buf_thresh values to common helper [v4,03/12] drm/i915/dsc: move DSC tables to DRM DSC helper [v4,04/12] drm/i915/dsc: stop using interim structure for calculated params [v4,05/12] drm/display/dsc: use flat array for rc_parameters lookup [v4,06/12] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters [v4,07/12] drm/display/dsc: include the rest of pre-SCR parameters [v4,08/12] drm/display/dsc: add YCbCr 4:2:2 and 4:2:0 RC parameters [v4,09/12] drm/display/dsc: add helper to set semi-const parameters [v4,10/12] drm/display/dsc: Add flatness and initial scale value calculations [v4,11/12] drm/i915/dsc: use additional DSC helpers [v4,12/12] drm/i915/dsc: make use of several params from drm_dsc_config

Message ID

20230403092313.235320-1-dmitry.baryshkov@linaro.org

Headers

From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Suraj Kandpal <suraj.kandpal@intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Rob Clark <robdclark@gmail.com>,
        Abhinav Kumar <quic_abhinavk@quicinc.com>,
        Sean Paul <sean@poorly.run>,
        Marijn Suijten <marijn.suijten@somainline.org>
Cc: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?=  <ville.syrjala@linux.intel.com>,
 dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
 linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org
Subject: [PATCH v4 00/12] drm/i915: move DSC RC tables to drm_dsc_helper.c
Date: Mon,  3 Apr 2023 12:23:01 +0300
Message-Id: <20230403092313.235320-1-dmitry.baryshkov@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

drm/i915: move DSC RC tables to drm_dsc_helper.c | expand

Message

Dmitry Baryshkov April 3, 2023, 9:23 a.m. UTC

Other platforms (msm) will benefit from sharing the DSC config setup
functions. This series moves parts of static DSC config data from the
i915 driver to the common helpers to be used by other drivers.

Note: the RC parameters were cross-checked against config files found in
DSC model 2021062, 20161212 (and 20150914). The first patch modifies
tables according to those config files, while preserving parameter
values using the code. I have not changed one of the values in the
pre-SCR config file as it clearly looks like a typo in the config file,
considering the table E in DSC 1.1 and in the DSC 1.1 SCR.

Chances since v3:
- Rebased on top of drm-intel-next
- Dropped the msm patch to make patchset fully mergeable through
  drm-intel
- Made drm_dsc_set_const_params() ignore rc_model_size, picked up
  drm_dsc_set_initial_scale_value() patch by Jessica and switched
  intel_vdsc.c to use those two helpers.
- Added a patch to make i915 actually use rc_tgt_offset_high,
  rc_tgt_offset_low and rc_edge_factor from struct drm_dsc_config.

Chances since v2:
- Rebased on top of drm-intel-next

Chances since v1:
- Made drm_dsc_rc_buf_thresh static rather than exporting it
- Switched drm_dsc_rc_buf_thresh loop to use ARRAY_SIZE. Added
  BUILD_BUG_ON's to be sure that array sizes are correct
- Fixed rc_parameters_data indentation to be logical and tidy
- Fixed drm_dsc_setup_rc_params() kerneldoc
- Added a clause to drm_dsc_setup_rc_params() to verify bpp and bpc
  being set.
- Fixed range_bpg_offset programming in calculate_rc_params()
- Fixed bpp vs bpc bug in intel_dsc_compute_params()
- Added FIXME comment next to the customizations in
  intel_dsc_compute_params().

Dmitry Baryshkov (11):
  drm/i915/dsc: change DSC param tables to follow the DSC model
  drm/i915/dsc: move rc_buf_thresh values to common helper
  drm/i915/dsc: move DSC tables to DRM DSC helper
  drm/i915/dsc: stop using interim structure for calculated params
  drm/display/dsc: use flat array for rc_parameters lookup
  drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters
  drm/display/dsc: include the rest of pre-SCR parameters
  drm/display/dsc: add YCbCr 4:2:2 and 4:2:0 RC parameters
  drm/display/dsc: add helper to set semi-const parameters
  drm/i915/dsc: use additional DSC helpers
  drm/i915/dsc: make use of several params from drm_dsc_config

Jessica Zhang (1):
  drm/display/dsc: Add flatness and initial scale value calculations

 drivers/gpu/drm/display/drm_dsc_helper.c  | 1008 +++++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_vdsc.c |  464 ++--------
 include/drm/display/drm_dsc_helper.h      |   21 +
 3 files changed, 1081 insertions(+), 412 deletions(-)