From patchwork Wed Apr 12 19:09:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jessica Zhang X-Patchwork-Id: 672693 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36FA6C77B7C for ; Wed, 12 Apr 2023 19:10:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229661AbjDLTKL (ORCPT ); Wed, 12 Apr 2023 15:10:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229839AbjDLTKH (ORCPT ); Wed, 12 Apr 2023 15:10:07 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43C915B81 for ; Wed, 12 Apr 2023 12:10:05 -0700 (PDT) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33CBj4Yh029675; Wed, 12 Apr 2023 19:09:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : subject : date : message-id : mime-version : content-type : content-transfer-encoding : to : cc; s=qcppdkim1; bh=bYVxh75G+VGIFencWNiFy+0OmeGHASli2HrEGxt6LXA=; b=OdoUiRLHcAEqUh1xWYCHmnhs/l/ilSpcYjyjCZbKuwG/s5/pMSFbkl/ofudSIGjzXv7m xr7hBUS+GwKFPpwxoTt65RQ/UA3pb3kp72LvFUR2ov69B/fdfNSy7v55qQDLxlk/hncA i3UMedkkUyZ7M9cnB0L2YFWGUREPS+yk/GOEn8n3sHoQ1xdyVKE5+bJJx7DMdrAuo7V8 WBx5IWepaX86Sx7Vn+VPxgxTQeI80SLb1UJlRurVlQR5m4AkYrn8X5lpZ0khiFWQnhIy Dhls9i+sK/AmrDx6+DvJEb/5Dwso4GhccMoGdjeaVoURUe1Trljbt0jeAEAD3Eukr0N5 xg== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pwqn1hjxm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Apr 2023 19:09:58 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 33CJ9vbH019211 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Apr 2023 19:09:57 GMT Received: from jesszhan-linux.qualcomm.com (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Wed, 12 Apr 2023 12:09:56 -0700 From: Jessica Zhang Subject: [PATCH v5 0/8] Introduce MSM-specific DSC helpers Date: Wed, 12 Apr 2023 12:09:40 -0700 Message-ID: <20230329-rfc-msm-dsc-helper-v5-0-0108401d7886@quicinc.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAPUBN2QC/4XOsU7EMAwG4Fc5ZcYoidumYUJCYmBkBDEkjkMj0 fZIoAKd+u6kt8FJdPwt/599EoVz4iJuDieReUklzVMN7dVB0OCmV4YUahZaapSoLeRIMJYRQiE Y+O3IGWyvnG05RB+kqEXvCoPPbqJhqz48/S083t9te8fMMX2djz+/1Dyk8jHn7/Mvi9qm/55dF EiIyI2xsbW+C7fvn4nSRNc0j2IDF72P6IogKSQOLXZeXyK4j2BFOs8kgzbG9XiJNPtIUxHljSX Te5TB/EbWdf0BpZV3Yq0BAAA= To: CC: Marijn Suijten , Konrad Dybcio , Daniel Vetter , Rob Clark , Abhinav Kumar , "Dmitry Baryshkov" , Sean Paul , , , "Jessica Zhang" X-Mailer: b4 0.13-dev-00303 X-Developer-Signature: v=1; a=ed25519-sha256; t=1681326596; l=3783; i=quic_jesszhan@quicinc.com; s=20230329; h=from:subject:message-id; bh=M73gdAeWXun20r8FqP5kE+eKKXnJOhjIzAQsmY2Dfsk=; b=a31YpSrXEJ1VzYD6dpkLybStZEOY6RRhvG6yeANth0mSo1O2dfdegCNjK8c/tMTqW/tp6iCG/ laxvocla2hnBaw/6VBxZyvQDmkWzUzdFubPqreV4oC3xvII+t4qWqDP X-Developer-Key: i=quic_jesszhan@quicinc.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: f2x8NRSac5nCtyY_7MGNApJSTJfIVj3A X-Proofpoint-ORIG-GUID: f2x8NRSac5nCtyY_7MGNApJSTJfIVj3A X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-12_10,2023-04-12_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0 suspectscore=0 impostorscore=0 clxscore=1015 mlxlogscore=999 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304120164 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org There are some overlap in calculations for MSM-specific DSC variables between DP and DSI. In addition, the calculations for initial_scale_value and det_thresh_flatness that are defined within the DSC 1.2 specifications, but aren't yet included in drm_dsc_helper.c. This series moves these calculations to a shared msm_dsc_helper.c file and defines drm_dsc_helper methods for initial_scale_value and det_thresh_flatness. Note: For now, the MSM specific helper methods are only called for the DSI path, but will called for DP once DSC 1.2 support for DP has been added. Depends on: "drm/i915: move DSC RC tables to drm_dsc_helper.c" [1] [1] https://patchwork.freedesktop.org/series/114472/ --- Changes in v5: - Picked up Reviewed-by tags - "Fix calculations pkt_per_line" --> "... Fix calculation for pkt_per_line" - Split dsc->slice_width check into a separate patch - Picked up Dmitry's msm/dsi patch ("drm/msm/dsi: use new helpers for DSC setup") - Simplified MSM DSC helper math - Removed unused headers in MSM DSC helper files - Link to v4: https://lore.kernel.org/r/20230329-rfc-msm-dsc-helper-v4-0-1b79c78b30d7@quicinc.com Changes in v4: - Changed msm_dsc_get_uncompressed_pclk_per_intf to msm_dsc_get_pclk_per_intf - Moved pclk_per_intf calculation for dsi_timing_setup to `if (msm_host->dsc)` block - Link to v3: https://lore.kernel.org/r/20230329-rfc-msm-dsc-helper-v3-0-6bec0d277a83@quicinc.com Changes in v3: - Cleaned up unused parameters - Reworded some calculations for clarity - Changed get_bytes_per_soft_slice() to a public method - Added comment documentation to MSM DSC helpers - Changed msm_dsc_get_eol_byte_num() to *_get_bytes_per_intf() - Split dsi_timing_setup() hdisplay calculation to a separate patch - Dropped 78c8b81d57d8 ("drm/display/dsc: Add flatness and initial scale value calculations") patch as it was absorbed in Dmitry's DSC series [1] - Link to v2: https://lore.kernel.org/r/20230329-rfc-msm-dsc-helper-v2-0-3c13ced536b2@quicinc.com Changes in v2: - Changed det_thresh_flatness to flatness_det_thresh - Moved msm_dsc_helper files to msm/ directory - Fixed type mismatch issues in MSM DSC helpers - Dropped MSM_DSC_SLICE_PER_PKT macro - Removed get_comp_ratio() helper - Style changes to improve readability - Use drm_dsc_get_bpp_int() instead of DSC_BPP macro - Picked up Fixes tags for patches 3/5 and 4/5 - Picked up Reviewed-by for patch 4/5 - Split eol_byte_num and pkt_per_line calculation into a separate patch - Moved pclk_per_line calculation into `if (dsc)` block in dsi_timing_setup() - Link to v1: https://lore.kernel.org/r/20230329-rfc-msm-dsc-helper-v1-0-f3e479f59b6d@quicinc.com --- Dmitry Baryshkov (1): drm/msm/dsi: use new helpers for DSC setup Jessica Zhang (7): drm/msm: Add MSM-specific DSC helper methods drm/msm/dpu: Use DRM DSC helper for det_thresh_flatness drm/msm/dpu: Fix slice_last_group_size calculation drm/msm/dsi: Use MSM and DRM DSC helper methods drm/msm/dsi: Add check for slice_width in dsi_timing_setup drm/msm/dsi: update hdisplay calculation for dsi_timing_setup drm/msm/dsi: Fix calculation for pkt_per_line drivers/gpu/drm/msm/Makefile | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 9 ++-- drivers/gpu/drm/msm/dsi/dsi_host.c | 82 +++++++++--------------------- drivers/gpu/drm/msm/msm_dsc_helper.c | 25 +++++++++ drivers/gpu/drm/msm/msm_dsc_helper.h | 75 +++++++++++++++++++++++++++ 5 files changed, 131 insertions(+), 61 deletions(-) --- base-commit: 7417f9c699613f284bd4edc93adccac3ea3ced0f change-id: 20230329-rfc-msm-dsc-helper-981a95edfbd0 Best regards,