| Message ID | 20230327140752.163009-1-krzysztof.kozlowski@linaro.org |
|---|---|
| Headers | show |
| Series | mailbox/arm64: qcom: rework compatibles for fallback | expand |
On Mon, 27 Mar 2023 at 17:17, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > IPQ8074 mailbox is compatible with IPQ6018. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/ipq8074.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Mon, 27 Mar 2023 at 17:17, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Re-organize the compatible devices and add a comment to avoid unneeded > of_device_id growth with every new SoC. These devices have quite a lot > of similarities and they can use only one compatible fallback for driver > binding. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/mailbox/qcom-apcs-ipc-mailbox.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Mon, 27 Mar 2023 at 17:17, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > Rework the compatibles of IPQ8074, SC7180, SC8180X and SM8150 as > compatible devices (same from Linux driver point of view). This allows > smaller of_device_id table in the Linux driver and smaller > allOf:if:then: constraints. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Acked-by: Rob Herring <robh@kernel.org> > > --- > > Changes since v3: > 1. Narrow the scope of the patch after feedback from Dmitry. > > Depends on (merged to Qualcomm SoC tree): > https://lore.kernel.org/linux-arm-msm/20230322173559.809805-1-krzysztof.kozlowski@linaro.org/T/#t > --- > .../mailbox/qcom,apcs-kpss-global.yaml | 31 ++++++++++--------- > 1 file changed, 16 insertions(+), 15 deletions(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Thank you!
Hi, Changes since v3 ================ 1. Narrow the scope of the patches after feedback from Dmitry - only few variants are made compatible. Changes since v2 ================ 1. Split fixes to separate patchset which is now dependency: https://lore.kernel.org/linux-arm-msm/20230322173559.809805-1-krzysztof.kozlowski@linaro.org/T/#t 2. Add Ack 3. No other changes, as discussion with Dmitry did not reach conclusion on incompatibility. Changes since v1 ================ 1. Rebase 2. Make msm8994 fallback for several variants, not msm8953, because the latter actually might take some clocks. 3. Two new patches for SDX55. 4. Minor corrections in bindings style. v1: https://lore.kernel.org/all/20230202161856.385825-1-krzysztof.kozlowski@linaro.org/ Description =========== If entire approach is accepted (and correct), there are no dependencies and patches can be picked independently. Although the best in the same cycle, so there will be no new `dtbs_check` warnings. Best regards, Krzysztof Krzysztof Kozlowski (5): dt-bindings: mailbox: qcom,apcs-kpss-global: use fallbacks for few variants mailbox: qcom-apcs-ipc: do not grow the of_device_id arm64: dts: qcom: ipq8074: add compatible fallback to mailbox arm64: dts: qcom: sc7180: add compatible fallback to mailbox arm64: dts: qcom: sm8150: add compatible fallback to mailbox .../mailbox/qcom,apcs-kpss-global.yaml | 31 ++++++++++--------- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 3 +- arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +- arch/arm64/boot/dts/qcom/sm8150.dtsi | 3 +- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 11 ++++--- 5 files changed, 28 insertions(+), 23 deletions(-)