| Message ID | 20230315-topic-kamorta_adrsmmu-v1-0-d1c0dea90bd9@linaro.org |
|---|---|
| Headers | show |
| Series | SM6115 GPU SMMU | expand |
On 16/03/2023 22:59, Konrad Dybcio wrote: > > > On 16.03.2023 20:29, Krzysztof Kozlowski wrote: >> On 15/03/2023 11:52, Konrad Dybcio wrote: >>> Both of these SoCs have a Qualcomm MMU500 implementation of SMMU >>> in front of their GPUs that expect 3 clocks. Both of them also have >>> an APPS SMMU that expects no clocks. Remove qcom,sm61[12]5-smmu-500 >>> from the "no clocks" list (intentionally 'breaking' the schema checks >>> of APPS SMMU, as now it *can* accept clocks - with the current >>> structure of this file it would have taken a wastefully-long time to >>> sort this out properly..) and add necessary yaml to describe the >>> clocks required by the GPU SMMUs. >> >> >>> + properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - qcom,sm6115-smmu-500 >>> + - qcom,sm6125-smmu-500 >>> + - const: qcom,adreno-smmu >>> + - const: qcom,smmu-500 >>> + - const: arm,mmu-500 >> >> If you drop the hunk later (from allOf:if), then what clocks do you >> expect for non-GPU SMMU? > Both 6115 and 6125 require no clocks under the APPS (non-GPU) SMMU. > However, the list below uses a `contains:` which means I'd have > to add a whole another hunk like > > - items: > - enum: > - qcom,sm6115-smmu-500 > - qcom,sm6125-smmu-500 > - const: qcom,smmu-500 > - const: arm,mmu-500 > > and add another level of indentation to the previous one > > I figured skipping that was less messy (I think we discussed this > once as well), but if you prefer to keep it strict, I can. Nah, ok, it's fine. Best regards, Krzysztof
On Wed, 15 Mar 2023 11:52:07 +0100, Konrad Dybcio wrote: > Bring in bindings and the dt part for SM6115 GPU SMMU > > Depends on: > https://lore.kernel.org/linux-arm-msm/20230313-topic-gpu_smmu_bindings-v3-0-66ab655fbfd5@linaro.org/ > > [2/2] only addresses 6115, 6125 will be sent separately after some dt cleanups there > > [...] Applied bindings change to will (for-joerg/arm-smmu/bindings), thanks! [1/2] dt-bindings: arm-smmu: Document SM61[12]5 GPU SMMU https://git.kernel.org/will/c/3ad6585509dc Cheers,
On Wed, 15 Mar 2023 11:52:07 +0100, Konrad Dybcio wrote: > Bring in bindings and the dt part for SM6115 GPU SMMU > > Depends on: > https://lore.kernel.org/linux-arm-msm/20230313-topic-gpu_smmu_bindings-v3-0-66ab655fbfd5@linaro.org/ > > [2/2] only addresses 6115, 6125 will be sent separately after some dt cleanups there > > [...] Applied, thanks! [2/2] arm64: dts: qcom: sm6115: Add GPUCC and Adreno SMMU commit: fc7c39d61cf8cd03e197ac492241fa5a007dd2c0 Best regards,
Bring in bindings and the dt part for SM6115 GPU SMMU Depends on: https://lore.kernel.org/linux-arm-msm/20230313-topic-gpu_smmu_bindings-v3-0-66ab655fbfd5@linaro.org/ [2/2] only addresses 6115, 6125 will be sent separately after some dt cleanups there WARNING: [1/2] WILL apply without the dependency, HOWEVER it will not make much sense Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Konrad Dybcio (2): dt-bindings: arm-smmu: Document SM61[12]5 GPU SMMU arm64: dts: qcom: sm6115: Add GPUCC and Adreno SMMU .../devicetree/bindings/iommu/arm,smmu.yaml | 28 ++++++++++++++-- arch/arm64/boot/dts/qcom/sm6115.dtsi | 38 ++++++++++++++++++++++ 2 files changed, 64 insertions(+), 2 deletions(-) --- base-commit: 062337f0f153c686835cefdb4f937b63fa03edb6 change-id: 20230315-topic-kamorta_adrsmmu-e4e09e01e0da Best regards,