From patchwork Tue Mar 7 11:58:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 659989 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1872EC6FA99 for ; Tue, 7 Mar 2023 12:00:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230467AbjCGMAK (ORCPT ); Tue, 7 Mar 2023 07:00:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229682AbjCGMAJ (ORCPT ); Tue, 7 Mar 2023 07:00:09 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50DAA233DC for ; Tue, 7 Mar 2023 04:00:08 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyN-0006T7-KM; Tue, 07 Mar 2023 12:59:15 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyF-002TEW-9a; Tue, 07 Mar 2023 12:59:07 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyE-002yig-5U; Tue, 07 Mar 2023 12:59:06 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara , Wolfram Sang , Icenowy Zheng , Justin Chen , Al Cooper , Pratyush Yadav , Rahul T R , Swapnil Jakhade , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Liu Ying , Yuan Can , Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Matthias Brugger , Thomas Gleixner , Allison Randal , Greg Kroah-Hartman , Miaoqian Lin , Andy Gross , Bjorn Andersson , Yoshihiro Shimoda , Heiko Stuebner , Maxime Coquelin , Alexandre Torgue , Amelie Delaunay , Dan Carpenter , Fabrice Gasnier , JC Kuo , Thierry Reding , Jonathan Hunter , Roger Quadros , Matt Ranostay , Sinthu Raja , Vignesh Raghavendra , Tanmay Patil , Siddharth Vadapalli , Lv Ruyi Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de, Broadcom internal kernel review list , Fabio Estevam , NXP Linux Team , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org Subject: [PATCH 00/31] phy: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:29 +0100 Message-Id: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=5818; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=MYs5JN8sdLbdhFqX1o8FkbSoO7sfiFpKaRQbsKFPJqQ=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkByZ3qXmeqAA+C0xt3Tbnmc2ihyUokkXi7q3YR NmSTiOqsGOJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmdwAKCRDB/BR4rcrs CQWGB/411PW1y2WnaZUJlgvVPVtj4QZujEz8AqlBRHTptyhx5CaQGlPe5Xdx6F1Q5b+kPwyAdD9 /HAdHufSEHfPbZGDUn4HLokWRJ8EGqimHminkBYxmUvdoH5XYFmaQwZ6a88+sD124laNpghG7TD rX6oqjXAt4PTE/fQrGyqD/tWwDxLRZpczwfFESmWk28IPcjCEOQQP+2oSas8Mef2Oc8JJQWBCvl YDEq69SPXLHguNB1ZudTCSbi4KAzJ9LHrwEWqumQjr2K3Du5Gg91o9+6EaSl2YQGu5XnPFgmqQ3 cWA/IVc9vOXlx2ruwlHvEB1wcclx//PSUSpKGg2356dPcYJG X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-msm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hello, this patch series adapts the platform drivers below drivers/phy to use the .remove_new() callback. Compared to the traditional .remove() callback .remove_new() returns no value. This is a good thing because the driver core doesn't (and cannot) cope for errors during remove. The only effect of a non-zero return value in .remove() is that the driver core emits a warning. The device is removed anyhow and an early return from .remove() usually yields a resource leak. By changing the remove callback to return void driver authors cannot reasonably assume any more that there is some kind of cleanup later. All drivers in drivers/spmi returned zero unconditionally in their remove callback, so they could all be converted trivially to .remove_new(). Note that this series depends on commit 5c5a7680e67b ("platform: Provide a remove callback that returns no value") which is included in v6.3-rc1. Best regards Uwe Uwe Kleine-König (31): phy: allwinner: phy-sun4i-usb: Convert to platform remove callback returning void phy: broadcom: phy-brcm-usb: Convert to platform remove callback returning void phy: cadence: cdns-dphy: Convert to platform remove callback returning void phy: cadence: phy-cadence-sierra: Convert to platform remove callback returning void phy: cadence: phy-cadence-torrent: Convert to platform remove callback returning void phy: freescale: phy-fsl-imx8qm-lvds-phy: Convert to platform remove callback returning void phy: intel: phy-intel-lgm-combo: Convert to platform remove callback returning void phy: mediatek: phy-mtk-mipi-dsi: Convert to platform remove callback returning void phy: motorola: phy-cpcap-usb: Convert to platform remove callback returning void phy: motorola: phy-mapphone-mdm6600: Convert to platform remove callback returning void phy: phy-lgm-usb: Convert to platform remove callback returning void phy: qualcomm: phy-qcom-apq8064-sata: Convert to platform remove callback returning void phy: qualcomm: phy-qcom-eusb2-repeater: Convert to platform remove callback returning void phy: qualcomm: phy-qcom-ipq806x-sata: Convert to platform remove callback returning void phy: renesas: phy-rcar-gen3-pcie: Convert to platform remove callback returning void phy: renesas: phy-rcar-gen3-usb2: Convert to platform remove callback returning void phy: renesas: phy-rcar-gen3-usb3: Convert to platform remove callback returning void phy: renesas: r8a779f0-ether-serdes: Convert to platform remove callback returning void phy: rockchip: phy-rockchip-inno-csidphy: Convert to platform remove callback returning void phy: rockchip: phy-rockchip-inno-dsidphy: Convert to platform remove callback returning void phy: rockchip: phy-rockchip-inno-hdmi: Convert to platform remove callback returning void phy: rockchip: phy-rockchip-typec: Convert to platform remove callback returning void phy: st: phy-stm32-usbphyc: Convert to platform remove callback returning void phy: tegra: xusb: Convert to platform remove callback returning void phy: ti: phy-am654-serdes: Convert to platform remove callback returning void phy: ti: phy-da8xx-usb: Convert to platform remove callback returning void phy: ti: phy-dm816x-usb: Convert to platform remove callback returning void phy: ti: phy-j721e-wiz: Convert to platform remove callback returning void phy: ti: phy-omap-usb2: Convert to platform remove callback returning void phy: ti: phy-ti-pipe3: Convert to platform remove callback returning void phy: ti: phy-twl4030-usb: Convert to platform remove callback returning void drivers/phy/allwinner/phy-sun4i-usb.c | 6 ++---- drivers/phy/broadcom/phy-brcm-usb.c | 6 ++---- drivers/phy/cadence/cdns-dphy.c | 6 ++---- drivers/phy/cadence/phy-cadence-sierra.c | 6 ++---- drivers/phy/cadence/phy-cadence-torrent.c | 6 ++---- drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c | 6 ++---- drivers/phy/intel/phy-intel-lgm-combo.c | 5 ++--- drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 5 ++--- drivers/phy/motorola/phy-cpcap-usb.c | 6 ++---- drivers/phy/motorola/phy-mapphone-mdm6600.c | 6 ++---- drivers/phy/phy-lgm-usb.c | 6 ++---- drivers/phy/qualcomm/phy-qcom-apq8064-sata.c | 6 ++---- drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c | 8 +++----- drivers/phy/qualcomm/phy-qcom-ipq806x-sata.c | 6 ++---- drivers/phy/renesas/phy-rcar-gen3-pcie.c | 6 ++---- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 6 ++---- drivers/phy/renesas/phy-rcar-gen3-usb3.c | 6 ++---- drivers/phy/renesas/r8a779f0-ether-serdes.c | 6 ++---- drivers/phy/rockchip/phy-rockchip-inno-csidphy.c | 6 ++---- drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 6 ++---- drivers/phy/rockchip/phy-rockchip-inno-hdmi.c | 6 ++---- drivers/phy/rockchip/phy-rockchip-typec.c | 6 ++---- drivers/phy/st/phy-stm32-usbphyc.c | 6 ++---- drivers/phy/tegra/xusb.c | 6 ++---- drivers/phy/ti/phy-am654-serdes.c | 6 ++---- drivers/phy/ti/phy-da8xx-usb.c | 6 ++---- drivers/phy/ti/phy-dm816x-usb.c | 6 ++---- drivers/phy/ti/phy-j721e-wiz.c | 6 ++---- drivers/phy/ti/phy-omap-usb2.c | 6 ++---- drivers/phy/ti/phy-ti-pipe3.c | 6 ++---- drivers/phy/ti/phy-twl4030-usb.c | 6 ++---- 31 files changed, 63 insertions(+), 123 deletions(-) base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6