| Message ID | 20230118010428.1671443-1-dmitry.baryshkov@linaro.org |
|---|---|
| Headers | show |
| Series | drm/msm/mdss: rework UBWC setup | expand |
On Wed, 18 Jan 2023 03:04:25 +0200, Dmitry Baryshkov wrote: > The commit 92bab9142456 ("drm/msm: less magic numbers in > msm_mdss_enable") reworked the static UBWC setup to replace magic > numbers with calulating written values from the SoC/device parameters. > This simplified adding new platforms. > However I did not estimate that the values would still be cryptic and > would be C&P-sted instead of being determined from the vendor DT. Some > of the platform (sc8180x) completely missed this setup step. > > [...] Applied, thanks! [1/3] drm/msm/mdss: convert UBWC setup to use match data https://gitlab.freedesktop.org/lumag/msm/-/commit/f4abcfab7667 [2/3] drm/msm/mdss: add data for sc8180xp https://gitlab.freedesktop.org/lumag/msm/-/commit/2c3415835aaf [3/3] drm/msm/mdss: add the sdm845 data for completeness https://gitlab.freedesktop.org/lumag/msm/-/commit/4b411abf95f9 Best regards,
The commit 92bab9142456 ("drm/msm: less magic numbers in msm_mdss_enable") reworked the static UBWC setup to replace magic numbers with calulating written values from the SoC/device parameters. This simplified adding new platforms. However I did not estimate that the values would still be cryptic and would be C&P-sted instead of being determined from the vendor DT. Some of the platform (sc8180x) completely missed this setup step. This series attempts to rework the static UBWC setup to be both manageable and hopefully easier to write. Changes since RFC: - Merged sm6115 fixup patch into the main patch, since only the comment was incorrect - Moved reading HW revision and UBWC decoder version to the error case only Dmitry Baryshkov (3): drm/msm/mdss: convert UBWC setup to use match data drm/msm/mdss: add data for sc8180xp drm/msm/mdss: add the sdm845 data for completeness drivers/gpu/drm/msm/msm_mdss.c | 198 ++++++++++++++++++++------------- 1 file changed, 120 insertions(+), 78 deletions(-)