mbox series

[v4,0/3] arm64: dts: qcom: sc8280xp: add audio support

Message ID 20221123104342.26140-1-srinivas.kandagatla@linaro.org
Headers show
Series arm64: dts: qcom: sc8280xp: add audio support | expand

Message

Srinivas Kandagatla Nov. 23, 2022, 10:43 a.m. UTC 
This patchset adds audio support for sc8280xp Lenovo x13s.
Support for Headset Playback/Capture, Speaker Playback and DMIC is
tested.

A prebuit ASoC topology file available at
https://git.linaro.org/people/srinivas.kandagatla/audioreach-topology.git/tree/prebuilt/SC8280XP-LENOVO-X13S-tplg.bin


Thanks to Johan, Kryz and Konrad for reviewing v1.

Changes since v3:
	- ordered include in gpr patch
	- removed sa8540p in subject perfix.
Thanks,
Srini

Srinivas Kandagatla (3):
  arm64: dts: qcom: sc8280xp: add gpr node
  arm64: dts: qcom: sc8280xp: add SoundWire and LPASS
  arm64: dts: qcom: sc8280xp-x13s: Add soundcard support

 .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts    | 213 +++++++++++
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi        | 359 ++++++++++++++++++
 2 files changed, 572 insertions(+)

Comments

Bjorn Andersson Dec. 28, 2022, 4:36 a.m. UTC | #1 
On Wed, 23 Nov 2022 10:43:39 +0000, Srinivas Kandagatla wrote:
> This patchset adds audio support for sc8280xp Lenovo x13s.
> Support for Headset Playback/Capture, Speaker Playback and DMIC is
> tested.
> 
> A prebuit ASoC topology file available at
> https://git.linaro.org/people/srinivas.kandagatla/audioreach-topology.git/tree/prebuilt/SC8280XP-LENOVO-X13S-tplg.bin
> 
> [...]

Applied, thanks!

[1/3] arm64: dts: qcom: sc8280xp: add gpr node
      commit: e73defb2deee74f3f4988196bf0c21782dffa415
[2/3] arm64: dts: qcom: sc8280xp: add SoundWire and LPASS
      commit: c18773d162a63f65024e80ae355e3fbc923e7255
[3/3] arm64: dts: qcom: sc8280xp-x13s: Add soundcard support
      commit: f29077d8665221ba2802a29ee7bd9fcef66cde81

Best regards,
Johan Hovold Dec. 28, 2022, 12:01 p.m. UTC | #2 
On Tue, Dec 27, 2022 at 10:36:56PM -0600, Bjorn Andersson wrote:
> On Wed, 23 Nov 2022 10:43:39 +0000, Srinivas Kandagatla wrote:
> > This patchset adds audio support for sc8280xp Lenovo x13s.
> > Support for Headset Playback/Capture, Speaker Playback and DMIC is
> > tested.
> > 
> > A prebuit ASoC topology file available at
> > https://git.linaro.org/people/srinivas.kandagatla/audioreach-topology.git/tree/prebuilt/SC8280XP-LENOVO-X13S-tplg.bin
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/3] arm64: dts: qcom: sc8280xp: add gpr node
>       commit: e73defb2deee74f3f4988196bf0c21782dffa415
> [2/3] arm64: dts: qcom: sc8280xp: add SoundWire and LPASS
>       commit: c18773d162a63f65024e80ae355e3fbc923e7255
> [3/3] arm64: dts: qcom: sc8280xp-x13s: Add soundcard support
>       commit: f29077d8665221ba2802a29ee7bd9fcef66cde81

Perhaps merging this was a bit premature. I just gave it a spin, but
this is apparently not even expected to work without various changes
that are still work in progress. For example, the codecs fails to probe
with:

[   11.077727] qcom-prm gprsvc:service:2:2: DSP returned error[100100f] 1
[   11.077926] rx_macro: probe of 3200000.rxmacro failed with error -22

and you need an out-of-tree hack to get around that:

	https://git.linaro.org/people/srinivas.kandagatla/linux.git/commit/?h=lenovo-x13s-6.1.0-rc7-audio&id=0bffb619bf7929c56b7458af3a583fa9ce87fc26

I learned that the hard way after a debugging session.

Even with those hacks in place, I see:

[   14.466733] qcom-soundwire 3330000.soundwire-controller: qcom_swrm_irq_handler: SWR bus clsh detected
[   14.522324] qcom-soundwire 3330000.soundwire-controller: swrm_wait_for_frame_gen_enabled: link status not disconnected
[   14.522372] qcom-soundwire 3330000.soundwire-controller: link failed to connect

so this does not look like it was ready to be merged. I'm still not sure
what else is needed, but there are a bunch of other work-in-progress
changes in the above branch.

Srini, next time can you please document such dependencies in the cover
letter to avoid having people debug things that are not even supposed to
work yet and so that we can hold-off on merging the dts changes until
driver support in place.

Johan