| Message ID | 20220930073754.1391044-1-sheng-liang.pan@quanta.corp-partner.google.com |
|---|---|
| Headers | show |
| Series | Add LTE SKU for sc7280-evoker family | expand |
Hi, On Fri, Sep 30, 2022 at 12:38 AM Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> wrote: > > Change touchpad and touchscreen node for evoker > Touchpad: SA461D-1011 > Touchscreen: GT7986U > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > --- > > (no changes since v1) nit: for patman, add: Series-changes: 5 - Touchscreen / trackpad patch new for v5. ...and then you won't get the confusing "no changes since v1" message. > .../boot/dts/qcom/sc7280-herobrine-evoker.dtsi | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi > index e78072159d54b..c26f19371c8bc 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi > @@ -23,16 +23,15 @@ ap_tp_i2c: &i2c0 { > status = "okay"; > clock-frequency = <400000>; > > - trackpad: trackpad@2c { > - compatible = "hid-over-i2c"; > - reg = <0x2c>; > + trackpad: trackpad@15 { > + compatible = "elan,ekth3000"; > + reg = <0x15>; > pinctrl-names = "default"; > pinctrl-0 = <&tp_int_odl>; > > interrupt-parent = <&tlmm>; > interrupts = <7 IRQ_TYPE_EDGE_FALLING>; > > - hid-descr-addr = <0x20>; > vcc-supply = <&pp3300_z1>; > > wakeup-source; > @@ -43,18 +42,16 @@ ts_i2c: &i2c13 { > status = "okay"; > clock-frequency = <400000>; > > - ap_ts: touchscreen@10 { > - compatible = "elan,ekth6915"; > - reg = <0x10>; > - pinctrl-names = "default"; > - pinctrl-0 = <&ts_int_conn>, <&ts_rst_conn>; Why did you remove the pinctrl? Those should have stayed. > + touchscreen: touchscreen@5d { nit: it's nice to keep the touchscreen label the same as the other herobrine boards, so I'd keep this as: ap_ts: touchscreen@5d { > + compatible = "goodix,gt7375p"; > + reg = <0x5d>; > > interrupt-parent = <&tlmm>; > interrupts = <55 IRQ_TYPE_LEVEL_LOW>; > > reset-gpios = <&tlmm 54 GPIO_ACTIVE_LOW>; > > - vcc33-supply = <&ts_avdd>; > + vdd-supply = <&ts_avdd>; What you have here is fine, but I've heard rumors that we might end up needing to specify a different IO voltage rail. Right now the goodix bindings / goodix driver don't handle that. ...anyway, no action items for you right now but just a heads up. -Doug
This patch add common dtsi and WIFI/LTE dts for evoker. Changes in v5: - new patch add touchpad and touchscreen for evoker - remove unnecessary whitespace Changes in v4: - fix typo in tittle and commit - remove change for trackpad and touchscreen Changes in v3: - none Changes in v2: - none Sheng-Liang Pan (3): dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker arm64: dts: qcom: Add LTE SKU for sc7280-evoker family arm64: dts: qcom: Add touchscreen and touchpad support for evoker .../devicetree/bindings/arm/qcom.yaml | 5 ++++ arch/arm64/boot/dts/qcom/Makefile | 3 ++- .../dts/qcom/sc7280-herobrine-evoker-lte.dts | 14 +++++++++++ .../boot/dts/qcom/sc7280-herobrine-evoker.dts | 15 ++++++++++++ ...er-r0.dts => sc7280-herobrine-evoker.dtsi} | 24 ++++++------------- 5 files changed, 43 insertions(+), 18 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts rename arch/arm64/boot/dts/qcom/{sc7280-herobrine-evoker-r0.dts => sc7280-herobrine-evoker.dtsi} (93%)