mbox series

[v2,0/1] arm64: dts: qcom: pwm: Drop PWM reg dependency

Message ID 20220826123547.3392457-1-bryan.odonoghue@linaro.org
Headers show
Series arm64: dts: qcom: pwm: Drop PWM reg dependency | expand

Message

Bryan O'Donoghue Aug. 26, 2022, 12:35 p.m. UTC 
The accompanying patch removes reg = <> and pwm@reg from the yaml and dtsi.
This follows on from discussions between Bupesh, Dmitry, Bjorn, Krzysztof and myself.

https://lore.kernel.org/all/20220719205058.1004942-1-bhupesh.sharma@linaro.org/
https://lore.kernel.org/all/20220721195502.1525214-1-bhupesh.sharma@linaro.org/
https://lore.kernel.org/all/20220822120300.2633790-1-bryan.odonoghue@linaro.org/

The previous discussion tended towards either removing pwm@reg and reg = <> or
extending out the yaml to support multiple reg declarations for PWM compatible.

This patch does the former. I've left node: label in place, dropped both pwm@reg
and reg = <> I kept "label: nodename" though because it looked more like what we
already have for rpm regulators.

Per our previous discussion I've modified the yaml and dtsi in one go.

Bryan O'Donoghue (1):
  arm64: dts: qcom: pwm: Drop PWM reg dependency

 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
 arch/arm64/boot/dts/qcom/pm8350c.dtsi                     | 3 +--
 2 files changed, 5 insertions(+), 6 deletions(-)

Comments

Krzysztof Kozlowski Aug. 27, 2022, 9:31 a.m. UTC | #1 
On 26/08/2022 15:35, Bryan O'Donoghue wrote:
> Drop the reg dependency from the qcom PWM description.
> 
> The PWM driver doesn't depend on the reg so we should drop the dependency
> and remove the pwm@reg from the nodename.

Driver is not really a sufficient reason. Based on
https://lore.kernel.org/all/CAA8EJppGS38aP7gyd1c3kNgraAVJDoqUef2cDfZpu2aL_iwW0g@mail.gmail.com/
reason could be:

The PWM node is not a separate device and is expected to be part of
parent SPMI PMIC node, thus it obtains the address space from the
parent. One IO address in "reg" is also not correct description because
LPG block maps to several regions.

> 
> Fixes: e79a1385ab74 ("arm64: dts: qcom: Add LPG to pm8916, pm8994, pmi8994 and pmi8998")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
>  arch/arm64/boot/dts/qcom/pm8350c.dtsi                     | 3 +--

Patches should be split. One patchset, but two patches.

>  2 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index 65cbc6dee545e..2a5bafe0660a0 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -92,6 +92,10 @@ properties:
>      type: object
>      $ref: /schemas/regulator/regulator.yaml#
>  

Best regards,
Krzysztof