| Message ID | 20220811100924.79505-1-manivannan.sadhasivam@linaro.org |
|---|---|
| Headers | show |
| Series | Fix crash when using Qcom LLCC/EDAC drivers | expand |
On Thu, Aug 11, 2022 at 12:48:37PM +0200, Borislav Petkov wrote: > On Thu, Aug 11, 2022 at 03:39:22PM +0530, Manivannan Sadhasivam wrote: > > Hello, > > > > This series fixes the crash seen on the Qualcomm SM8450 chipset with the > > LLCC/EDAC drivers. The problem was due to the Qcom EDAC driver using the > > fixed LLCC register offsets for detecting the LLCC errors. > > I see you've CCed the QCOM maintainers using different email addresses: > > $ ./scripts/get_maintainer.pl -f drivers/edac/qcom_edac.c > Channagoud Kadabi <ckadabi@codeaurora.org> (maintainer:EDAC-QCOM) > Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org> (maintainer:EDAC-QCOM) > > Does MAINTAINERS need updating? No, it doesn't. The email addresses you used, bounce: Delivery has failed to these recipients or groups: vnkgutta@quicinc.com<mailto:vnkgutta@quicinc.com> The email address you entered couldn't be found. Please check the recipient's email address and try to resend the message. If the problem continues, +please contact your email admin. ckadabi@quicinc.com<mailto:ckadabi@quicinc.com> The email address you entered couldn't be found. Please check the recipient's email address and try to resend the message. If the problem continues, +please contact your email admin. In the future, when you wonder who to Cc and how, scripts/get_maintainer.pl is your friend. HTH.
On Thu, Aug 11, 2022 at 12:53:30PM +0200, Borislav Petkov wrote: > On Thu, Aug 11, 2022 at 12:48:37PM +0200, Borislav Petkov wrote: > > On Thu, Aug 11, 2022 at 03:39:22PM +0530, Manivannan Sadhasivam wrote: > > > Hello, > > > > > > This series fixes the crash seen on the Qualcomm SM8450 chipset with the > > > LLCC/EDAC drivers. The problem was due to the Qcom EDAC driver using the > > > fixed LLCC register offsets for detecting the LLCC errors. > > > > I see you've CCed the QCOM maintainers using different email addresses: > > > > $ ./scripts/get_maintainer.pl -f drivers/edac/qcom_edac.c > > Channagoud Kadabi <ckadabi@codeaurora.org> (maintainer:EDAC-QCOM) > > Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org> (maintainer:EDAC-QCOM) > > > > Does MAINTAINERS need updating? > > No, it doesn't. The email addresses you used, bounce: > > Delivery has failed to these recipients or groups: > > vnkgutta@quicinc.com<mailto:vnkgutta@quicinc.com> > The email address you entered couldn't be found. Please check the recipient's email address and try to resend the message. If the problem continues, > +please contact your email admin. > > > ckadabi@quicinc.com<mailto:ckadabi@quicinc.com> > The email address you entered couldn't be found. Please check the recipient's email address and try to resend the message. If the problem continues, > +please contact your email admin. > > In the future, when you wonder who to Cc and how, > > scripts/get_maintainer.pl > > is your friend. > I know get_maintainer.pl :) But the problem is, Qualcomm recently switched their email domain from codeaurora.org to quicinc.com. So even if I use the maintainers codeaurora domain now, they will bounce. For that reason, I used their quicinc domain addresses. But since they are bouncing, it looks like the maintainers left Qualcomm :/ Thanks, Mani > HTH. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette
On Thu, Aug 11, 2022 at 04:50:32PM +0530, Manivannan Sadhasivam wrote: > I know get_maintainer.pl :) But the problem is, Qualcomm recently > switched their email domain from codeaurora.org to quicinc.com. Great: $ git grep codeaurora.org MAINTAINERS | wc -l 5 ;-\ > So even if I use the maintainers codeaurora domain now, they will > bounce. Hmm, so the mails I sent with codeaurora on Cc didn't bounce back - I got only the quicinc bounces. That doesn't mean that codeaurora actually gets delivered... > For that reason, I used their quicinc domain addresses. But since they > are bouncing, it looks like the maintainers left Qualcomm :/ Hmm, is there some way to get in touch with those folks? Or whoever is taking over those drivers? Thx.
Clipped the bouncing email addresses... On Thu, Aug 11, 2022 at 05:23:34PM +0530, Manivannan Sadhasivam wrote: > On Thu, Aug 11, 2022 at 01:33:06PM +0200, Borislav Petkov wrote: > > On Thu, Aug 11, 2022 at 04:50:32PM +0530, Manivannan Sadhasivam wrote: > > > I know get_maintainer.pl :) But the problem is, Qualcomm recently > > > switched their email domain from codeaurora.org to quicinc.com. > > > > Great: > > > > $ git grep codeaurora.org MAINTAINERS | wc -l > > 5 > > > > Yep! Most of the active developers have already changed their domains in > MAINTAINERS file. But the left ones are either not actively maintained > (yeah bad) or the maintainers have left Qualcomm. > > > ;-\ > > > > > So even if I use the maintainers codeaurora domain now, they will > > > bounce. > > > > Hmm, so the mails I sent with codeaurora on Cc didn't bounce back - I > > got only the quicinc bounces. That doesn't mean that codeaurora actually > > gets delivered... > > > > Not sure why. It was supposed to bounce. But could be that Qualcomm IT > decided to not bounce anymore since they have got enough complaints from > developers ;) > Okay, seems to be bouncing for me: The response from the remote server was: 585 5.1.1 <ckadabi@codeaurora.org>: Recipient address rejected: undeliverable address: No such user here. 585 5.1.1 <vnkgutta@codeaurora.org>: Recipient address rejected: undeliverable address: No such user here. Thanks, Mani > > > For that reason, I used their quicinc domain addresses. But since they > > > are bouncing, it looks like the maintainers left Qualcomm :/ > > > > Hmm, is there some way to get in touch with those folks? > > > > I don't think so. I checked in the internal Qualcomm database and > confirmed that I couldn't find the maintainers names there. > > > Or whoever is taking over those drivers? > > > > LLCC is maintained by Bjorn (CCed) since it falls under soc/qcom. But I'm > not sure about EDAC. I think we should mark it as not maintainted until we > find a volunteer. > > Bjorn, thoughts? > > Thanks, > Mani > > > Thx. > > > > -- > > Regards/Gruss, > > Boris. > > > > https://people.kernel.org/tglx/notes-about-netiquette
On Thu, Aug 11, 2022 at 09:08:14AM -0700, Trilok Soni wrote: > Hello Mani, > > On 8/11/2022 4:57 AM, Manivannan Sadhasivam wrote: > > Clipped the bouncing email addresses... > > > > On Thu, Aug 11, 2022 at 05:23:34PM +0530, Manivannan Sadhasivam wrote: > > > On Thu, Aug 11, 2022 at 01:33:06PM +0200, Borislav Petkov wrote: > > > > On Thu, Aug 11, 2022 at 04:50:32PM +0530, Manivannan Sadhasivam wrote: > > > > > I know get_maintainer.pl :) But the problem is, Qualcomm recently > > > > > switched their email domain from codeaurora.org to quicinc.com. > > > > > > > > Great: > > > > > > > > $ git grep codeaurora.org MAINTAINERS | wc -l > > > > 5 > > > > > > > > > > Yep! Most of the active developers have already changed their domains in > > > MAINTAINERS file. But the left ones are either not actively maintained > > > (yeah bad) or the maintainers have left Qualcomm. > > > > > > > ;-\ > > > > > > > > > So even if I use the maintainers codeaurora domain now, they will > > > > > bounce. > > > > > > > > Hmm, so the mails I sent with codeaurora on Cc didn't bounce back - I > > > > got only the quicinc bounces. That doesn't mean that codeaurora actually > > > > gets delivered... > > > > > > > > > > Not sure why. It was supposed to bounce. But could be that Qualcomm IT > > > decided to not bounce anymore since they have got enough complaints from > > > developers ;) > > > > > > > Okay, seems to be bouncing for me: > > > > The response from the remote server was: > > 585 5.1.1 <ckadabi@codeaurora.org>: Recipient address rejected: undeliverable address: No such user here. > > 585 5.1.1 <vnkgutta@codeaurora.org>: Recipient address rejected: undeliverable address: No such user here. > > It is ok if someone from Linaro team becomes the maintainer for this driver. > Thanks Trilok for the confirmation! I'll add myself as the maintainer. Thanks, Mani > ---Trilok Soni
Hello, This series fixes the crash seen on the Qualcomm SM8450 chipset with the LLCC/EDAC drivers. The problem was due to the Qcom EDAC driver using the fixed LLCC register offsets for detecting the LLCC errors. This seems to have worked for SoCs till SM8450. But in SM8450, the LLCC register offsets were changed. So accessing the fixed offsets causes the crash on this platform. So for fixing this issue, and also to make it work on future SoCs, let's pass the LLCC offsets from the Qcom LLCC driver based on the individual SoCs and let the EDAC driver make use of them. This series has been tested on SM8450 based dev board. Thanks, Mani Manivannan Sadhasivam (2): soc: qcom: llcc: Pass SoC specific EDAC register offsets to EDAC driver EDAC/qcom: Get rid of hardcoded register offsets drivers/edac/qcom_edac.c | 112 ++++++++++++++--------------- drivers/soc/qcom/llcc-qcom.c | 64 +++++++++++++++++ include/linux/soc/qcom/llcc-qcom.h | 35 +++++++-- 3 files changed, 147 insertions(+), 64 deletions(-)