Message ID | 20220711092117.360797-1-dmitry.baryshkov@linaro.org |
---|---|
Headers | show |
Series | drm/bridge: ti-sn65dsi86: support DRM_BRIDGE_ATTACH_NO_CONNECTOR | expand |
Hi, On Mon, Jul 11, 2022 at 2:21 AM Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > Now as the driver does not depend on pdata->connector, add support for > attaching the bridge with DRM_BRIDGE_ATTACH_NO_CONNECTOR. > > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) This has been on my list of annoyances for quite some time now. Most excellent to have it fixed, thanks! Reviewed-by: Douglas Anderson <dianders@chromium.org> Tested together with patch #1. Tested-by: Douglas Anderson <dianders@chromium.org> Unless someone yells that there's a problem or someone beats me to it, I'll plan to land in drm-misc-next sometime next week. -Doug
On 7/11/22 4:21 AM, Dmitry Baryshkov wrote: > Now as the driver does not depend on pdata->connector, add support for > attaching the bridge with DRM_BRIDGE_ATTACH_NO_CONNECTOR. > > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index b362a7bf4d97..369bf72717f6 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -698,11 +698,6 @@ static int ti_sn_bridge_attach(struct drm_bridge *bridge, > struct ti_sn65dsi86 *pdata = bridge_to_ti_sn65dsi86(bridge); > int ret; > > - if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) { > - DRM_ERROR("Fix bridge driver to make connector optional!"); > - return -EINVAL; > - } > - > pdata->aux.drm_dev = bridge->dev; > ret = drm_dp_aux_register(&pdata->aux); > if (ret < 0) { > @@ -710,15 +705,18 @@ static int ti_sn_bridge_attach(struct drm_bridge *bridge, > return ret; > } > > - /* We never want the next bridge to *also* create a connector: */ > - flags |= DRM_BRIDGE_ATTACH_NO_CONNECTOR; > - > - /* Attach the next bridge */ > + /* > + * Attach the next bridge. > + * We never want the next bridge to *also* create a connector. > + */ > ret = drm_bridge_attach(bridge->encoder, pdata->next_bridge, > - &pdata->bridge, flags); > + &pdata->bridge, flags | DRM_BRIDGE_ATTACH_NO_CONNECTOR); > if (ret < 0) > goto err_initted_aux; > > + if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) > + return 0; > + > pdata->connector = drm_bridge_connector_init(pdata->bridge.dev, > pdata->bridge.encoder); > if (IS_ERR(pdata->connector)) { Tested on Lenovo Yoga C630 Tested-by: Steev Klimaszewski <steev@kali.org>
Hi, On Mon, Jul 11, 2022 at 10:23 AM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Mon, Jul 11, 2022 at 2:21 AM Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: > > > > Now as the driver does not depend on pdata->connector, add support for > > attaching the bridge with DRM_BRIDGE_ATTACH_NO_CONNECTOR. > > > > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 18 ++++++++---------- > > 1 file changed, 8 insertions(+), 10 deletions(-) > > This has been on my list of annoyances for quite some time now. Most > excellent to have it fixed, thanks! > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > Tested together with patch #1. > > Tested-by: Douglas Anderson <dianders@chromium.org> > > > Unless someone yells that there's a problem or someone beats me to it, > I'll plan to land in drm-misc-next sometime next week. Landed on drm-misc-next: 6e2dc7ac7141 drm/bridge: ti-sn65dsi86: support DRM_BRIDGE_ATTACH_NO_CONNECTOR