Message ID | 20220608120723.2987843-1-dmitry.baryshkov@linaro.org |
---|---|
Headers | show |
Series | drm/msm/hdmi: YAML-ify schema and cleanup some platform properties | expand |
On 08/06/2022 23:59, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2022-06-08 05:07:17) >> @@ -543,41 +529,16 @@ static int msm_hdmi_bind(struct device *dev, struct device *master, void *data) >> hdmi_cfg->mmio_name = "core_physical"; >> hdmi_cfg->qfprom_mmio_name = "qfprom_physical"; >> >> - for (i = 0; i < HDMI_MAX_NUM_GPIO; i++) { > [...] >> - if (gpiod) >> - gpiod_set_consumer_name(gpiod, msm_hdmi_gpio_pdata[i].label); >> - hdmi_cfg->gpios[i].output = msm_hdmi_gpio_pdata[i].output; >> - hdmi_cfg->gpios[i].value = msm_hdmi_gpio_pdata[i].value; >> - } >> + hdmi->hpd_gpiod = devm_gpiod_get_optional(dev, "hpd", GPIOD_IN); >> + /* This will catch e.g. -PROBE_DEFER */ > > EPROBE_DEFER? Ack. > >> + if (IS_ERR(hdmi->hpd_gpiod)) >> + return PTR_ERR(hdmi->hpd_gpiod); >> + >> + if (!hdmi->hpd_gpiod) >> + DBG("failed to get HPD gpio"); > > Does DBG() add newlines? Yes, it does. > >> + >> + if (hdmi->hpd_gpiod) >> + gpiod_set_consumer_name(hdmi->hpd_gpiod, "HDMI_HPD"); >> >> dev->platform_data = hdmi_cfg; >>
On 09/06/2022 01:45, David Heidelberg wrote: > On 08/06/2022 14:37, Krzysztof Kozlowski wrote: >> On 08/06/2022 14:07, Dmitry Baryshkov wrote: >>> Convert Qualcomm HDMI binding into HDMI TX and PHY yaml bindings. >>> >>> Changes to schema: >>> HDMI: >>> - fixed reg-names numbering to match 0..3 instead 0,1,3,4 >>> - dropped qcom,tx-ddc-* from example, they were not documented >>> >>> PHY: >>> - moved into phy/ directory >>> - split into QMP and non-QMP PHY schemas >>> >>> Co-developed-by: David Heidelberg <david@ixit.cz> >> David also needs to SoB here. > > no problem, for this or any later version of patches developed by me: > > Signed-off-by: David Heidelberg <david@ixit.cz> Thanks!