| Message ID | 20220521152049.1490220-1-dmitry.baryshkov@linaro.org |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: initial Inforce IFC6560 board support | expand |
On 2022-05-21 18:20:49, Dmitry Baryshkov wrote: > Add binding documentation for the Inforce IFC6560 board which uses > Snapdragon SDA660. > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Nit: don't dt-bindings patches go _before_ using these in dts? In ohter words, should patch 10 and 11 be swapped? > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 129cdd246223..ac4ee0f874ea 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -41,6 +41,7 @@ description: | > sa8155p > sc7180 > sc7280 > + sda660 > sdm630 > sdm632 > sdm660 > @@ -225,6 +226,11 @@ properties: > - google,senor > - const: qcom,sc7280 > > + - items: > + - enum: > + - inforce,ifc6560 > + - const: qcom,sda660 > + > - items: > - enum: > - fairphone,fp3 > -- > 2.35.1 >
On 21/05/2022 17:20, Dmitry Baryshkov wrote: > Add binding documentation for the Inforce IFC6560 board which uses > Snapdragon SDA660. > > Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 129cdd246223..ac4ee0f874ea 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -41,6 +41,7 @@ description: | > sa8155p > sc7180 > sc7280 > + sda660 I wanted to base my work on top of it, but this patch does not apply. I think you based it on something out of date, also judging by my old email address you are using (in each patchset). The patches should be based on current development tree. Best regards, Krzysztof
This work is largely based on the previous work by Bjorn Andersson ([1]) Changes since v5: - Drop icc patch, as there are questions whether the original paths are valid. It will be submitted separately. Changes since v4: - Remove unused mdp and sd-card-det-n DT nodes from the ifc6560 dts (thanks to Konrad). Changes since v3 (most points based on review by Marijn): - Fixed a typo in dsi0 patch - Fixed indentation here and there - Renamed qusb2phy to qusb2phy0 to play better with qusb2phy1 - Fixed the ICC path for the GPU - Fixed sdhc2 pinconf for sdm636-sony-xperia-ganges-mermaid - Moved SDHC2 card detect gpio pin to board files Changes since v2: - Removed useless enablement of mdp node from the board file. It is already enabled in the SoC dtsi file. Changes since v1 (mostly based on Kondrad's review): - Also disabled dsi0/dsi0 phy in sdm630.dtsi - Removed the clock from BAM DMA devices rather than disabling them completely - Replaced numbers with symbolic names for interconnects in sdm630.dtsi - Switched to "qcom,sda660" as a fallback compatible string - Added dt-bindings for the qcom,sda660 compat - Removed extra nesting level from the adsp firmware path - Replaced numbers with proper symbolic names in the board file - Added chassis-type property - Changed the order of blsp entries in the board file - Removed spurious newlines - Changed the order of regulator properties - Changed the DSI data-lines to list all four lanes. Still use just three lanes for the adv bridge (and describe the reason in the comment) Changes since Bjorn's v2: - Disable dsi1, dsi1 phy, GPU by default in sdm660.dtsi/sdm630.dtsi - Fix qusb2phy ref clock - Added USB2 host support to sdm630.dtsi - Renamed DTS to follow SoC-vendor-board pattern - Fixed vph_pwr voltage - Removed extra/unrelated comments - Added keys, USB2, USB3, - Added configuration for the attached HDMI bridge - Enabled MDP, MDSS and DSI0/DSI0 PHY devices - Removed uart pinctrl and /reserved-mem nodes (present in main dtsi file) - Added card detection for the SDCC2 - Disabled BLSP BAM DMA devices, they make the board reset during boot [1] https://lore.kernel.org/linux-arm-msm/20210825221110.1498718-1-bjorn.andersson@linaro.org/#t Dmitry Baryshkov (11): arm64: dts: qcom: sdm630: disable dsi0/dsi0_phy by default arm64: dts: qcom: sdm660: disable dsi1/dsi1_phy by default arm64: dts: qcom: sdm630: disable GPU by default arm64: dts: qcom: sdm630: fix the qusb2phy ref clock arm64: dts: qcom: sdm630: rename qusb2phy to qusb2phy0 arm64: dts: qcom: sdm630: add second (HS) USB host support arm64: dts: qcom: sdm630: fix gpu's interconnect path arm64: dts: qcom: sdm636-sony-xperia-ganges-mermaid: correct sdc2 pinconf arm64: dts: qcom: sdm660: move SDHC2 card detect pinconf to board files arm64: dts: qcom: sdm660: Add initial Inforce IFC6560 board support dt-bindings: arm: qcom: document sda660 SoC and ifc6560 board .../devicetree/bindings/arm/qcom.yaml | 6 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sda660-inforce-ifc6560.dts | 461 ++++++++++++++++++ .../dts/qcom/sdm630-sony-xperia-nile.dtsi | 18 +- arch/arm64/boot/dts/qcom/sdm630.dtsi | 81 ++- .../sdm636-sony-xperia-ganges-mermaid.dts | 2 +- .../boot/dts/qcom/sdm660-xiaomi-lavender.dts | 18 +- arch/arm64/boot/dts/qcom/sdm660.dtsi | 3 + 8 files changed, 571 insertions(+), 19 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts