| Message ID | 20220418205509.1102109-1-bhupesh.sharma@linaro.org |
|---|---|
| Headers | show |
| Series | Fix dtbs_check warning(s) for Qualcomm QMP PHY | expand |
On Tue, 19 Apr 2022 02:25:06 +0530, Bhupesh Sharma wrote: > '#clock-cells' is not a required property for qmp-phy(s) in the > '/' node, but it should be is used in 'phy@' subnode (where it is > actually a 'required' property). Fix the same. > > This also fixes the following 'make dtbs_check' warning(s): > > sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: > '#clock-cells' is a required property > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ phy@1c07000: 'lanes@1c06000' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm/boot/dts/qcom-sdx55-mtp.dtb arch/arm/boot/dts/qcom-sdx55-t55.dtb arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dtb phy@1c0e000: 'lanes@1c0e200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sc7280-crd.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dtb arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb arch/arm64/boot/dts/qcom/sc7280-idp2.dtb arch/arm64/boot/dts/qcom/sc7280-idp.dtb phy@1d87000: 'lanes@1d87400', 'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sm8450-hdk.dtb arch/arm64/boot/dts/qcom/sm8450-qrd.dtb phy@1d87000: 'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dtb phy@627000: 'vdda-phy-max-microamp', 'vdda-pll-max-microamp', 'vddp-ref-clk-always-on', 'vddp-ref-clk-max-microamp' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dtb arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dtb phy-wrapper@88e9000: 'vdda-phy-supply' is a required property arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx214.dtb arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dtb phy-wrapper@88e9000: 'vdda-pll-supply' is a required property arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx214.dtb arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dtb ssphy@78000: '#clock-cells', 'lane@78200' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb
Changes since v2: ----------------- - v2 can be found here: https://lore.kernel.org/linux-arm-msm/20220228123019.382037-1-bhupesh.sharma@linaro.org/ - Addressed review comments from Rob and Shawn. - Collected ACK from Rob on [PATCH 2/4]. - Since, Bjorn accepted 4 patches from v2 already, drop them for this series. - This series is rebased on linux-next/master. Changes since v1: ----------------- - v1 can be found here: https://www.spinics.net/lists/linux-arm-msm/msg104871.html - Addressed review comments from Dmitry. - Addressed the remaining dtbs_check warnings rasied by Rob's bot on v1. Shawn Guo recently fixed a large number of 'dtbs_check' warnings on Qualcomm DTS files for qmp phys. However a few warnings are still left (possibly due to new dts files being added over time). So, I decided to clean them up. After this series, '$ make dtbs_check' leads to no warning for QCOM QMP PHY. Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Rob Herring <robh@kernel.org> Bhupesh Sharma (4): dt-bindings: phy: qcom,qmp: Mark '#clock-cells' as a 'optional' property dt-bindings: phy: qcom,qmp: Describe 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties dt-bindings: phy: qcom,qmp: Describe phy@ subnode properly arm64: dts: qcom: sm8450: Fix qmp phy node (use phy@ instead of lanes@) .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 29 +++++++++++++++---- arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 +-- 2 files changed, 26 insertions(+), 7 deletions(-)