mbox series

[net-next,0/7] net: ipa: use bulk interconnect interfaces

Message ID 20220204195044.1082026-1-elder@linaro.org
Headers show
Series net: ipa: use bulk interconnect interfaces | expand

Message

Alex Elder Feb. 4, 2022, 7:50 p.m. UTC 
The IPA code currently enables and disables interconnects by setting
the bandwidth of each to a non-zero value, or to zero.  The
interconnect API now supports enable/disable functions, so we can
use those instead.  In addition, the interconnect API provides bulk
interfaces that allow all interconnects to be operated on at once.

This series converts the IPA driver to use the bulk enable and
disable interfaces.  In the process it uses some existing data
structures rather than defining new ones.

					-Alex

Alex Elder (7):
  net: ipa: kill struct ipa_interconnect
  net: ipa: use icc_enable() and icc_disable()
  net: ipa: use interconnect bulk enable/disable operations
  net: ipa: use bulk operations to set up interconnects
  net: ipa: use bulk interconnect initialization
  net: ipa: embed interconnect array in the power structure
  net: ipa: use IPA power device pointer

 drivers/net/ipa/ipa_power.c | 178 +++++++++---------------------------
 1 file changed, 42 insertions(+), 136 deletions(-)

Comments

Jakub Kicinski Feb. 5, 2022, 4:23 a.m. UTC | #1 
On Fri,  4 Feb 2022 13:50:40 -0600 Alex Elder wrote:
> The power interconnect array is now an array of icc_bulk_data
> structures, which is what the interconnect bulk enable and disable
> functions require.
> 
> Get rid of ipa_interconnect_enable() and ipa_interconnect_disable(),
> and just call icc_bulk_enable() and icc_bulk_disable() instead.
> 
> Signed-off-by: Alex Elder <elder@linaro.org>

We got a kbuild bot complaint here, for some reason off-list.
Let me drop it from PW for now.
Alex Elder Feb. 5, 2022, 2:35 p.m. UTC | #2 
On 2/4/22 10:23 PM, Jakub Kicinski wrote:
> On Fri,  4 Feb 2022 13:50:40 -0600 Alex Elder wrote:
>> The power interconnect array is now an array of icc_bulk_data
>> structures, which is what the interconnect bulk enable and disable
>> functions require.
>>
>> Get rid of ipa_interconnect_enable() and ipa_interconnect_disable(),
>> and just call icc_bulk_enable() and icc_bulk_disable() instead.
>>
>> Signed-off-by: Alex Elder <elder@linaro.org>
> 
> We got a kbuild bot complaint here, for some reason off-list.
> Let me drop it from PW for now.

OK.  I guess the interconnect code isn't ready for COMPILE_TEST.
I'll investigate that a little more and if we can get past that
I'll send out a new version.  Not sure how long that will take
though...

Thanks, I retract this series for now.

					-Alex