| Message ID | 20220114004303.905808-1-dianders@chromium.org |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: sc7280: Introduce herobrine-rev1 | expand |
Hi, On Thu, Jan 13, 2022 at 10:08 PM Stephen Boyd <swboyd@chromium.org> wrote: > > Quoting Douglas Anderson (2022-01-13 16:43:00) > > When processing sc7280 device trees, I can see: > > > > Warning (simple_bus_reg): /soc@0/gmu@3d69000: > > simple-bus unit address format error, expected "3d6a000" > > > > There's a clear typo in the node name. Fix it. > > > > Fixes: 96c471970b7b ("arm64: dts: qcom: sc7280: Add gpu support") > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> Thanks for all the reviews! > BTW, gmu isn't a "standard" node name so might be worth replacing that > with something else but I have no idea what. Maybe "firmware" or > "power-controller"? "gmu" matches what's in the "example" in Documentation/devicetree/bindings/display/msm/gmu.yaml. That was blessed by Rob Herring. If you think it should be something different, perhaps post a patch changing the example in the bindings? -Doug
This series adds support for herobrine-rev1. Note that it's likely that with the introduction of -rev1 we can drop -rev0 support, but we'll keep it for now (though we won't try to "fit it in" and share code with it). This series is confirmed to boot herobrine-rev1 atop mainline, commit fb3b0673b7d5 ("Merge tag 'mailbox-v5.17' of git://git.linaro.org/landing-teams/working/fujitsu/integration"), though it requires a hack to work around a misconfigured DMA for i2c14 (https://crrev.com/c/3378660) Douglas Anderson (4): arm64: dts: qcom: sc7280: Fix gmu unit address arm64: dts: qcom: sc7280: Move herobrine-r0 to its own dts arm64: dts: qcom: sc7280: Factor out Chrome common fragment arm64: dts: qcom: sc7280: Add herobrine-r1 arch/arm64/boot/dts/qcom/Makefile | 3 +- .../boot/dts/qcom/sc7280-chrome-common.dtsi | 97 ++ .../qcom/sc7280-herobrine-herobrine-r0.dts | 1352 +++++++++++++++++ .../qcom/sc7280-herobrine-herobrine-r1.dts | 314 ++++ arch/arm64/boot/dts/qcom/sc7280-herobrine.dts | 14 - .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 1045 +++---------- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 75 +- arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 557 +++++++ arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +- 9 files changed, 2532 insertions(+), 927 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts delete mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine.dts create mode 100644 arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi