mbox series

[v2,0/3] Add missing A2NoC QoS clocks for SDM660 interconnect driver

Message ID 20210824043435.23190-1-shawn.guo@linaro.org
Headers show
Series Add missing A2NoC QoS clocks for SDM660 interconnect driver | expand

Message

Shawn Guo Aug. 24, 2021, 4:34 a.m. UTC 
The series updates SDM660 interconnect bindings, driver and device tree
to add A2NoC clocks required for QoS registers programming per downstream
kernel[1].  Otherwise, qcom_icc_noc_set_qos_priority() call on mas_ufs or
mas_usb_hs node will simply result in a hardware hang on SDM660 SoC.

Changes for v2:
- Fix dt_binding_check issues
- Drop 'reg' change from DTS patch
- Add Tested-by tag from Bjorn

[1] https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/sdm660-bus.dtsi?h=LA.UM.8.2.r1-04800-sdm660.0#n43

Shawn Guo (3):
  dt-bindings: interconnect: sdm660: Add missing a2noc qos clocks
  interconnect: qcom: sdm660: Add missing a2noc qos clocks
  arm64: dts: qcom: sdm630: Add missing a2noc qos clocks

 .../bindings/interconnect/qcom,sdm660.yaml    | 46 +++++++++++++++++--
 arch/arm64/boot/dts/qcom/sdm630.dtsi          | 15 +++++-
 drivers/interconnect/qcom/sdm660.c            | 14 ++++++
 3 files changed, 69 insertions(+), 6 deletions(-)

Comments

Rob Herring (Arm) Aug. 24, 2021, 4:54 p.m. UTC | #1 
On Tue, 24 Aug 2021 12:34:33 +0800, Shawn Guo wrote:
> It adds the missing a2noc clocks required for QoS registers programming
> per downstream kernel[1].
> 
> [1] https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/sdm660-bus.dtsi?h=LA.UM.8.2.r1-04800-sdm660.0#n43
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
>  .../bindings/interconnect/qcom,sdm660.yaml    | 46 +++++++++++++++++--
>  1 file changed, 42 insertions(+), 4 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
AngeloGioacchino Del Regno Sept. 1, 2021, 2:55 p.m. UTC | #2 
Il 24/08/21 06:34, Shawn Guo ha scritto:
> It adds the missing a2noc clocks required for QoS registers programming
> per downstream kernel[1].
> 
> [1] https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/sdm660-bus.dtsi?h=LA.UM.8.2.r1-04800-sdm660.0#n43
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>