| Message ID | 20210728142445.774158-1-dmitry.baryshkov@linaro.org |
|---|---|
| Headers | show |
| Series | PM: add two devres helpers and use them in qcom cc | expand |
On Wed 28 Jul 07:24 PDT 2021, Dmitry Baryshkov wrote: > Add helper function handling typical driver action: call > pm_runtime_enable at the probe() time and disable it during remove(). > This says what the patch does, but it doesn't say why we would like these helpers - i.e. the fact that it's quite common across the kernel to have error handlers and remove functions that simply has to do pm_runtime_disable(). > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/base/power/runtime.c | 17 +++++++++++++++++ > include/linux/pm_runtime.h | 4 ++++ > 2 files changed, 21 insertions(+) > > diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c > index 8a66eaf731e4..ec94049442b9 100644 > --- a/drivers/base/power/runtime.c > +++ b/drivers/base/power/runtime.c > @@ -1447,6 +1447,23 @@ void pm_runtime_enable(struct device *dev) > } > EXPORT_SYMBOL_GPL(pm_runtime_enable); > > +static void pm_runtime_disable_action(void *data) > +{ > + pm_runtime_disable(data); > +} > + > +/** > + * devm_pm_runtime_enable - devres-enabled version of pm_runtime_enable. () on the function name. > + * @dev: Device to handle. Returns: 0 on success, negative errno on failure Regards, Bjorn > + */ > +int devm_pm_runtime_enable(struct device *dev) > +{ > + pm_runtime_enable(dev); > + > + return devm_add_action_or_reset(dev, pm_runtime_disable_action, dev); > +} > +EXPORT_SYMBOL_GPL(devm_pm_runtime_enable); > + > /** > * pm_runtime_forbid - Block runtime PM of a device. > * @dev: Device to handle. > diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h > index aab8b35e9f8a..222da43b7096 100644 > --- a/include/linux/pm_runtime.h > +++ b/include/linux/pm_runtime.h > @@ -59,6 +59,8 @@ extern void pm_runtime_put_suppliers(struct device *dev); > extern void pm_runtime_new_link(struct device *dev); > extern void pm_runtime_drop_link(struct device_link *link); > > +extern int devm_pm_runtime_enable(struct device *dev); > + > /** > * pm_runtime_get_if_in_use - Conditionally bump up runtime PM usage counter. > * @dev: Target device. > @@ -253,6 +255,8 @@ static inline void __pm_runtime_disable(struct device *dev, bool c) {} > static inline void pm_runtime_allow(struct device *dev) {} > static inline void pm_runtime_forbid(struct device *dev) {} > > +static inline int devm_pm_runtime_enable(struct device *dev) { return 0; } > + > static inline void pm_suspend_ignore_children(struct device *dev, bool enable) {} > static inline void pm_runtime_get_noresume(struct device *dev) {} > static inline void pm_runtime_put_noidle(struct device *dev) {} > -- > 2.30.2 >
Qualcomm clock controller code (and most probably other drivers) would benefit from having devres helpers for pm_runtime_enable() and pm_clk_create(). Add those two helpers. Modify Qualcomm clock controller code to use new helpers and separate common pm code into common.c. ---------------------------------------------------------------- Dmitry Baryshkov (5): PM: runtime: add devm_pm_runtime_enable helper PM: clk: add devm_pm_clk_create helper clk: qcom: use devm_pm_runtime_enable and devm_pm_clk_create clk: qcom: use common code for qcom_cc_probe_by_index clk: qcom: move pm_clk functionality into common code drivers/base/power/clock_ops.c | 17 +++++++++++ drivers/base/power/runtime.c | 17 +++++++++++ drivers/clk/qcom/camcc-sc7180.c | 39 +++++++++---------------- drivers/clk/qcom/common.c | 55 ++++++++++++++++++++++++++++------- drivers/clk/qcom/common.h | 17 +++++++++++ drivers/clk/qcom/lpass-gfm-sm8250.c | 21 ++++++------- drivers/clk/qcom/lpasscorecc-sc7180.c | 55 +++++++++-------------------------- drivers/clk/qcom/mss-sc7180.c | 45 ++++++---------------------- drivers/clk/qcom/q6sstop-qcs404.c | 40 +++++++------------------ drivers/clk/qcom/turingcc-qcs404.c | 45 ++++++---------------------- include/linux/pm_clock.h | 5 ++++ include/linux/pm_runtime.h | 4 +++ 12 files changed, 169 insertions(+), 191 deletions(-)