mbox series

[v2,0/4] Add MSM8939 APCS/A53PLL clock support

Message ID 20210704024032.11559-1-shawn.guo@linaro.org
Headers show
Series Add MSM8939 APCS/A53PLL clock support | expand

Message

Shawn Guo July 4, 2021, 2:40 a.m. UTC
This series adds MSM8939 APCS/A53PLL clock support.  Most outstanding
thing about MSM8939 is that it integrates 3 APCS instances, for Cluster0
(little cores), Cluster1 (big cores) and CCI (Cache Coherent Interconnect)
respectively.

Changes for v2:
- Reword the commit log of first patch as suggested by Stephen.
- Drop 'clock-output-names' bindings and use @unit-address to get unique
  a53pll/mux clock names.
- Use 'operating-points-v2' bindings to pass frequency table via OPP, so
  that we can use one single compatible for all 3 MSM8939 a53pll.

Shawn Guo (4):
  clk: qcom: apcs-msm8916: Flag a53mux instead of a53pll as critical
  clk: qcom: a53pll/mux: Use unique clock name
  dt-bindings: clock: Update qcom,a53pll bindings for MSM8939 support
  clk: qcom: a53-pll: Add MSM8939 a53pll support

 .../bindings/clock/qcom,a53pll.yaml           |  3 +
 drivers/clk/qcom/a53-pll.c                    | 68 ++++++++++++++++++-
 drivers/clk/qcom/apcs-msm8916.c               | 10 ++-
 3 files changed, 76 insertions(+), 5 deletions(-)

-- 
2.17.1

Comments

Vincent Knecht July 7, 2021, 9:34 p.m. UTC | #1
Le dimanche 04 juillet 2021 à 10:40 +0800, Shawn Guo a écrit :
> This series adds MSM8939 APCS/A53PLL clock support.  Most outstanding

> thing about MSM8939 is that it integrates 3 APCS instances, for Cluster0

> (little cores), Cluster1 (big cores) and CCI (Cache Coherent Interconnect)

> respectively.

> 

> Changes for v2:

> - Reword the commit log of first patch as suggested by Stephen.

> - Drop 'clock-output-names' bindings and use @unit-address to get unique

>   a53pll/mux clock names.

> - Use 'operating-points-v2' bindings to pass frequency table via OPP, so

>   that we can use one single compatible for all 3 MSM8939 a53pll.

> 

> Shawn Guo (4):

>   clk: qcom: apcs-msm8916: Flag a53mux instead of a53pll as critical

>   clk: qcom: a53pll/mux: Use unique clock name

>   dt-bindings: clock: Update qcom,a53pll bindings for MSM8939 support

>   clk: qcom: a53-pll: Add MSM8939 a53pll support

> 

>  .../bindings/clock/qcom,a53pll.yaml           |  3 +

>  drivers/clk/qcom/a53-pll.c                    | 68 ++++++++++++++++++-

>  drivers/clk/qcom/apcs-msm8916.c               | 10 ++-

>  3 files changed, 76 insertions(+), 5 deletions(-)


Hello,

would you have a msm8939 dtsi/dts reference file working with all recent
contributions for this SoC ?
We the msm8939-focused PostmarketOS gang would be happy to boot our devices
and test patches but we're not able to boot anything more recent that 5.9...
Shawn Guo July 9, 2021, 2:13 a.m. UTC | #2
On Wed, Jul 07, 2021 at 11:34:19PM +0200, Vincent Knecht wrote:
> Le dimanche 04 juillet 2021 à 10:40 +0800, Shawn Guo a écrit :
> > This series adds MSM8939 APCS/A53PLL clock support.  Most outstanding
> > thing about MSM8939 is that it integrates 3 APCS instances, for Cluster0
> > (little cores), Cluster1 (big cores) and CCI (Cache Coherent Interconnect)
> > respectively.
> > 
> > Changes for v2:
> > - Reword the commit log of first patch as suggested by Stephen.
> > - Drop 'clock-output-names' bindings and use @unit-address to get unique
> >   a53pll/mux clock names.
> > - Use 'operating-points-v2' bindings to pass frequency table via OPP, so
> >   that we can use one single compatible for all 3 MSM8939 a53pll.
> > 
> > Shawn Guo (4):
> >   clk: qcom: apcs-msm8916: Flag a53mux instead of a53pll as critical
> >   clk: qcom: a53pll/mux: Use unique clock name
> >   dt-bindings: clock: Update qcom,a53pll bindings for MSM8939 support
> >   clk: qcom: a53-pll: Add MSM8939 a53pll support
> > 
> >  .../bindings/clock/qcom,a53pll.yaml           |  3 +
> >  drivers/clk/qcom/a53-pll.c                    | 68 ++++++++++++++++++-
> >  drivers/clk/qcom/apcs-msm8916.c               | 10 ++-
> >  3 files changed, 76 insertions(+), 5 deletions(-)
> 
> Hello,
> 
> would you have a msm8939 dtsi/dts reference file working with all recent
> contributions for this SoC ?

Yes, the dts will be posted once it's ready for public review.

Shawn

> We the msm8939-focused PostmarketOS gang would be happy to boot our devices
> and test patches but we're not able to boot anything more recent that 5.9...
Rob Herring July 12, 2021, 2:58 p.m. UTC | #3
On Sun, 04 Jul 2021 10:40:31 +0800, Shawn Guo wrote:
> Update qcom,a53pll bindings for MSM8939 support:

> 

>  - Add optional operating-points-v2 property

>  - Add MSM8939 specific compatible

> 

> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

> ---

>  Documentation/devicetree/bindings/clock/qcom,a53pll.yaml | 3 +++

>  1 file changed, 3 insertions(+)

> 


Acked-by: Rob Herring <robh@kernel.org>
Shawn Guo Aug. 4, 2021, 8:47 a.m. UTC | #4
On Sun, Jul 04, 2021 at 10:40:28AM +0800, Shawn Guo wrote:
> This series adds MSM8939 APCS/A53PLL clock support.  Most outstanding
> thing about MSM8939 is that it integrates 3 APCS instances, for Cluster0
> (little cores), Cluster1 (big cores) and CCI (Cache Coherent Interconnect)
> respectively.
> 
> Changes for v2:
> - Reword the commit log of first patch as suggested by Stephen.
> - Drop 'clock-output-names' bindings and use @unit-address to get unique
>   a53pll/mux clock names.
> - Use 'operating-points-v2' bindings to pass frequency table via OPP, so
>   that we can use one single compatible for all 3 MSM8939 a53pll.

Hi Stephen,

Any comments on this version?

Shawn
Stephen Boyd Aug. 6, 2021, 1:53 a.m. UTC | #5
Quoting Shawn Guo (2021-07-03 19:40:29)
> The clock source for MSM8916 cpu cores is like below.
> 
>                         |\
>          a53pll --------| \ a53mux     +------+

Applied to clk-next
Stephen Boyd Aug. 6, 2021, 1:53 a.m. UTC | #6
Quoting Shawn Guo (2021-07-03 19:40:31)
> Update qcom,a53pll bindings for MSM8939 support:
> 
>  - Add optional operating-points-v2 property
>  - Add MSM8939 specific compatible
> 
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---

Applied to clk-next