mbox series

[v2,0/2] clk: qcom: fix error path and cleanup in gdsc support

Message ID 20210630225952.3337630-1-dmitry.baryshkov@linaro.org
Headers show
Series clk: qcom: fix error path and cleanup in gdsc support | expand

Message

Dmitry Baryshkov June 30, 2021, 10:59 p.m. UTC
Fix error path in gdsc_register() and cleanup code in gdsc_unregister()
to properly unwind all genpd registration calls. Both patches bear two
fixes tags, since part of the issue was present in the very first commit
adding support for GDSCs, part of the issue was added when adding
hiearchical power domains support to GDSC code.

----------------------------------------------------------------
Dmitry Baryshkov (2):
      clk: qcom: fix error_path in gdsc_register
      clk: qcom: fix domains cleanup in gdsc_unregister

 drivers/clk/qcom/gdsc.c | 48 ++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 42 insertions(+), 6 deletions(-)

Comments

Stephen Boyd July 1, 2021, 12:41 a.m. UTC | #1
Quoting Dmitry Baryshkov (2021-06-30 15:59:50)
> Fix error path in gdsc_register() and cleanup code in gdsc_unregister()

> to properly unwind all genpd registration calls. Both patches bear two

> fixes tags, since part of the issue was present in the very first commit

> adding support for GDSCs, part of the issue was added when adding

> hiearchical power domains support to GDSC code.


Should also include the author of the patch that is being Fixed as an
FYI.

> 

> ----------------------------------------------------------------

> Dmitry Baryshkov (2):

>       clk: qcom: fix error_path in gdsc_register

>       clk: qcom: fix domains cleanup in gdsc_unregister

> 

>  drivers/clk/qcom/gdsc.c | 48 ++++++++++++++++++++++++++++++++++++++++++------

>  1 file changed, 42 insertions(+), 6 deletions(-)

> 

>
Stephen Boyd Aug. 26, 2021, 6:36 p.m. UTC | #2
Quoting Stephen Boyd (2021-06-30 17:41:36)
> Quoting Dmitry Baryshkov (2021-06-30 15:59:50)

> > Fix error path in gdsc_register() and cleanup code in gdsc_unregister()

> > to properly unwind all genpd registration calls. Both patches bear two

> > fixes tags, since part of the issue was present in the very first commit

> > adding support for GDSCs, part of the issue was added when adding

> > hiearchical power domains support to GDSC code.

> 

> Should also include the author of the patch that is being Fixed as an

> FYI.

> 


I'm inclined to drop this series from my clk review queue unless it is
still relevant. Is this still a problem after Bjorn's fix to this file?