| Message ID | 20210625123355.11578-1-manivannan.sadhasivam@linaro.org |
|---|---|
| Headers | show |
| Series | MHI patches for v5.14 - Take 2 | expand |
On Fri, Jun 25, 2021 at 06:03:51PM +0530, Manivannan Sadhasivam wrote: > From: Bhaumik Bhatt <bbhatt@codeaurora.org> > > Set the BHI and BHIe pointers to NULL as part of clean-up. This > makes sure that stale pointers are not accessed after powering > MHI down. > > Cc: stable@vger.kernel.org Why is this needed for stable, but patch 5/10 is not? And what commit does this fix? How far back should it go? And is this really fixing anything? thanks, greg k-h
Hi Greg, On Fri, Jun 25, 2021 at 06:03:45PM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > Please find the remaining MHI patches for v5.14. This series has the left over > patches from the previous patchset and one new series that was reviewed a > while ago and put on hold for Ack from Kalle Valo for ath11k. > > Summary: > > 1. Added validation for the channel ID read from event ring. If we get events > from an invalid channel, we throw an error message and skip the event. > > 2. Fixed the MHI wake routines used for the newer modems such as SDX55 and > SDX65 by using no-op routines only for the older modems and then relying on > the default routines provided by MHI stack for newer ones. > > 3. Added support for processing the events based on the priorities. Earlier > a fixed priority was used for all events. > > 4. Added a dedicated flag to the MHI client transfer APIs for inbound > buffer allocation by the MHI stack. Since this patch modifies the MHI > client drivers under "net/", Ack has been collected from the netdev > maintainer. > > 5. Added support for Cinterion MV31-W modem in pci_generic controller: > https://www.thalesgroup.com/en/markets/digital-identity-and-security/iot/iot-connectivity/products/iot-products/mv31-w-ultra-high > > 6. Rearranged the setting of BHI/BHIe offsets for better validation of the > register values read from MMIO > > 7. Cleanup of the BHI/BHIe pointers by setting them to NULL to prevent access > after power down. > > 8. Added support for getting the MMIO register length from the controller > drivers. This helps in validation of the read offsets from MMIO registers. > Since this patch touches ath11k, Ack has been collected from Kalle Valo. > > 9. With the help of above register length, added check for BHI/BHIe offsets. > Is this series on your queue for 5.14? Thanks, Mani > Thanks, > Mani > > Bhaumik Bhatt (8): > bus: mhi: pci_generic: Apply no-op for wake using sideband wake > boolean > bus: mhi: core: Validate channel ID when processing command > completions > bus: mhi: core: Set BHI/BHIe offsets on power up preparation > bus: mhi: core: Set BHI and BHIe pointers to NULL in clean-up > bus: mhi: Add MMIO region length to controller structure > ath11k: set register access length for MHI driver > bus: mhi: pci_generic: Set register access length for MHI driver > bus: mhi: core: Add range checks for BHI and BHIe > > Loic Poulain (1): > bus: mhi: Add inbound buffers allocation flag > > ULRICH Thomas (1): > bus: mhi: pci_generic: Add Cinterion MV31-W PCIe to MHI > > drivers/bus/mhi/core/init.c | 61 +++++++++++++++++-------- > drivers/bus/mhi/core/internal.h | 2 +- > drivers/bus/mhi/core/main.c | 26 +++++++---- > drivers/bus/mhi/core/pm.c | 28 ++---------- > drivers/bus/mhi/pci_generic.c | 65 +++++++++++++++++++++++---- > drivers/net/mhi/net.c | 2 +- > drivers/net/wireless/ath/ath11k/mhi.c | 1 + > drivers/net/wwan/mhi_wwan_ctrl.c | 2 +- > include/linux/mhi.h | 9 +++- > net/qrtr/mhi.c | 2 +- > 10 files changed, 134 insertions(+), 64 deletions(-) > > -- > 2.25.1 >
On Wed, Jun 30, 2021 at 06:46:56PM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > On Fri, Jun 25, 2021 at 06:03:45PM +0530, Manivannan Sadhasivam wrote: > > Hi Greg, > > > > Please find the remaining MHI patches for v5.14. This series has the left over > > patches from the previous patchset and one new series that was reviewed a > > while ago and put on hold for Ack from Kalle Valo for ath11k. > > > > Summary: > > > > 1. Added validation for the channel ID read from event ring. If we get events > > from an invalid channel, we throw an error message and skip the event. > > > > 2. Fixed the MHI wake routines used for the newer modems such as SDX55 and > > SDX65 by using no-op routines only for the older modems and then relying on > > the default routines provided by MHI stack for newer ones. > > > > 3. Added support for processing the events based on the priorities. Earlier > > a fixed priority was used for all events. > > > > 4. Added a dedicated flag to the MHI client transfer APIs for inbound > > buffer allocation by the MHI stack. Since this patch modifies the MHI > > client drivers under "net/", Ack has been collected from the netdev > > maintainer. > > > > 5. Added support for Cinterion MV31-W modem in pci_generic controller: > > https://www.thalesgroup.com/en/markets/digital-identity-and-security/iot/iot-connectivity/products/iot-products/mv31-w-ultra-high > > > > 6. Rearranged the setting of BHI/BHIe offsets for better validation of the > > register values read from MMIO > > > > 7. Cleanup of the BHI/BHIe pointers by setting them to NULL to prevent access > > after power down. > > > > 8. Added support for getting the MMIO register length from the controller > > drivers. This helps in validation of the read offsets from MMIO registers. > > Since this patch touches ath11k, Ack has been collected from Kalle Valo. > > > > 9. With the help of above register length, added check for BHI/BHIe offsets. > > > > Is this series on your queue for 5.14? It's too late for 5.14-rc1, patches had to be in linux-next way before 5.13-final was out. I can take these after 5.14-rc1 is out for 5.15-rc1, or you can split them up into bugfixes and features and resend two series, one for 5.14-final and one for 5.15-rc1, which ever you want. thanks, greg k-h
Hi Greg, Please find the remaining MHI patches for v5.14. This series has the left over patches from the previous patchset and one new series that was reviewed a while ago and put on hold for Ack from Kalle Valo for ath11k. Summary: 1. Added validation for the channel ID read from event ring. If we get events from an invalid channel, we throw an error message and skip the event. 2. Fixed the MHI wake routines used for the newer modems such as SDX55 and SDX65 by using no-op routines only for the older modems and then relying on the default routines provided by MHI stack for newer ones. 3. Added support for processing the events based on the priorities. Earlier a fixed priority was used for all events. 4. Added a dedicated flag to the MHI client transfer APIs for inbound buffer allocation by the MHI stack. Since this patch modifies the MHI client drivers under "net/", Ack has been collected from the netdev maintainer. 5. Added support for Cinterion MV31-W modem in pci_generic controller: https://www.thalesgroup.com/en/markets/digital-identity-and-security/iot/iot-connectivity/products/iot-products/mv31-w-ultra-high 6. Rearranged the setting of BHI/BHIe offsets for better validation of the register values read from MMIO 7. Cleanup of the BHI/BHIe pointers by setting them to NULL to prevent access after power down. 8. Added support for getting the MMIO register length from the controller drivers. This helps in validation of the read offsets from MMIO registers. Since this patch touches ath11k, Ack has been collected from Kalle Valo. 9. With the help of above register length, added check for BHI/BHIe offsets. Thanks, Mani Bhaumik Bhatt (8): bus: mhi: pci_generic: Apply no-op for wake using sideband wake boolean bus: mhi: core: Validate channel ID when processing command completions bus: mhi: core: Set BHI/BHIe offsets on power up preparation bus: mhi: core: Set BHI and BHIe pointers to NULL in clean-up bus: mhi: Add MMIO region length to controller structure ath11k: set register access length for MHI driver bus: mhi: pci_generic: Set register access length for MHI driver bus: mhi: core: Add range checks for BHI and BHIe Loic Poulain (1): bus: mhi: Add inbound buffers allocation flag ULRICH Thomas (1): bus: mhi: pci_generic: Add Cinterion MV31-W PCIe to MHI drivers/bus/mhi/core/init.c | 61 +++++++++++++++++-------- drivers/bus/mhi/core/internal.h | 2 +- drivers/bus/mhi/core/main.c | 26 +++++++---- drivers/bus/mhi/core/pm.c | 28 ++---------- drivers/bus/mhi/pci_generic.c | 65 +++++++++++++++++++++++---- drivers/net/mhi/net.c | 2 +- drivers/net/wireless/ath/ath11k/mhi.c | 1 + drivers/net/wwan/mhi_wwan_ctrl.c | 2 +- include/linux/mhi.h | 9 +++- net/qrtr/mhi.c | 2 +- 10 files changed, 134 insertions(+), 64 deletions(-) -- 2.25.1