| Message ID | 20210515131217.1540412-1-dmitry.baryshkov@linaro.org |
|---|---|
| Headers | show |
| Series | dsi: rework clock parents and timing handling | expand |
On 15/05/2021 16:12, Dmitry Baryshkov wrote: > This patch series brings back several patches targeting assigning dispcc > clock parents, that were removed from the massive dsi rework patchset > earlier. Gracious ping for this series. I'd ask to skip patch 8 for now (as we might bring that back for moving PHY to drivers/phy), but patches 1-7 are still valid and pending review/acceptance. > > Few notes: > - assign-clock-parents is a mandatory proprety according to the current > dsi.txt description. > - There is little point in duplicating this functionality with the ad-hoc > implementation in the dsi code. > > On top of that come few minor cleanups for the DSI PHY drivers. > > I'd kindly ask to bring all dts changes also through the drm tree, so > that there won't be any breakage of the functionality. > > > The following changes since commit f2f46b878777e0d3f885c7ddad48f477b4dea247: > > drm/msm/dp: initialize audio_comp when audio starts (2021-05-06 16:26:57 -0700) > > are available in the Git repository at: > > https://git.linaro.org/people/dmitry.baryshkov/kernel.git dsi-phy-update > > for you to fetch changes up to f1fd3b113cbb98febad682fc11ea1c6e717434c2: > > drm/msm/dsi: remove msm_dsi_dphy_timing from msm_dsi_phy (2021-05-14 22:55:11 +0300) > > ---------------------------------------------------------------- > Dmitry Baryshkov (8): > arm64: dts: qcom: sc7180: assign DSI clock source parents > arm64: dts: qcom: sdm845: assign DSI clock source parents > arm64: dts: qcom: sdm845-mtp: assign DSI clock source parents > arm64: dts: qcom: sm8250: assign DSI clock source parents > drm/msm/dsi: stop setting clock parents manually > drm/msm/dsi: phy: use of_device_get_match_data > drm/msm/dsi: drop msm_dsi_phy_get_shared_timings > drm/msm/dsi: remove msm_dsi_dphy_timing from msm_dsi_phy > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++ > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 3 ++ > arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 +++ > arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +++ > drivers/gpu/drm/msm/dsi/dsi.h | 7 +--- > drivers/gpu/drm/msm/dsi/dsi_host.c | 51 ------------------------- > drivers/gpu/drm/msm/dsi/dsi_manager.c | 8 +--- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 46 ++++++++++------------ > drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 10 ++++- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 11 ++---- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 11 ++---- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_20nm.c | 10 +---- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 12 ++---- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 10 +---- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 13 ++----- > 15 files changed, 67 insertions(+), 140 deletions(-) > >
Hi Dmitry I will take a look at this next week for sure. Thanks Abhinav On 2021-06-10 06:48, Dmitry Baryshkov wrote: > On 15/05/2021 16:12, Dmitry Baryshkov wrote: >> This patch series brings back several patches targeting assigning >> dispcc >> clock parents, that were removed from the massive dsi rework patchset >> earlier. > > Gracious ping for this series. I'd ask to skip patch 8 for now (as we > might bring that back for moving PHY to drivers/phy), but patches 1-7 > are still valid and pending review/acceptance. > >> >> Few notes: >> - assign-clock-parents is a mandatory proprety according to the >> current >> dsi.txt description. >> - There is little point in duplicating this functionality with the >> ad-hoc >> implementation in the dsi code. >> >> On top of that come few minor cleanups for the DSI PHY drivers. >> >> I'd kindly ask to bring all dts changes also through the drm tree, so >> that there won't be any breakage of the functionality. >> >> >> The following changes since commit >> f2f46b878777e0d3f885c7ddad48f477b4dea247: >> >> drm/msm/dp: initialize audio_comp when audio starts (2021-05-06 >> 16:26:57 -0700) >> >> are available in the Git repository at: >> >> https://git.linaro.org/people/dmitry.baryshkov/kernel.git >> dsi-phy-update >> >> for you to fetch changes up to >> f1fd3b113cbb98febad682fc11ea1c6e717434c2: >> >> drm/msm/dsi: remove msm_dsi_dphy_timing from msm_dsi_phy >> (2021-05-14 22:55:11 +0300) >> >> ---------------------------------------------------------------- >> Dmitry Baryshkov (8): >> arm64: dts: qcom: sc7180: assign DSI clock source parents >> arm64: dts: qcom: sdm845: assign DSI clock source parents >> arm64: dts: qcom: sdm845-mtp: assign DSI clock source parents >> arm64: dts: qcom: sm8250: assign DSI clock source parents >> drm/msm/dsi: stop setting clock parents manually >> drm/msm/dsi: phy: use of_device_get_match_data >> drm/msm/dsi: drop msm_dsi_phy_get_shared_timings >> drm/msm/dsi: remove msm_dsi_dphy_timing from msm_dsi_phy >> >> arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++ >> arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 3 ++ >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 +++ >> arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +++ >> drivers/gpu/drm/msm/dsi/dsi.h | 7 +--- >> drivers/gpu/drm/msm/dsi/dsi_host.c | 51 >> ------------------------- >> drivers/gpu/drm/msm/dsi/dsi_manager.c | 8 +--- >> drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 46 >> ++++++++++------------ >> drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 10 ++++- >> drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 11 ++---- >> drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 11 ++---- >> drivers/gpu/drm/msm/dsi/phy/dsi_phy_20nm.c | 10 +---- >> drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 12 ++---- >> drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 10 +---- >> drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 13 ++----- >> 15 files changed, 67 insertions(+), 140 deletions(-) >> >>
On 2021-05-15 06:12, Dmitry Baryshkov wrote: > This patch series brings back several patches targeting assigning > dispcc > clock parents, that were removed from the massive dsi rework patchset > earlier. > > Few notes: > - assign-clock-parents is a mandatory proprety according to the > current > dsi.txt description. Is this comment still right? dsi.txt has now moved to YAML format, but even before that I am not able to see that this was a mandatory property. With these changes yes, it becomes a mandatory property and hence needs to be documented that way. > - There is little point in duplicating this functionality with the > ad-hoc > implementation in the dsi code. > > On top of that come few minor cleanups for the DSI PHY drivers. > > I'd kindly ask to bring all dts changes also through the drm tree, so > that there won't be any breakage of the functionality. > > > The following changes since commit > f2f46b878777e0d3f885c7ddad48f477b4dea247: > > drm/msm/dp: initialize audio_comp when audio starts (2021-05-06 > 16:26:57 -0700) > > are available in the Git repository at: > > https://git.linaro.org/people/dmitry.baryshkov/kernel.git > dsi-phy-update > > for you to fetch changes up to > f1fd3b113cbb98febad682fc11ea1c6e717434c2: > > drm/msm/dsi: remove msm_dsi_dphy_timing from msm_dsi_phy (2021-05-14 > 22:55:11 +0300) > > ---------------------------------------------------------------- > Dmitry Baryshkov (8): > arm64: dts: qcom: sc7180: assign DSI clock source parents > arm64: dts: qcom: sdm845: assign DSI clock source parents > arm64: dts: qcom: sdm845-mtp: assign DSI clock source parents > arm64: dts: qcom: sm8250: assign DSI clock source parents > drm/msm/dsi: stop setting clock parents manually > drm/msm/dsi: phy: use of_device_get_match_data > drm/msm/dsi: drop msm_dsi_phy_get_shared_timings > drm/msm/dsi: remove msm_dsi_dphy_timing from msm_dsi_phy > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++ > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 3 ++ > arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 +++ > arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +++ > drivers/gpu/drm/msm/dsi/dsi.h | 7 +--- > drivers/gpu/drm/msm/dsi/dsi_host.c | 51 > ------------------------- > drivers/gpu/drm/msm/dsi/dsi_manager.c | 8 +--- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 46 > ++++++++++------------ > drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 10 ++++- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 11 ++---- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 11 ++---- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_20nm.c | 10 +---- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 12 ++---- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 10 +---- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 13 ++----- > 15 files changed, 67 insertions(+), 140 deletions(-) > > > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno
This patch series brings back several patches targeting assigning dispcc clock parents, that were removed from the massive dsi rework patchset earlier. Few notes: - assign-clock-parents is a mandatory proprety according to the current dsi.txt description. - There is little point in duplicating this functionality with the ad-hoc implementation in the dsi code. On top of that come few minor cleanups for the DSI PHY drivers. I'd kindly ask to bring all dts changes also through the drm tree, so that there won't be any breakage of the functionality. The following changes since commit f2f46b878777e0d3f885c7ddad48f477b4dea247: drm/msm/dp: initialize audio_comp when audio starts (2021-05-06 16:26:57 -0700) are available in the Git repository at: https://git.linaro.org/people/dmitry.baryshkov/kernel.git dsi-phy-update for you to fetch changes up to f1fd3b113cbb98febad682fc11ea1c6e717434c2: drm/msm/dsi: remove msm_dsi_dphy_timing from msm_dsi_phy (2021-05-14 22:55:11 +0300) ---------------------------------------------------------------- Dmitry Baryshkov (8): arm64: dts: qcom: sc7180: assign DSI clock source parents arm64: dts: qcom: sdm845: assign DSI clock source parents arm64: dts: qcom: sdm845-mtp: assign DSI clock source parents arm64: dts: qcom: sm8250: assign DSI clock source parents drm/msm/dsi: stop setting clock parents manually drm/msm/dsi: phy: use of_device_get_match_data drm/msm/dsi: drop msm_dsi_phy_get_shared_timings drm/msm/dsi: remove msm_dsi_dphy_timing from msm_dsi_phy arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 ++ arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 3 ++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 +++ arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +++ drivers/gpu/drm/msm/dsi/dsi.h | 7 +--- drivers/gpu/drm/msm/dsi/dsi_host.c | 51 ------------------------- drivers/gpu/drm/msm/dsi/dsi_manager.c | 8 +--- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 46 ++++++++++------------ drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 10 ++++- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 11 ++---- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 11 ++---- drivers/gpu/drm/msm/dsi/phy/dsi_phy_20nm.c | 10 +---- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 12 ++---- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 10 +---- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 13 ++----- 15 files changed, 67 insertions(+), 140 deletions(-)