| Message ID | 20210314061054.19451-1-srivasam@codeaurora.org |
|---|---|
| Headers | show |
| Series | Qualcomm's lpass device tree changes for I2s dai | expand |
Hi, On Sat, Mar 13, 2021 at 10:11 PM Srinivasa Rao Mandadapu <srivasam@codeaurora.org> wrote: > > From: Ajit Pandey <ajitp@codeaurora.org> > > Add dai link for supporting lpass I2S driver, which is used > for audio capture and playback. > Add lpass-cpu node with pin controls and i2s primary > and secondary dai-links You missed Stephen's comments on your commit message [1] [1] https://lore.kernel.org/r/161566899554.1478170.1265435102634351195@swboyd.mtv.corp.google.com/ > Signed-off-by: Ajit Pandey <ajitp@codeaurora.org> > Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org> > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 58 ++++++++++++++++++++ > 1 file changed, 58 insertions(+) The commit message nits aren't terribly important and Bjorn can presumably just fix them when applying if he cares. IMO you don't need to re-spin. Reviewed-by: Douglas Anderson <dianders@chromium.org> With these two patches plus commit 9922f50f7178 ("ASoC: qcom: lpass-cpu: Fix lpass dai ids parse") in the sound tree I get audio on sc7180-trogdor-lazor! Thus: Tested-by: Douglas Anderson <dianders@chromium.org>
Hello: This series was applied to qcom/linux.git (refs/heads/for-next): On Sun, 14 Mar 2021 11:40:52 +0530 you wrote: > These patches are device tree changes to support audio over I2S. > Changes Since v6: > -- Changed mi2s node names > Changes Since v5: > -- Removed lpass macro in codec dai cell > -- Renamed multimedia dai codec alias name > Changes Since v4: > -- Removed duplication of dai-link in sound node. > -- Replaced reg values with common dt-bindings macros in coachz dtsi > -- Included sc7180-lpass.h instead of qcom,lpass.h > -- Sound node placement change in coachz dtsi. > Changes Since v3: > -- Compatible name changed as per trogdor > Changes Since v2: > -- Sound node variable is added in sc7180-trogdor-coachz.dtsi. > -- Audio-jack property is removed, as it may create conflicts with the boards > having different codecs. > -- Replaced reg values with common dt-bindings macros > Changes Since v1: > -- Ajith's Certification is added. > -- Alias name added for sound dai link node > > [...] Here is the summary with links: - [v7,1/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver https://git.kernel.org/qcom/c/29bd62ee951b - [v7,2/2] arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz https://git.kernel.org/qcom/c/f158e7a378f2 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
These patches are device tree changes to support audio over I2S. Changes Since v6: -- Changed mi2s node names Changes Since v5: -- Removed lpass macro in codec dai cell -- Renamed multimedia dai codec alias name Changes Since v4: -- Removed duplication of dai-link in sound node. -- Replaced reg values with common dt-bindings macros in coachz dtsi -- Included sc7180-lpass.h instead of qcom,lpass.h -- Sound node placement change in coachz dtsi. Changes Since v3: -- Compatible name changed as per trogdor Changes Since v2: -- Sound node variable is added in sc7180-trogdor-coachz.dtsi. -- Audio-jack property is removed, as it may create conflicts with the boards having different codecs. -- Replaced reg values with common dt-bindings macros Changes Since v1: -- Ajith's Certification is added. -- Alias name added for sound dai link node Ajit Pandey (1): arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for I2S driver Srinivasa Rao Mandadapu (1): arm64: dts: qcom: Add sound node for sc7180-trogdor-coachz .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 10 ++++ arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 58 +++++++++++++++++++ 2 files changed, 68 insertions(+)