| Message ID | 20201204193540.3047030-1-swboyd@chromium.org |
|---|---|
| Headers | show |
| Series | spi: spi-geni-qcom: Use gpio descriptors for CS | expand |
On Fri, 4 Dec 2020 at 12:35, Stephen Boyd <swboyd@chromium.org> wrote: > > There isn't any need to overwrite the mode here in the driver with what > has been detected by the firmware, such as DT or ACPI. In fact, if we > use the SPI CS gpio descriptor feature we will overwrite the mode with > SPI_MODE_0 where it already contains SPI_MODE_0 and more importantly > SPI_CS_HIGH. Clearing the SPI_CS_HIGH bit causes the CS line to toggle > when the device is probed when it shouldn't change, confusing the driver > and making it fail to probe. Drop the assignment and let the spi core > take care of it. > > Fixes: a17d94f0b6e1 ("mfd: Add ChromeOS EC SPI driver") > Cc: Simon Glass <sjg@chromium.org> > Cc: Gwendal Grignou <gwendal@chromium.org> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > Tested-by: Douglas Anderson <dianders@chromium.org> > Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Cc: Alexandru M Stan <amstan@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > drivers/platform/chrome/cros_ec_spi.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> > > > diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c > index dfa1f816a45f..f9df218fc2bb 100644 > --- a/drivers/platform/chrome/cros_ec_spi.c > +++ b/drivers/platform/chrome/cros_ec_spi.c > @@ -742,7 +742,6 @@ static int cros_ec_spi_probe(struct spi_device *spi) > int err; > > spi->bits_per_word = 8; > - spi->mode = SPI_MODE_0; > spi->rt = true; > err = spi_setup(spi); > if (err < 0) > -- > https://chromeos.dev >
On Fri, 4 Dec 2020 11:35:37 -0800, Stephen Boyd wrote: > Collected patches from the two series below and associated tags so they > can be merged in one pile through the spi tree. Merry December! > > SPI: https://lore.kernel.org/r/20201202214935.1114381-1-swboyd@chromium.org > cros-ec: https://lore.kernel.org/r/20201203011649.1405292-1-swboyd@chromium.org > > Cc: Akash Asthana <akashast@codeaurora.org> > Cc: Simon Glass <sjg@chromium.org> > Cc: Gwendal Grignou <gwendal@chromium.org> > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Alexandru M Stan <amstan@chromium.org> > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/3] platform/chrome: cros_ec_spi: Don't overwrite spi::mode commit: 74639cbf51d7c0304342544a83dfda354a6bd208 [2/3] platform/chrome: cros_ec_spi: Drop bits_per_word assignment commit: 7a5172b7990d97ab9ef64e6d9063aa68099ea023 [3/3] spi: spi-geni-qcom: Use the new method of gpio CS control commit: 3b25f337929e73232f0aa990cd68a129f53652e2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Hello: This series was applied to qcom/linux.git (refs/heads/for-next): On Fri, 4 Dec 2020 11:35:37 -0800 you wrote: > Collected patches from the two series below and associated tags so they > can be merged in one pile through the spi tree. Merry December! > > SPI: https://lore.kernel.org/r/20201202214935.1114381-1-swboyd@chromium.org > cros-ec: https://lore.kernel.org/r/20201203011649.1405292-1-swboyd@chromium.org > > Cc: Akash Asthana <akashast@codeaurora.org> > Cc: Simon Glass <sjg@chromium.org> > Cc: Gwendal Grignou <gwendal@chromium.org> > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Alexandru M Stan <amstan@chromium.org> > > [...] Here is the summary with links: - [1/3] platform/chrome: cros_ec_spi: Don't overwrite spi::mode https://git.kernel.org/qcom/c/74639cbf51d7 - [2/3] platform/chrome: cros_ec_spi: Drop bits_per_word assignment https://git.kernel.org/qcom/c/7a5172b7990d - [3/3] spi: spi-geni-qcom: Use the new method of gpio CS control https://git.kernel.org/qcom/c/3b25f337929e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html