| Message ID | 20200905173905.16541-1-jonathan@marek.ca |
|---|---|
| Headers | show |
| Series | soundwire: qcom: add support for mmio soundwire master | expand |
On 05/09/2020 18:39, Jonathan Marek wrote: > This adds initial support for soundwire device on sm8250. > > Tested with the "wsa" sdw device, which is simpler than the others. > > v2 addresses some feedback, but I kept this series as simple as possible. > In particular, I didn't implement CMD_NACKED from FIFO_STATUS, because > the downstream driver doesn't define this bit, so I can't implement it. > Soundwire works without it and It shouldn't be difficult to implement later. > > Jonathan Marek (4): > soundwire: qcom: fix abh/ahb typo > soundwire: qcom: avoid dependency on CONFIG_SLIMBUS > soundwire: qcom: add support for mmio soundwire master devices > soundwire: qcom: add v1.5.1 compatible > Hi Jonathan, I have tested these patches on RB5 with WSA8810 and they work fine. I can try to add support to command ignored in future, but for now these look good to me! Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Thanks, srini > .../bindings/soundwire/qcom,sdw.txt | 1 + > drivers/soundwire/Kconfig | 2 +- > drivers/soundwire/qcom.c | 38 +++++++++++++++++-- > 3 files changed, 36 insertions(+), 5 deletions(-) >
On 05-09-20, 13:39, Jonathan Marek wrote: > This adds initial support for soundwire device on sm8250. > > Tested with the "wsa" sdw device, which is simpler than the others. > > v2 addresses some feedback, but I kept this series as simple as possible. > In particular, I didn't implement CMD_NACKED from FIFO_STATUS, because > the downstream driver doesn't define this bit, so I can't implement it. > Soundwire works without it and It shouldn't be difficult to implement later. Applied all, thanks
On 9/5/20 12:39 PM, Jonathan Marek wrote: > The driver may be used without slimbus, so don't depend on slimbus. > > Signed-off-by: Jonathan Marek <jonathan@marek.ca> > --- > drivers/soundwire/Kconfig | 2 +- > drivers/soundwire/qcom.c | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig > index fa2b4ab92ed9..f83d02c9c60a 100644 > --- a/drivers/soundwire/Kconfig > +++ b/drivers/soundwire/Kconfig > @@ -33,7 +33,7 @@ config SOUNDWIRE_INTEL > > config SOUNDWIRE_QCOM > tristate "Qualcomm SoundWire Master driver" > - depends on SLIMBUS > + imply SLIMBUS > depends on SND_SOC > help > SoundWire Qualcomm Master driver. > diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c > index d1e33ef1afac..6401ad451eee 100644 > --- a/drivers/soundwire/qcom.c > +++ b/drivers/soundwire/qcom.c > @@ -753,7 +753,11 @@ static int qcom_swrm_probe(struct platform_device *pdev) > if (!ctrl) > return -ENOMEM; > > +#if IS_ENABLED(CONFIG_SLIBMUS) typo: SLIMBUS. > if (dev->parent->bus == &slimbus_bus) { > +#else > + if (false) { > +#endif > ctrl->reg_read = qcom_swrm_ahb_reg_read; > ctrl->reg_write = qcom_swrm_ahb_reg_write; > ctrl->regmap = dev_get_regmap(dev->parent, NULL); >