mbox series

[RESEND,0/3] Add Qualcomm MSM8939 GCC binding and driver

Message ID 20200419121808.440780-1-bryan.odonoghue@linaro.org
Headers show
Series Add Qualcomm MSM8939 GCC binding and driver | expand

Message

Bryan O'Donoghue April 19, 2020, 12:18 p.m. UTC 
These three patches add support for the MSM8939 Global Clock Controller.
The MSM8939 is a derivation of the MSM8916 sharing the large majority of
its clock settings with MSM8916, however, there are enough changes, in some
cases mutually incompatible changes that necessitate a separate driver.

I thought it was both important and useful to show in the git log the
differences between MSM8916 and MSM8939 so, one patch copies the MSM8916
driver while another patch applies the entire gamut of MSM8939 changes,
squashing down from a git log of approximately 31 separate commits.

For reference that log is here:
https://github.com/bryanodonoghue/linux/pull/new/msm8939-clk-next-reference-log

Generally speaking MSM8939 differes from MSM8916 in two key ways.

- New and higher clock frequencies for existing IP blocks.
- New PLLs to drive those higher frequencies

Bryan O'Donoghue (2):
  clk: qcom: Add DT bindings for msm8939 gcc
  clk: qcom: gcc-msm8939: Make silicon specific updates for msm8939

Shawn Guo (1):
  clk: qcom: gcc-msm8939: Add gcc-msm8939 driver by copying gcc-msm8916

 .../devicetree/bindings/clock/qcom,gcc.yaml   |    3 +
 drivers/clk/qcom/Kconfig                      |    9 +
 drivers/clk/qcom/Makefile                     |    1 +
 drivers/clk/qcom/gcc-msm8939.c                | 4004 +++++++++++++++++
 include/dt-bindings/clock/qcom,gcc-msm8939.h  |  215 +
 include/dt-bindings/reset/qcom,gcc-msm8939.h  |  119 +
 6 files changed, 4351 insertions(+)
 create mode 100644 drivers/clk/qcom/gcc-msm8939.c
 create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8939.h
 create mode 100644 include/dt-bindings/reset/qcom,gcc-msm8939.h

Comments

Stephen Boyd April 22, 2020, 2:50 a.m. UTC | #1 
Quoting Bryan O'Donoghue (2020-04-19 05:18:06)
> diff --git a/include/dt-bindings/clock/qcom,gcc-msm8939.h b/include/dt-bindings/clock/qcom,gcc-msm8939.h
> new file mode 100644
> index 000000000000..f9ac936590f3
> --- /dev/null
> +++ b/include/dt-bindings/clock/qcom,gcc-msm8939.h
> @@ -0,0 +1,215 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * Copyright 2020 Linaro Limited
> + *
> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.

Please remove the boiler plate that SPDX already covers.

> diff --git a/include/dt-bindings/reset/qcom,gcc-msm8939.h b/include/dt-bindings/reset/qcom,gcc-msm8939.h
> new file mode 100644
> index 000000000000..a8c8135ce24d
> --- /dev/null
> +++ b/include/dt-bindings/reset/qcom,gcc-msm8939.h
> @@ -0,0 +1,119 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * Copyright 2020 Linaro Limited
> + *
> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.

Same.