| Message ID | 20190221102315.12946-1-vkoul@kernel.org |
|---|---|
| Headers | show |
| Series | net: phy: at803x: Update delays for RGMII modes | expand |
From: Vinod Koul <vkoul@kernel.org> Date: Thu, 21 Feb 2019 15:53:13 +0530 > Peter[1] reported that patch cd28d1d6e52e: ("net: phy: at803x: Disable > phy delay for RGMII mode") caused regression on am335x-evmsk board. > This board expects the Phy delay to be enabled but specified RGMII mode > which refers to delays being disabled. So fix this by disabling delay only > for RGMII mode and enable for RGMII_ID and RGMII_TXID/RXID modes. > > While at it, as pointed by Dave, don't inline the helpers. > > [1]: https://www.spinics.net/lists/netdev/msg550749.html > > Changes in v4: > - fix log & comments nbased on Marc's feedback Series applied, thanks.
Peter[1] reported that patch cd28d1d6e52e: ("net: phy: at803x: Disable phy delay for RGMII mode") caused regression on am335x-evmsk board. This board expects the Phy delay to be enabled but specified RGMII mode which refers to delays being disabled. So fix this by disabling delay only for RGMII mode and enable for RGMII_ID and RGMII_TXID/RXID modes. While at it, as pointed by Dave, don't inline the helpers. [1]: https://www.spinics.net/lists/netdev/msg550749.html Changes in v4: - fix log & comments nbased on Marc's feedback Vinod Koul (2): net: phy: at803x: don't inline helpers net: phy: at803x: disable delay only for RGMII mode drivers/net/phy/at803x.c | 57 +++++++++++++++++++++++++++++++--------- 1 file changed, 44 insertions(+), 13 deletions(-) -- 2.20.1