mbox series

[v3,0/5] Add multimode invoke request IOCTl support

Message ID 1695206827-29446-1-git-send-email-quic_ekangupt@quicinc.com
Headers show
Series Add multimode invoke request IOCTl support | expand

Message

Ekansh Gupta Sept. 20, 2023, 10:47 a.m. UTC 
Add changes to support multimode invocation ioctl request. This
ioctl call facilitates multiple types of requests from user including
CRC check, performance counters, shared context bank usage, etc.
This series also carries patch to save and restore interrupted
context.

Ekansh Gupta (5):
  misc: fastrpc: Add fastrpc multimode invoke request support
  misc: fastrpc: Add CRC support for remote buffers
  misc: fastrpc: Capture kernel and DSP performance counters
  misc: fastrpc: Add support to save and restore interrupted
  misc: fastrpc: Add support to allocate shared context bank

 drivers/misc/fastrpc.c      | 480 ++++++++++++++++++++++++++++++++++++--------
 include/uapi/misc/fastrpc.h |  51 +++++
 2 files changed, 446 insertions(+), 85 deletions(-)

Comments

Greg KH Sept. 28, 2023, 1:07 p.m. UTC | #1 
On Wed, Sep 20, 2023 at 04:17:03PM +0530, Ekansh Gupta wrote:
> Multimode invocation request is intended to support multiple
> different type of requests. This will include enhanced invoke
> request to support CRC check and performance counter enablement.
> This will also support few driver level user controllable
> mechanisms like usage of shared context banks, wakelock support,
> etc. This IOCTL is also added with the aim to support few
> new fastrpc features like DSP PD notification framework,
> DSP Signalling mechanism etc.

I can't see where you are properly checking the reserved fields in your
new ioctl structures, am I just missing that logic somewhere?

thanks,

greg k-h