| Message ID | 1653079257-20894-1-git-send-email-quic_khsieh@quicinc.com |
|---|---|
| Headers | show |
| Series | eDP/DP Phy vdda realted function | expand |
Quoting Kuogee Hsieh (2022-05-20 13:40:55) > This patch add regulator_set_load() before enable regulator at > eDP phy driver. > > Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c > index cacd32f..955466d 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -639,6 +639,18 @@ static int qcom_edp_phy_probe(struct platform_device *pdev) > if (ret) > return ret; > > + ret = regulator_set_load(edp->supplies[0].consumer, 21800); /* 1.2 V vdda-phy */ > + if (ret) { > + dev_err(dev, "failed to set load\n"); Which supply failed to set load? > + return ret; > + } > + > + ret = regulator_set_load(edp->supplies[1].consumer, 36000); /* 0.9 V vdda-pll */ > + if (ret) { > + dev_err(dev, "failed to set load\n"); This printk is the same as above. I hope this print never happens or it will not be useful enough to narrow down the issue. > + return ret; > + }
1) add regulator_set_load() to eDP phy 2) add regulator_set_load() to DP phy 3) remove vdda related function out of eDP/DP controller Kuogee Hsieh (3): phy: qcom-edp: add regulator_set_load to edp phy phy: qcom-qmp: add regulator_set_load to dp phy drm/msm/dp: delete vdda regulator related functions from eDP/DP controller drivers/gpu/drm/msm/dp/dp_parser.c | 14 ------ drivers/gpu/drm/msm/dp/dp_parser.h | 6 --- drivers/gpu/drm/msm/dp/dp_power.c | 95 +------------------------------------ drivers/phy/qualcomm/phy-qcom-edp.c | 12 +++++ drivers/phy/qualcomm/phy-qcom-qmp.c | 24 +++++++++- 5 files changed, 37 insertions(+), 114 deletions(-)