mbox series

[0/6] Add frequency and voltage scaling support for IPQ6018 SoC

Message ID 1592550307-11040-1-git-send-email-kathirav@codeaurora.org
Headers show
Series Add frequency and voltage scaling support for IPQ6018 SoC | expand

Message

Kathiravan T June 19, 2020, 7:05 a.m. UTC
IPQ6018 SoC uses the PMIC MP5496. SMPA2 and LDOA2 regulator of MP5496
controls the APSS and SDCC voltage scaling respectively. Add support
for the same.

Kathiravan T (6):
  dt-bindings: soc: qcom: add YAML schema for SMD-RPM driver
  dt-bindings: soc: qcom: Add IPQ6018 compatible
  soc: qcom: smd-rpm: Add IPQ6018 compatible
  dt-bindings: regulator: add YAML schema for QCOM SMD-RPM regulator
  dt-bindings: add MP5496 regulator compatible
  regulator: qcom_smd: Add MP5496 regulators

 .../bindings/regulator/qcom,smd-rpm-regulator.txt  | 320 ---------------------
 .../bindings/regulator/qcom,smd-rpm-regulator.yaml | 106 +++++++
 .../devicetree/bindings/soc/qcom/qcom,smd-rpm.txt  |  62 ----
 .../devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml |  92 ++++++
 drivers/regulator/qcom_smd-regulator.c             |  34 +++
 drivers/soc/qcom/smd-rpm.c                         |   1 +
 6 files changed, 233 insertions(+), 382 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.yaml
 delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml

Comments

Rob Herring July 15, 2020, 7:14 p.m. UTC | #1
On Fri, Jun 19, 2020 at 12:35:02PM +0530, Kathiravan T wrote:
> Add YAML schema for the devitree properties used in the SMD-RPM driver.


This is converting, not adding...

> 

> Signed-off-by: Kathiravan T <kathirav@codeaurora.org>

> ---

>  .../devicetree/bindings/soc/qcom/qcom,smd-rpm.txt  | 62 ---------------

>  .../devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml | 91 ++++++++++++++++++++++

>  2 files changed, 91 insertions(+), 62 deletions(-)

>  delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt

>  create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml



> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml

> new file mode 100644

> index 00000000..5b33def

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml

> @@ -0,0 +1,91 @@

> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)

> +%YAML 1.2

> +---

> +$id: "http://devicetree.org/schemas/soc/qcom/qcom,smd-rpm.yaml#"

> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

> +

> +title: Qualcomm Resource Power Manager (RPM) over SMD

> +

> +description: |

> +  This driver is used to interface with the Resource Power Manager (RPM) found

> +  in various Qualcomm platforms. The RPM allows each component in the system

> +  to vote for state of the system resources, such as clocks, regulators and bus

> +  frequencies.

> +

> +  The SMD information for the RPM edge should be filled out.  See qcom,smd.txt

> +  for the required edge properties.  All SMD related properties will reside

> +  within the RPM node itself.

> +

> +  The RPM exposes resources to its subnodes.  The rpm_requests node must be

> +  present and this subnode may contain children that designate regulator

> +  resources.

> +

> +  Refer to Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.txt

> +  for information on the regulator subnodes that can exist under the

> +  rpm_requests.

> +

> +maintainers:

> +  - Kathiravan T <kathirav@codeaurora.org>

> +

> +properties:

> +  compatible:

> +    enum:

> +      - qcom,rpm-apq8084

> +      - qcom,rpm-msm8916

> +      - qcom,rpm-msm8974

> +      - qcom,rpm-msm8976

> +      - qcom,rpm-msm8996

> +      - qcom,rpm-msm8998

> +      - qcom,rpm-sdm660

> +      - qcom,rpm-qcs404

> +

> +  qcom,smd-channels:

> +    $ref: /schemas/types.yaml#/definitions/string-array

> +    description: Channel name used for the RPM communication

> +    items:

> +      - const: rpm_requests

> +

> +if:

> +  properties:

> +    compatible:

> +      contains:

> +        enum:

> +          - qcom,rpm-apq8084

> +          - qcom,rpm-msm8916

> +          - qcom,rpm-msm8974

> +then:

> +  required:

> +    - qcom,smd-channels

> +

> +required:

> +  - compatible

> +

> +additionalProperties: false

> +

> +examples:

> +  - |

> +    soc {

> +        #address-cells = <1>;

> +        #size-cells = <1>;

> +        apcs: syscon@f9011000 {

> +              compatible = "syscon";

> +              reg = <0xf9011000 0x1000>;

> +        };

> +    };


Drop this node. The use of 'syscon' alone is not valid and will now 
generate warnings with what I have queued for 5.9.

> +    smd {

> +        compatible = "qcom,smd";

> +

> +        rpm {

> +            interrupts = <0 168 1>;

> +            qcom,ipc = <&apcs 8 0>;

> +            qcom,smd-edge = <15>;

> +

> +                rpm_requests {

> +                        compatible = "qcom,rpm-msm8974";

> +                        qcom,smd-channels = "rpm_requests";

> +

> +                        /* Regulator nodes to follow */

> +                };

> +            };

> +     };

> +...

> -- 

> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

>