From patchwork Wed Jun 29 01:45:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kefeng Wang X-Patchwork-Id: 71163 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp1892569qgy; Tue, 28 Jun 2016 18:48:44 -0700 (PDT) X-Received: by 10.98.109.134 with SMTP id i128mr7074869pfc.72.1467164924687; Tue, 28 Jun 2016 18:48:44 -0700 (PDT) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id vo6si1423155pab.224.2016.06.28.18.48.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jun 2016 18:48:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) smtp.mailfrom=linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bI4b4-00043F-2u; Wed, 29 Jun 2016 01:47:22 +0000 Received: from szxga01-in.huawei.com ([58.251.152.64]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bI4ay-0003X9-CK for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2016 01:47:20 +0000 Received: from 172.24.1.137 (EHLO SZXEML423-HUB.china.huawei.com) ([172.24.1.137]) by szxrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DMX91799; Wed, 29 Jun 2016 09:46:15 +0800 (CST) Received: from [127.0.0.1] (10.177.19.180) by SZXEML423-HUB.china.huawei.com (10.82.67.154) with Microsoft SMTP Server id 14.3.235.1; Wed, 29 Jun 2016 09:46:12 +0800 Subject: Re: [linux-next:master 5450/6660] arch/arm/mach-s3c64xx/common.h:28:2: warning: 'struct device_node' declared inside parameter list To: kbuild test robot , Rob Herring , Kukjin Kim References: <201606290335.vfTSIIB7%fengguang.wu@intel.com> From: Kefeng Wang Message-ID: Date: Wed, 29 Jun 2016 09:45:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <201606290335.vfTSIIB7%fengguang.wu@intel.com> X-Originating-IP: [10.177.19.180] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.57732868.0154, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 49013291876b75d125a99d9945db1b2e X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160628_184717_004413_B1E599AA X-CRM114-Status: GOOD ( 12.23 ) X-Spam-Score: -5.6 (-----) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-5.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [58.251.152.64 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [58.251.152.64 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -1.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof Kozlowski , kbuild-all@01.org, linux-arm-kernel Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org On 2016/6/29 3:12, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 6f2a161b1445a150f4a759194fde4c386f5e2947 > commit: 850bea2335e42780a0752a75860d3fbcc3d12d6e [5450/6660] arm: Remove unnecessary of_platform_populate with default match table > config: arm-allmodconfig (attached as .config) > compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205 > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout 850bea2335e42780a0752a75860d3fbcc3d12d6e > # save the attached .config to linux build tree > make.cross ARCH=arm > > All warnings (new ones prefixed by >>): > > In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0: >>> arch/arm/mach-s3c64xx/common.h:28:2: warning: 'struct device_node' declared inside parameter list > unsigned long xusbxti_f, bool is_s3c6400, void __iomem *reg_base); > ^ >>> arch/arm/mach-s3c64xx/common.h:28:2: warning: its scope is only this definition or declaration, which is probably not what you want From: Kefeng Wang Date: Wed, 29 Jun 2016 09:28:48 +0800 Subject: [PATCH] ARM: s3c64xx: Add missing head file The building reports warning after patch "arm: Remove unnecessary of_platform_populate with default match table", "arch/arm/mach-s3c64xx/common.h:28:2: warning: 'struct device_node' declared inside parameter list" Add the missing of.h for device_node struct in common.h, and kill common.h from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c, because no function need it. Signed-off-by: Kefeng Wang --- arch/arm/mach-s3c64xx/common.h | 1 + arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) -- 1.7.12.4 > > vim +28 arch/arm/mach-s3c64xx/common.h > > b024043b6 Kukjin Kim 2011-12-22 12 * This program is free software; you can redistribute it and/or modify > b024043b6 Kukjin Kim 2011-12-22 13 * it under the terms of the GNU General Public License version 2 as > b024043b6 Kukjin Kim 2011-12-22 14 * published by the Free Software Foundation. > b024043b6 Kukjin Kim 2011-12-22 15 */ > b024043b6 Kukjin Kim 2011-12-22 16 > b024043b6 Kukjin Kim 2011-12-22 17 #ifndef __ARCH_ARM_MACH_S3C64XX_COMMON_H > b024043b6 Kukjin Kim 2011-12-22 18 #define __ARCH_ARM_MACH_S3C64XX_COMMON_H > b024043b6 Kukjin Kim 2011-12-22 19 > 7b6d864b4 Robin Holt 2013-07-08 20 #include > 7b6d864b4 Robin Holt 2013-07-08 21 > b024043b6 Kukjin Kim 2011-12-22 22 void s3c64xx_init_irq(u32 vic0, u32 vic1); > b024043b6 Kukjin Kim 2011-12-22 23 void s3c64xx_init_io(struct map_desc *mach_desc, int size); > b024043b6 Kukjin Kim 2011-12-22 24 > 7b6d864b4 Robin Holt 2013-07-08 25 void s3c64xx_restart(enum reboot_mode mode, const char *cmd); > ff84ded26 Kukjin Kim 2012-01-03 26 > b69f460dc Tomasz Figa 2013-08-26 27 void s3c64xx_clk_init(struct device_node *np, unsigned long xtal_f, > b69f460dc Tomasz Figa 2013-08-26 @28 unsigned long xusbxti_f, bool is_s3c6400, void __iomem *reg_base); > b69f460dc Tomasz Figa 2013-08-26 29 void s3c64xx_set_xtal_freq(unsigned long freq); > b69f460dc Tomasz Figa 2013-08-26 30 void s3c64xx_set_xusbxti_freq(unsigned long freq); > b69f460dc Tomasz Figa 2013-08-26 31 > b024043b6 Kukjin Kim 2011-12-22 32 #ifdef CONFIG_CPU_S3C6400 > b024043b6 Kukjin Kim 2011-12-22 33 > b024043b6 Kukjin Kim 2011-12-22 34 extern int s3c6400_init(void); > b024043b6 Kukjin Kim 2011-12-22 35 extern void s3c6400_init_irq(void); > b024043b6 Kukjin Kim 2011-12-22 36 extern void s3c6400_map_io(void); > > :::::: The code at line 28 was first introduced by commit > :::::: b69f460dc1a074db3f759c2be9cd13271f91fbdd ARM: S3C64XX: Migrate clock handling to Common Clock Framework > > :::::: TO: Tomasz Figa > :::::: CC: Kukjin Kim > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/arch/arm/mach-s3c64xx/common.h b/arch/arm/mach-s3c64xx/common.h index 9eb8644..c2c8ac3 100644 --- a/arch/arm/mach-s3c64xx/common.h +++ b/arch/arm/mach-s3c64xx/common.h @@ -17,6 +17,7 @@ #ifndef __ARCH_ARM_MACH_S3C64XX_COMMON_H #define __ARCH_ARM_MACH_S3C64XX_COMMON_H +#include #include void s3c64xx_init_irq(u32 vic0, u32 vic1); diff --git a/arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c b/arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c index 5bf9afa..be0678a 100644 --- a/arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c +++ b/arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c @@ -15,7 +15,6 @@ #include #include -#include "common.h" #include "watchdog-reset.h" /*