From patchwork Wed Aug 19 18:40:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Pitre X-Patchwork-Id: 52562 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f72.google.com (mail-la0-f72.google.com [209.85.215.72]) by patches.linaro.org (Postfix) with ESMTPS id E6B732156D for ; Wed, 19 Aug 2015 18:42:39 +0000 (UTC) Received: by labth1 with SMTP id th1sf4228014lab.2 for ; Wed, 19 Aug 2015 11:42:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:subject:in-reply-to :message-id:references:user-agent:mime-version:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe:cc :content-type:content-transfer-encoding:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list; bh=u5J1sQpCewgilqxGIVZpQWgxlq8O5de5woB/cAeEbYg=; b=kTvZjNe0evWPpPtj5FECu7/OtYJz/A2iLiV0VrMsk707yYFtlxOjV1tdJ8nTbCVy4g tD6+F6LPO1J2cu/9l5Xkb8j3aN1tekQuiaLG6mO0JUyp9T7HruxJwi8t+HBww1vqmcPX 4p1dc/tEUk1wCvHY/82Z0Cdr2lWokcIw+uKicHTKtwdJA/5thndbyK4AinY25LUDUG4w IrcT3T6hUVlIO7s6Gc+oCmw/PEfIFiLVzfW55nXyyLxXGQ4e+Z7wL6mXTxLFB9joeako HI211BsgKjRl4HJ7tIwYu46WqO7LfOSEpJ4xrOmbyUapm1vDKzC7Yc3+06euKhFt24s3 ooLQ== X-Gm-Message-State: ALoCoQlatNiFCoULwq3gGQM6Q2GupVTnBRYFI544FEFrySkZyNi7gtD9MBu7zrKisGFhkRbAmla5 X-Received: by 10.194.93.198 with SMTP id cw6mr3575819wjb.3.1440009758454; Wed, 19 Aug 2015 11:42:38 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.219.4 with SMTP id pk4ls74246lac.90.gmail; Wed, 19 Aug 2015 11:42:38 -0700 (PDT) X-Received: by 10.112.130.3 with SMTP id oa3mr6012652lbb.13.1440009758154; Wed, 19 Aug 2015 11:42:38 -0700 (PDT) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com. [209.85.217.182]) by mx.google.com with ESMTPS id lh8si1475558lbc.59.2015.08.19.11.42.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Aug 2015 11:42:38 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.182 as permitted sender) client-ip=209.85.217.182; Received: by lbbsx3 with SMTP id sx3so9201406lbb.0 for ; Wed, 19 Aug 2015 11:42:38 -0700 (PDT) X-Received: by 10.112.125.34 with SMTP id mn2mr11727009lbb.76.1440009757940; Wed, 19 Aug 2015 11:42:37 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.162.200 with SMTP id yc8csp548475lbb; Wed, 19 Aug 2015 11:42:36 -0700 (PDT) X-Received: by 10.107.136.148 with SMTP id s20mr13385616ioi.135.1440009755764; Wed, 19 Aug 2015 11:42:35 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id h4si2800085pda.83.2015.08.19.11.42.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Aug 2015 11:42:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZS8IU-0006PV-93; Wed, 19 Aug 2015 18:41:14 +0000 Received: from mail-qk0-f177.google.com ([209.85.220.177]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZS8IR-0006Ni-VD for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2015 18:41:12 +0000 Received: by qkep139 with SMTP id p139so5614617qke.3 for ; Wed, 19 Aug 2015 11:40:50 -0700 (PDT) X-Received: by 10.55.201.27 with SMTP id q27mr25034156qki.57.1440009649980; Wed, 19 Aug 2015 11:40:49 -0700 (PDT) Received: from xanadu.home (modemcable065.157-23-96.mc.videotron.ca. [96.23.157.65]) by smtp.gmail.com with ESMTPSA id h78sm810524qhc.47.2015.08.19.11.40.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Aug 2015 11:40:49 -0700 (PDT) Date: Wed, 19 Aug 2015 14:40:47 -0400 (EDT) From: Nicolas Pitre To: Michael Turquette Subject: Re: [PATCH] drivers/clk: appropriate __init annotation for const data In-Reply-To: <20150811231416.31346.83289@quantum> Message-ID: References: <20150811231416.31346.83289@quantum> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150819_114112_081164_5D18B162 X-CRM114-Status: GOOD ( 14.90 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.177 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.220.177 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: nicolas.pitre@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.182 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 On Tue, 11 Aug 2015, Michael Turquette wrote: > Quoting Nicolas Pitre (2015-07-28 16:43:20) > > > > Init data marked const should be annotated with __initconst for > > correctness and not __initdata. This also fixes LTO builds that > > otherwise fail with section mismatch errors. > > > > Signed-off-by: Nicolas Pitre > > Thanks for the patch Nico. Applied. Is it possible for you to amend that patch with the following? Turns out that sys_parents[] is actually written to. Nicolas diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c index 5404a001c3..3f6f7ad394 100644 --- a/drivers/clk/clk-stm32f4.c +++ b/drivers/clk/clk-stm32f4.c @@ -293,7 +293,7 @@ stm32f4_rcc_lookup_clk(struct of_phandle_args *clkspec, void *data) return clks[i]; } -static const char *const sys_parents[] __initconst = { "hsi", NULL, "pll" }; +static const char *sys_parents[] __initdata = { "hsi", NULL, "pll" }; static const struct clk_div_table ahb_div_table[] = { { 0x0, 1 }, { 0x1, 1 }, { 0x2, 1 }, { 0x3, 1 },