From patchwork Tue Apr 29 02:15:41 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 29278 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f199.google.com (mail-ob0-f199.google.com [209.85.214.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 111F320553 for ; Tue, 29 Apr 2014 02:18:19 +0000 (UTC) Received: by mail-ob0-f199.google.com with SMTP id gq1sf45153416obb.10 for ; Mon, 28 Apr 2014 19:18:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:subject:date:message-id :in-reply-to:references:cc:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:content-type:content-transfer-encoding; bh=eDo/QqKnwrFrY8py1BBtGgeReu632TWdXevXovLouec=; b=SahoDsxsWXPs1js4abgo93Fg7K6brUY3GWfNeBBY7ntdmGQRLKTb8qqg/l+NYwPwZk kVal0ur5wUHtcSE/YlNtUKGTbLRIDvqZYztcbehzOeeOAsBuuxothDUwK12KJp607iOI CgGzxMlUcHSuyZV1mVkJkdGhMt2hv6PJpJkZp2gMgNXJXgiS5bWepoLs94FsqfleOEli kZ3BrQJmE/0yAFVrkK4IslgivNS2MRf08NcCVLwuDnxsA8Gi8Xs96dpu21UkBPFrV+vi Xeldm9moHuBe1ssGR6ggrr9xBjGmbc1XeP9w2NFXP0J5Bn3eFWwQaFADz5pBDNgADcCS 6nmw== X-Gm-Message-State: ALoCoQnyHRrLKEnEliA2Cupi71iC8m25kCPzm+yAmneotATvWJt2KaEkAMpoy1fwdkI8I3QJfPbd X-Received: by 10.182.216.165 with SMTP id or5mr14998603obc.29.1398737899585; Mon, 28 Apr 2014 19:18:19 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.87.177 with SMTP id r46ls2876080qgd.98.gmail; Mon, 28 Apr 2014 19:18:19 -0700 (PDT) X-Received: by 10.58.230.103 with SMTP id sx7mr4863848vec.28.1398737899440; Mon, 28 Apr 2014 19:18:19 -0700 (PDT) Received: from mail-vc0-f175.google.com (mail-vc0-f175.google.com [209.85.220.175]) by mx.google.com with ESMTPS id w4si1984869vct.102.2014.04.28.19.18.19 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 28 Apr 2014 19:18:19 -0700 (PDT) Received-SPF: none (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) client-ip=209.85.220.175; Received: by mail-vc0-f175.google.com with SMTP id lh4so2424403vcb.34 for ; Mon, 28 Apr 2014 19:18:19 -0700 (PDT) X-Received: by 10.220.92.135 with SMTP id r7mr26943324vcm.11.1398737899208; Mon, 28 Apr 2014 19:18:19 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp161119vcb; Mon, 28 Apr 2014 19:18:18 -0700 (PDT) X-Received: by 10.224.79.12 with SMTP id n12mr38335737qak.13.1398737898605; Mon, 28 Apr 2014 19:18:18 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id z3si8811124qcl.26.2014.04.28.19.18.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Apr 2014 19:18:18 -0700 (PDT) Received-SPF: none (google.com: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org does not designate permitted sender hosts) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wexb9-0007HY-QW; Tue, 29 Apr 2014 02:16:43 +0000 Received: from kirsty.vergenet.net ([202.4.237.240]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wexal-000793-Nb for linux-arm-kernel@lists.infradead.org; Tue, 29 Apr 2014 02:16:20 +0000 Received: from ayumi.isobedori.kobe.vergenet.net (p2182-ipbfp905kobeminato.hyogo.ocn.ne.jp [122.21.197.182]) by kirsty.vergenet.net (Postfix) with ESMTP id 3A68E267160; Tue, 29 Apr 2014 12:15:43 +1000 (EST) Received: by ayumi.isobedori.kobe.vergenet.net (Postfix, from userid 7100) id EC47EEDE6F1; Tue, 29 Apr 2014 11:15:41 +0900 (JST) From: Simon Horman To: linux-sh@vger.kernel.org Subject: [PATCH] ARM: shmobile: Ignore callbacks for subsys generic_pm_domain_data Date: Tue, 29 Apr 2014 11:15:41 +0900 Message-Id: X-Mailer: git-send-email 1.8.5.2 In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140428_191619_928264_5C1F0278 X-CRM114-Status: GOOD ( 13.30 ) X-Spam-Score: -1.4 (-) X-Spam-Report: SpamAssassin version 3.3.2 on bombadil.infradead.org summary: Content analysis details: (-1.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [202.4.237.240 listed in list.dnswl.org] -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain Cc: Simon Horman , Ulf Hansson , Magnus Damm , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: horms@verge.net.au X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: patch+caf_=patchwork-forward=linaro.org@linaro.org does not designate permitted sender hosts) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Ulf Hansson There are no active users of these callbacks, thus there are no benefit of trying to invoke them. Cc: Simon Horman Cc: Magnus Damm Signed-off-by: Ulf Hansson Signed-off-by: Simon Horman --- arch/arm/mach-shmobile/pm-rmobile.c | 38 +++---------------------------------- 1 file changed, 3 insertions(+), 35 deletions(-) diff --git a/arch/arm/mach-shmobile/pm-rmobile.c b/arch/arm/mach-shmobile/pm-rmobile.c index 1fc05d9..f710235 100644 --- a/arch/arm/mach-shmobile/pm-rmobile.c +++ b/arch/arm/mach-shmobile/pm-rmobile.c @@ -99,39 +99,7 @@ static int rmobile_pd_power_up(struct generic_pm_domain *genpd) static bool rmobile_pd_active_wakeup(struct device *dev) { - bool (*active_wakeup)(struct device *dev); - - active_wakeup = dev_gpd_data(dev)->ops.active_wakeup; - return active_wakeup ? active_wakeup(dev) : true; -} - -static int rmobile_pd_stop_dev(struct device *dev) -{ - int (*stop)(struct device *dev); - - stop = dev_gpd_data(dev)->ops.stop; - if (stop) { - int ret = stop(dev); - if (ret) - return ret; - } - return pm_clk_suspend(dev); -} - -static int rmobile_pd_start_dev(struct device *dev) -{ - int (*start)(struct device *dev); - int ret; - - ret = pm_clk_resume(dev); - if (ret) - return ret; - - start = dev_gpd_data(dev)->ops.start; - if (start) - ret = start(dev); - - return ret; + return true; } static void rmobile_init_pm_domain(struct rmobile_pm_domain *rmobile_pd) @@ -140,8 +108,8 @@ static void rmobile_init_pm_domain(struct rmobile_pm_domain *rmobile_pd) struct dev_power_governor *gov = rmobile_pd->gov; pm_genpd_init(genpd, gov ? : &simple_qos_governor, false); - genpd->dev_ops.stop = rmobile_pd_stop_dev; - genpd->dev_ops.start = rmobile_pd_start_dev; + genpd->dev_ops.stop = pm_clk_suspend; + genpd->dev_ops.start = pm_clk_resume; genpd->dev_ops.active_wakeup = rmobile_pd_active_wakeup; genpd->dev_irq_safe = true; genpd->power_off = rmobile_pd_power_down;