From patchwork Thu Sep 8 17:03:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Miao X-Patchwork-Id: 3987 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 51A6123F9F for ; Thu, 8 Sep 2011 17:04:15 +0000 (UTC) Received: from mail-fx0-f52.google.com (mail-fx0-f52.google.com [209.85.161.52]) by fiordland.canonical.com (Postfix) with ESMTP id 3B602A18240 for ; Thu, 8 Sep 2011 17:04:15 +0000 (UTC) Received: by fxd18 with SMTP id 18so2531853fxd.11 for ; Thu, 08 Sep 2011 10:04:15 -0700 (PDT) Received: by 10.223.24.21 with SMTP id t21mr333003fab.24.1315501455060; Thu, 08 Sep 2011 10:04:15 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.152.11.8 with SMTP id m8cs182344lab; Thu, 8 Sep 2011 10:04:14 -0700 (PDT) Received: by 10.52.71.3 with SMTP id q3mr1027923vdu.435.1315501453212; Thu, 08 Sep 2011 10:04:13 -0700 (PDT) Received: from mail-vx0-f178.google.com (mail-vx0-f178.google.com [209.85.220.178]) by mx.google.com with ESMTPS id n8si1012453vcu.75.2011.09.08.10.04.12 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 08 Sep 2011 10:04:13 -0700 (PDT) Received-SPF: pass (google.com: domain of eric.y.miao@gmail.com designates 209.85.220.178 as permitted sender) client-ip=209.85.220.178; Authentication-Results: mx.google.com; spf=pass (google.com: domain of eric.y.miao@gmail.com designates 209.85.220.178 as permitted sender) smtp.mail=eric.y.miao@gmail.com; dkim=pass (test mode) header.i=@gmail.com Received: by vxh35 with SMTP id 35so1092699vxh.37 for ; Thu, 08 Sep 2011 10:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=DEdK6y0dYXK7VUAYWyTJh0NbFqwKbHR4w+b53NsTruc=; b=s1TvcX+35R9DuHHcExhT2+6wKIRbjkheubJiuPZnEm8/M2v74EHSoKK5Bko0GTbK8c 8UKSoYlfeY8cDlHHaJow0Fn1r+CnDEdpiDBM/kEqowgAtjPVAyJ24FwzNpGtisUbryDk rprAwqaoR+gWoFE4Ro2t1alyFVSiMAFegCpyU= Received: by 10.52.93.164 with SMTP id cv4mr971015vdb.304.1315501452500; Thu, 08 Sep 2011 10:04:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.185.72 with HTTP; Thu, 8 Sep 2011 10:03:52 -0700 (PDT) In-Reply-To: <201109081845.58260.arnd@arndb.de> References: <1315497854-13311-1-git-send-email-dave.martin@linaro.org> <1315497854-13311-3-git-send-email-dave.martin@linaro.org> <201109081845.58260.arnd@arndb.de> From: Eric Miao Date: Thu, 8 Sep 2011 10:03:52 -0700 Message-ID: Subject: Re: [PATCH v2 2/3] ARM: iwmmxt: Port problematic iwmmxt support code to v7/Thumb-2 To: Arnd Bergmann Cc: Dave Martin , linux-arm-kernel@lists.infradead.org, patches@linaro.org, Haojian Zhuang On Thu, Sep 8, 2011 at 9:45 AM, Arnd Bergmann wrote: > On Thursday 08 September 2011, Dave Martin wrote: >> The iwmmxt code contains some code to implement a pseudo-ISB, but >> this is not buildable for Thumb-2. >> >> This patch replaces the pseudo-ISB with a real one for Thumb-2 >> kernels. >> >> Signed-off-by: Dave Martin >> --- >>  arch/arm/kernel/iwmmxt.S |    9 +++++++++ >>  1 files changed, 9 insertions(+), 0 deletions(-) > > Acked-by: Arnd Bergmann > Maybe it'll be much simpler to have something like below: diff --git a/arch/arm/kernel/iwmmxt.S b/arch/arm/kernel/iwmmxt.S index a087838..5998f7d 100644 --- a/arch/arm/kernel/iwmmxt.S +++ b/arch/arm/kernel/iwmmxt.S @@ -319,8 +319,9 @@ ENTRY(iwmmxt_task_switch) PJ4(eor r1, r1, #0xf) PJ4(mcr p15, 0, r1, c1, c0, 2) - mrc p15, 0, r1, c2, c0, 0 - sub pc, lr, r1, lsr #32 @ cpwait and return + XSC(mrc p15, 0, r1, c2, c0, 0) + PJ4(isb) + mov pc, lr @ cpwait and return /* * Remove Concan ownership of given task