From patchwork Wed Apr 20 09:43:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 66208 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp2344870qge; Wed, 20 Apr 2016 02:45:25 -0700 (PDT) X-Received: by 10.98.73.142 with SMTP id r14mr10921839pfi.140.1461145525783; Wed, 20 Apr 2016 02:45:25 -0700 (PDT) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id s16si17112310pfi.193.2016.04.20.02.45.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Apr 2016 02:45:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) smtp.mailfrom=linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1asogO-0007sq-Js; Wed, 20 Apr 2016 09:44:28 +0000 Received: from mail-io0-x232.google.com ([2607:f8b0:4001:c06::232]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1asofo-0006aQ-4p for linux-arm-kernel@lists.infradead.org; Wed, 20 Apr 2016 09:43:54 +0000 Received: by mail-io0-x232.google.com with SMTP id 2so46586524ioy.1 for ; Wed, 20 Apr 2016 02:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=yIIWrCSYZFaNSZW92i8TviyIS3mN3v21CjfK/ddv57g=; b=TOF5SsUaV40sIwPfp/XLbo5qYq1uPnS99r2PpASh/WkHq33TUwdRcDraAS67APt8xU //5U2a1LHDjFYG8nKX+2Ue+LV8SiIobEHW84935u33JJwy7/Op/pPAdOHU5L6rUicLXW ZF9IA17Vtx+qrnImhK/dr2mCQaGJ1LlawjPCU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=yIIWrCSYZFaNSZW92i8TviyIS3mN3v21CjfK/ddv57g=; b=flAFrql6RTltvcwe/id/B4bVOhdHadFmmFDY7tlSLi7dlPNUwWkK/BiU/hgddIJNpE FcxCq4kGn1BEWqeHo2Jnx7gABqzdSEfLl7yyifEqHysvbubUYz1icDjl41w0fGY8oZra Bk9atW3a3CQpQCUotr50IKqRrvjPQSZ3Bh7qrOejBorhyd7I5CNSyvbWaEEXP0n53WQP gVEH/LcOi0dA+OpjCscz+JA/Uq/uxAQWNbfLYxLkDQj1aD2h1XqAM6A5H1mrfu4tpBTl wouuKQwzwo0MULKUTer9wwtO7j7+gs6naPLMiqto1GTy0oHBP3iSVWNshx1z8w2K7IdO dO1g== X-Gm-Message-State: AOPr4FX3GnhOJ6ybwku09tw4cEZ8P0ky/pJAwyCfHEaiZHkxtLNbnLLMA8JpnylRCNzghU15I9HDHnoGUCmtM5k0 MIME-Version: 1.0 X-Received: by 10.107.134.8 with SMTP id i8mr8595977iod.130.1461145411053; Wed, 20 Apr 2016 02:43:31 -0700 (PDT) Received: by 10.36.139.197 with HTTP; Wed, 20 Apr 2016 02:43:30 -0700 (PDT) In-Reply-To: References: <20160419140220.GA9503@pengutronix.de> <20160420092516.GA21732@e103592.cambridge.arm.com> Date: Wed, 20 Apr 2016 11:43:30 +0200 Message-ID: Subject: Re: SoCFPGA with CONFIG_THUMB2_KERNEL boot error From: Ard Biesheuvel To: Dave Martin , Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160420_024352_620811_95E2F848 X-CRM114-Status: GOOD ( 12.02 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2607:f8b0:4001:c06:0:0:0:232 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dinh Nguyen , Steffen Trumtrar , "linux-arm-kernel@lists.infradead.org" , kernel@pengutronix.de Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org (replying to self) On 20 April 2016 at 11:39, Ard Biesheuvel wrote: > (+ Arnd) > > On 20 April 2016 at 11:25, Dave Martin wrote: >> On Tue, Apr 19, 2016 at 04:02:20PM +0200, Steffen Trumtrar wrote: >>> Hi! >>> >>> According to kernelci.org (and validating on my own hardware), the current >>> socfpga mainline kernel has an issue with CONFIG_THUMB2_KERNEL enabled. >>> >>> https://storage.kernelci.org/mainline/v4.6-rc4-11-g12566cc35d0e/arm-multi_v7_defconfig/lab-khilman/boot-socfpga_cyclone5_de0_sockit.html >>> >>> vs >>> >>> https://storage.kernelci.org/mainline/v4.6-rc4-11-g12566cc35d0e/arm-multi_v7_defconfig+CONFIG_THUMB2_KERNEL=y/lab-khilman/boot-socfpga_cyclone5_de0_sockit.html >>> >>> Both boot successfully, but notice that the board fails to bring up CPU1 if >>> thumb2 support is enabled. >>> >>> Any ideas why this might be happening? >> Actually, this looks like a problem with the secondary entry point to me. Could you try this? flush_cache_all(); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/arch/arm/mach-socfpga/platsmp.c b/arch/arm/mach-socfpga/platsmp.c index 07945748b571..b56c81340a85 100644 --- a/arch/arm/mach-socfpga/platsmp.c +++ b/arch/arm/mach-socfpga/platsmp.c @@ -40,7 +40,7 @@ static int socfpga_boot_secondary(unsigned int cpu, struct task_struct *idle) memcpy(phys_to_virt(0), &secondary_trampoline, trampoline_size); - writel(virt_to_phys(secondary_startup), + writel(virt_to_phys(secondary_startup_arm), sys_manager_base_addr + (socfpga_cpu1start_addr & 0x000000ff));