From patchwork Mon Jul 14 05:34:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 33549 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f70.google.com (mail-oa0-f70.google.com [209.85.219.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 17EC320CAD for ; Mon, 14 Jul 2014 05:36:28 +0000 (UTC) Received: by mail-oa0-f70.google.com with SMTP id eb12sf17282902oac.5 for ; Sun, 13 Jul 2014 22:36:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=g7ONxauCxu98YSxMrQGom1ZOzDx5Vv/OM/l8eF5R2qA=; b=R28hlAL3rxu0InBzooi1u501hjztu9lVN5C45hLEBWR5AiDpgegNanzzwOBjaPOVzP t+jXQTXAxPSbAE3dGwOCsYI1OLfi4+1Ju6a5bv+kzpjlOq7/GOuuFEBwGQPZzjlnxSZ0 gvCAolX67gjeTMMXzIeZjQJvlggta5uCIyH2+QzUNE+h7jYOIhmOMtJ09aJr1zKIulEp JaWeuX435hVHKS/n2E11y3skBLT8ahucmTVP++UwFjB9ZpYHf3oiP1HEyRlZ1dI2lvVn doyx6gtHTBlDMI2D1bDOJSyf8LlW40QvnBAN0eBRzbi5eq0bHqWwdQ+pEoo7A1B29LOE fo4w== X-Gm-Message-State: ALoCoQlRq1ZxUxeUaE9v4JoV0GcYyf8B+SIJS41vNttH+tg8Wzf149KPAnwX4On1eT/2VI8XEZkd X-Received: by 10.182.123.232 with SMTP id md8mr6660237obb.41.1405316188135; Sun, 13 Jul 2014 22:36:28 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.39.6 with SMTP id u6ls926436qgu.59.gmail; Sun, 13 Jul 2014 22:36:28 -0700 (PDT) X-Received: by 10.220.190.197 with SMTP id dj5mr14143291vcb.19.1405316188049; Sun, 13 Jul 2014 22:36:28 -0700 (PDT) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id mt8si4994333vec.72.2014.07.13.22.36.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 13 Jul 2014 22:36:28 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id id10so6252043vcb.2 for ; Sun, 13 Jul 2014 22:36:28 -0700 (PDT) X-Received: by 10.221.25.210 with SMTP id rj18mr14335717vcb.5.1405316187966; Sun, 13 Jul 2014 22:36:27 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp107481vcb; Sun, 13 Jul 2014 22:36:27 -0700 (PDT) X-Received: by 10.70.102.10 with SMTP id fk10mr5355682pdb.111.1405316187152; Sun, 13 Jul 2014 22:36:27 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id ay10si4163070pdb.433.2014.07.13.22.36.26 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Jul 2014 22:36:27 -0700 (PDT) Received-SPF: none (google.com: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org does not designate permitted sender hosts) client-ip=2001:1868:205::9; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1X6YuQ-0001HS-Dr; Mon, 14 Jul 2014 05:34:42 +0000 Received: from mail-oa0-f46.google.com ([209.85.219.46]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1X6YuN-0001Ft-9Z for linux-arm-kernel@lists.infradead.org; Mon, 14 Jul 2014 05:34:39 +0000 Received: by mail-oa0-f46.google.com with SMTP id m1so3691607oag.5 for ; Sun, 13 Jul 2014 22:34:18 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.182.24.101 with SMTP id t5mr6155619obf.66.1405316056915; Sun, 13 Jul 2014 22:34:16 -0700 (PDT) Received: by 10.182.233.166 with HTTP; Sun, 13 Jul 2014 22:34:16 -0700 (PDT) In-Reply-To: References: <53BE926A.2070005@ti.com> <53BFA120.2070005@ti.com> <2CC2A0A4A178534D93D5159BF3BCB661A47A2A7BF3@EAPEX1MAIL1.st.com> Date: Mon, 14 Jul 2014 11:04:16 +0530 Message-ID: Subject: Re: [PATCH V9 2/7] phy: Add drivers for PCIe and SATA phy on SPEAr13xx From: Viresh Kumar To: Mohit KUMAR DCG X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140713_223439_401196_DCB05F2E X-CRM114-Status: UNSURE ( 9.41 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.7 (/) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.219.46 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.46 listed in wl.mailspike.net] Cc: Pratyush ANAND , Bartlomiej Zolnierkiewicz , "linux-pci@vger.kernel.org" , spear-devel , Mark Nicholson , Kishon Vijay Abraham I , Bjorn Helgaas , "olof@lixom.net" , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 On 14 July 2014 10:54, Viresh Kumar wrote: > These makes sense. Will add them. Kishon, here is how the diff looks like now: return 0; @@ -121,10 +124,12 @@ static int spear1340_miphy_sata_exit(struct spear1340_miphy_priv *priv) regmap_update_bits(priv->misc, SPEAR1340_PERIP1_SW_RST, SPEAR1340_PERIP1_SW_RSATA, SPEAR1340_PERIP1_SW_RSATA); + /* Wait for SATA power domain off */ msleep(20); /* Switch off sata power domain */ regmap_update_bits(priv->misc, SPEAR1340_PCM_CFG, SPEAR1340_PCM_CFG_SATA_POWER_EN, 0); + /* Wait for SATA reset assert completion */ msleep(20); return 0; diff --git a/drivers/phy/phy-spear1340-miphy.c b/drivers/phy/phy-spear1340-miphy.c index 5e39231..8de98ad 100644 --- a/drivers/phy/phy-spear1340-miphy.c +++ b/drivers/phy/phy-spear1340-miphy.c @@ -101,10 +101,13 @@ static int spear1340_miphy_sata_init(struct spear1340_miphy_priv *priv) regmap_update_bits(priv->misc, SPEAR1340_PCM_CFG, SPEAR1340_PCM_CFG_SATA_POWER_EN, SPEAR1340_PCM_CFG_SATA_POWER_EN); + /* Wait for SATA power domain on */ msleep(20); + /* Disable PCIE SATA Controller reset */ regmap_update_bits(priv->misc, SPEAR1340_PERIP1_SW_RST, SPEAR1340_PERIP1_SW_RSATA, 0); + /* Wait for SATA reset de-assert completion */ msleep(20);