From patchwork Fri Nov 18 03:37:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kefeng Wang X-Patchwork-Id: 82827 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp1134043qge; Thu, 17 Nov 2016 19:40:43 -0800 (PST) X-Received: by 10.99.95.86 with SMTP id t83mr14381985pgb.0.1479440443910; Thu, 17 Nov 2016 19:40:43 -0800 (PST) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id 201si5998390pfc.120.2016.11.17.19.40.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Nov 2016 19:40:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) smtp.mailfrom=linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1c7a19-0004Mv-CJ; Fri, 18 Nov 2016 03:39:11 +0000 Received: from szxga01-in.huawei.com ([58.251.152.64]) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1c7a15-0004FX-Cq for linux-arm-kernel@lists.infradead.org; Fri, 18 Nov 2016 03:39:09 +0000 Received: from 172.24.1.136 (EHLO szxeml434-hub.china.huawei.com) ([172.24.1.136]) by szxrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DVI03596; Fri, 18 Nov 2016 11:37:21 +0800 (CST) Received: from [127.0.0.1] (10.177.19.180) by szxeml434-hub.china.huawei.com (10.82.67.225) with Microsoft SMTP Server id 14.3.235.1; Fri, 18 Nov 2016 11:37:16 +0800 Subject: Re: [PATCH next] arm64: remove "SMP: Total of %d processors activated." message To: Will Deacon References: <1479367946-38771-1-git-send-email-wangkefeng.wang@huawei.com> <20161117142213.GI22855@arm.com> From: Kefeng Wang Message-ID: <6d867f8f-c7b9-42e9-1764-6f802d6b1e96@huawei.com> Date: Fri, 18 Nov 2016 11:37:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161117142213.GI22855@arm.com> X-Originating-IP: [10.177.19.180] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161117_193908_055488_1FD032A3 X-CRM114-Status: GOOD ( 11.22 ) X-Spam-Score: -5.6 (-----) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-5.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [58.251.152.64 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [58.251.152.64 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -1.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Catalin Marinas , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org On 2016/11/17 22:22, Will Deacon wrote: > On Thu, Nov 17, 2016 at 03:32:26PM +0800, Kefeng Wang wrote: >> There is a common SMP boot message in generic code on all arches, >> kill "SMP: Total of %d processors activated." in smp_cpus_done() >> on arm64. >> >> Signed-off-by: Kefeng Wang >> --- >> Boot message on qemu. >> [ 0.375116] smp: Brought up 1 node, 8 CPUs >> [ 0.383749] SMP: Total of 8 processors activated. >> >> arch/arm64/kernel/smp.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c >> index cb87234..9db4a95 100644 >> --- a/arch/arm64/kernel/smp.c >> +++ b/arch/arm64/kernel/smp.c >> @@ -428,7 +428,6 @@ static void __init hyp_mode_check(void) >> >> void __init smp_cpus_done(unsigned int max_cpus) >> { >> - pr_info("SMP: Total of %d processors activated.\n", num_online_cpus()); >> setup_cpu_features(); >> hyp_mode_check(); >> apply_alternatives_all(); > > Why? Are you proposing the same change to other architectures? Are you paid > per patch? The message provides no further information than the generic code, so kill it. Or show BogoMIPS like arm32? > > Will > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index cb87234..6bb33cd 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -428,7 +428,17 @@ static void __init hyp_mode_check(void) void __init smp_cpus_done(unsigned int max_cpus) { - pr_info("SMP: Total of %d processors activated.\n", num_online_cpus()); + int cpu; + unsigned long bogosum = 0; + + for_each_online_cpu(cpu) + bogosum += loops_per_jiffy; + + pr_info("SMP: Total of %d processors activated " + "(%lu.%02lu BogoMIPS).\n", + num_online_cpus(), + bogosum / (500000/HZ), + (bogosum / (5000/HZ)) % 100); setup_cpu_features(); hyp_mode_check(); apply_alternatives_all()