From patchwork Thu Jun 25 05:57:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vaibhav Hiremath X-Patchwork-Id: 50301 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5AD0F228FC for ; Thu, 25 Jun 2015 05:57:47 +0000 (UTC) Received: by wiea6 with SMTP id a6sf18777733wie.1 for ; Wed, 24 Jun 2015 22:57:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=dplUkI+3MBYWF4euP60CRM8l2eruvU39bJsvEWYXUTA=; b=cuOTVSZUBVcN1+dv2V0Xj0Y/iAGwATa5x8aoYVUAbsLlYmDoxUzK/RLbZaf3T4Uayj sEgWHog2iuqsAsevlr06tLYRou5O4FI6sek8yHAUkEHn7f1OCVXnru0/XpkExv3rgcAI 7xGYk89q3S+rl7ZxHHGyCXUhTJpYTaIwzt8MD43TRljeehBojgQQ55ksdgdnbqYYxaXG Xm/Y57C7aaT38/wP8GFE6y4V563Hx3HfMKKrzWqCeCtKBmXyQaoInMVLfQDlQJ62fjQo nsvaE8UxlOjinb1k7Nr02/Z6mRxgvJZK3E+6Vr7382XZ0Meypu2ryXcbHB7Jwv5lV4dr frPA== X-Gm-Message-State: ALoCoQmugfl/INpI8w+y03E10BUpMaSbQk9R5HoyF3+biANmTqlW5/6tvX6AcOAT5+7ZKmCrY5rf X-Received: by 10.152.88.70 with SMTP id be6mr19288859lab.9.1435211866598; Wed, 24 Jun 2015 22:57:46 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.182.228 with SMTP id eh4ls281359lac.45.gmail; Wed, 24 Jun 2015 22:57:46 -0700 (PDT) X-Received: by 10.112.83.135 with SMTP id q7mr43638017lby.13.1435211866447; Wed, 24 Jun 2015 22:57:46 -0700 (PDT) Received: from mail-la0-f49.google.com (mail-la0-f49.google.com. [209.85.215.49]) by mx.google.com with ESMTPS id ld2si23818345lab.101.2015.06.24.22.57.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jun 2015 22:57:46 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.49 as permitted sender) client-ip=209.85.215.49; Received: by lagi2 with SMTP id i2so38567205lag.2 for ; Wed, 24 Jun 2015 22:57:46 -0700 (PDT) X-Received: by 10.112.199.133 with SMTP id jk5mr44309355lbc.32.1435211866298; Wed, 24 Jun 2015 22:57:46 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp364759lbb; Wed, 24 Jun 2015 22:57:45 -0700 (PDT) X-Received: by 10.70.128.34 with SMTP id nl2mr88198672pdb.43.1435211864421; Wed, 24 Jun 2015 22:57:44 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cw3si16988592pbc.31.2015.06.24.22.57.43; Wed, 24 Jun 2015 22:57:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750800AbbFYF5l (ORCPT + 8 others); Thu, 25 Jun 2015 01:57:41 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:33403 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbbFYF5k (ORCPT ); Thu, 25 Jun 2015 01:57:40 -0400 Received: by padev16 with SMTP id ev16so43337481pad.0 for ; Wed, 24 Jun 2015 22:57:40 -0700 (PDT) X-Received: by 10.68.135.136 with SMTP id ps8mr88487637pbb.78.1435211860514; Wed, 24 Jun 2015 22:57:40 -0700 (PDT) Received: from [192.168.0.102] ([202.62.77.106]) by mx.google.com with ESMTPSA id go5sm28622952pbd.36.2015.06.24.22.57.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jun 2015 22:57:39 -0700 (PDT) Message-ID: <558B984D.9040309@linaro.org> Date: Thu, 25 Jun 2015 11:27:33 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Krzysztof Kozlowski CC: linux-arm-kernel@lists.infradead.org, Zhao Ye , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, lee.jones@linaro.org Subject: Re: [PATCH-v3 2/3] mfd: 88pm800: Allow configuration of interrupt clear method References: <1435137673-1629-1-git-send-email-vaibhav.hiremath@linaro.org> <1435137673-1629-3-git-send-email-vaibhav.hiremath@linaro.org> <558B90F7.80700@linaro.org> <558B9272.6090100@samsung.com> <558B9549.5010705@linaro.org> <558B96B7.3030501@samsung.com> In-Reply-To: <558B96B7.3030501@samsung.com> Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: vaibhav.hiremath@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.49 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On Thursday 25 June 2015 11:20 AM, Krzysztof Kozlowski wrote: > On 25.06.2015 14:44, Vaibhav Hiremath wrote: >> >> >> On Thursday 25 June 2015 11:02 AM, Krzysztof Kozlowski wrote: >>> On 25.06.2015 14:26, Vaibhav Hiremath wrote: >>>> >>>> >>>> On Thursday 25 June 2015 05:33 AM, Krzysztof Kozlowski wrote: >>>>> 2015-06-24 18:21 GMT+09:00 Vaibhav Hiremath >>>>> : >>>>>> As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe >>>>>> (page 0) controls the method of clearing interrupt >>>>>> status of 88pm800 family of devices; >>>>>> >>>>>> 0: clear on read >>>>>> 1: clear on write >>>>>> >>>>>> This patch allows to configure this field, through DT. >>>>>> >>>>>> Also, as suggested by "Lee Jones" renaming DT property and variable >>>>>> field to appropriate name. >>>>>> >>>>>> Signed-off-by: Zhao Ye >>>>>> Signed-off-by: Vaibhav Hiremath >>>>> >>> >> >> Yes, >> Fair enough... >> >> I see very little value in runtime configuration, why not just do it >> only way (either read or write)? >> I would prefer to just set it by default (during init), to clear irq on >> write. > > Hard-coding a default value, if board files are not present, looks OK to me. > This is how it will look, I will also update the binding information with this. hvaibhav@hvaibhav-ThinkPad-T440p:~/projects/mainline/linux$ git diff --cached ret = pm80x_init(client); Thanks, Vaibhav --- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c index 0a417ac..e415a06 100644 --- a/drivers/mfd/88pm800.c +++ b/drivers/mfd/88pm800.c @@ -645,9 +645,8 @@ static int pm800_probe(struct i2c_client *client, dev_err(&client->dev, "failed to allocaate memory\n"); return -ENOMEM; } - - pdata->irq_clr_on_wr = of_property_read_bool(np, - "marvell,irq-clr-on-write"); + /* Setting irq clear method on write */ + pdata->irq_clr_on_wr = true; }