From patchwork Wed Feb 6 14:15:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 14641 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 90F4D23F99 for ; Wed, 6 Feb 2013 14:16:14 +0000 (UTC) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by fiordland.canonical.com (Postfix) with ESMTP id 27ACFA19344 for ; Wed, 6 Feb 2013 14:16:14 +0000 (UTC) Received: by mail-vb0-f54.google.com with SMTP id l1so867627vba.27 for ; Wed, 06 Feb 2013 06:16:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:x-enigmail-version:content-type :x-gm-message-state; bh=HhHXzfgbEaBbp9tWjwO87xehSdP+bH/BYT1it3cL27A=; b=ECFD+tYbprbkZbDis0O8rL9e0MjqUhbvKCFqEHYkTfk+94+gHUumqpkJwc+6M6pcY+ SgguOxoLiyfFpWa2h42G1Ixf54Wgc0THwNO6ZyMjoNnpE8o3LArEFWfCjYllnU6tQ78Q ke21LMyNszSLV+SdVd7YQi6g4tlNLe95GH64wKMTRfh1VkOZ9p2fusqLcVbWB6mJWR/I /WhuvHqeqPfBFawITQKLKgm0ijlI8ikg3ROnEVX/lKDIOLU8RjUrilsK5slwfmXUrWBM sy1YUNLFjpbzH1qUpyT0Ax407FLMlzLvlmwEGWIruJEAsV1TFeiDEalYbjmTbUa0TXXD BXTw== X-Received: by 10.52.21.146 with SMTP id v18mr28625000vde.79.1360160173667; Wed, 06 Feb 2013 06:16:13 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.252.8 with SMTP id zo8csp30630vec; Wed, 6 Feb 2013 06:16:13 -0800 (PST) X-Received: by 10.60.21.38 with SMTP id s6mr8692180oee.3.1360160172840; Wed, 06 Feb 2013 06:16:12 -0800 (PST) Received: from arroyo.ext.ti.com (arroyo.ext.ti.com. [192.94.94.40]) by mx.google.com with ESMTPS id e2si24209742obb.60.2013.02.06.06.16.12 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 06 Feb 2013 06:16:12 -0800 (PST) Received-SPF: pass (google.com: domain of tomi.valkeinen@ti.com designates 192.94.94.40 as permitted sender) client-ip=192.94.94.40; Authentication-Results: mx.google.com; spf=pass (google.com: domain of tomi.valkeinen@ti.com designates 192.94.94.40 as permitted sender) smtp.mail=tomi.valkeinen@ti.com Received: from dlelxv30.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id r16EG0I8032025; Wed, 6 Feb 2013 08:16:00 -0600 Received: from DLEE74.ent.ti.com (dlee74.ent.ti.com [157.170.170.8]) by dlelxv30.itg.ti.com (8.13.8/8.13.8) with ESMTP id r16EG0pg003388; Wed, 6 Feb 2013 08:16:00 -0600 Received: from dlelxv22.itg.ti.com (172.17.1.197) by DLEE74.ent.ti.com (157.170.170.8) with Microsoft SMTP Server id 14.1.323.3; Wed, 6 Feb 2013 08:16:00 -0600 Received: from [172.24.68.4] (h68-4.vpn.ti.com [172.24.68.4]) by dlelxv22.itg.ti.com (8.13.8/8.13.8) with ESMTP id r16EFvgk017664; Wed, 6 Feb 2013 08:15:58 -0600 Message-ID: <5112659D.50808@ti.com> Date: Wed, 6 Feb 2013 16:15:57 +0200 From: Tomi Valkeinen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Arnd Bergmann CC: Rob Clark , , , , , Tony Lindgren , Greg KH Subject: Re: [PATCH] OMAPDSS: enable omapdss for ARCH_MULTIPLATFORM References: <1358891160-9534-1-git-send-email-robdclark@gmail.com> <201301222153.19580.arnd@arndb.de> <201302051631.40254.arnd@arndb.de> In-Reply-To: <201302051631.40254.arnd@arndb.de> X-Enigmail-Version: 1.4.6 X-Gm-Message-State: ALoCoQm5mOq2zK4kpN/oA8PJ9aKpXTitpdpyp2Ca3g0JLGBTmHkLRd9WXfiK0JGuvxqZqvACU7yn Hi Arnd, Rob, On 2013-02-05 18:31, Arnd Bergmann wrote: > On Tuesday 22 January 2013, Arnd Bergmann wrote: >> On Tuesday 22 January 2013, Rob Clark wrote: >>> At least core omapdss does not have any build dependencies on >>> ARCH_OMAP2PLUS, and adding this dependency in the Kconfig breaks omapdrm >>> for ARCH_MULTIPLATFORM builds. >>> >>> Signed-off-by: Rob Clark >> >> Acked-by: Arnd Bergmann > > It seems nobody has applied this patch, as it has not shown up in > linux-next or upstream. Who should take care of this? If nobody feels > responsible, I can put it into arm-soc/fixes. That would normally be me, but I've been on a long leave, and just came back. It'll take me some time to get back on track. I don't think it makes sense to add ARCH_MULTIPLATFORM only for omapdss, like this patch does. I think we should add it for omapfb and the panel drivers also. I did get a report of an omapdss build-break with allyesconfig. It seems to happen because omapdrm and omap_vout use "select" to enable omapdss, instead of depending on omapdss. This causes an illegal config to be created. Perhaps this is the problem that Rob mentions in his patch? Adding ARCH_MULTIPLATFORM for omapdss, as this patch does, removes (well, hides) the above mentioned problem and allyesconfig works ok. You can still break the config, but you need to manually select the Kconfig options the wrong way. I have patches to add the ARCH_MULTIPLATFORM for omapdss, and to fix the omap_vout and omapdrm Kconfig files. Each of them changes only one line. Arnd, are you ok with queuing those patches via arm-soc/fixes? Or should I send them individually to respective maintainers? I can send the patches properly for review, but I've also attached them here so Rob can test. Tomi >From aca9e04648a6cef98f65ff754bf903f456c8bc5d Mon Sep 17 00:00:00 2001 From: Tomi Valkeinen Date: Wed, 6 Feb 2013 16:03:44 +0200 Subject: [PATCH 3/3] omapdrm: fix the dependency on OMAPDSS omapdrm uses "select" in Kconfig to enable omapdss. This doesn't work correctly, as "select" forces omapdss to be enabled in the config even if it normally could not be enabled. Instead of using select, this patch changes omapdrm to use "depend on". Signed-off-by: Tomi Valkeinen --- drivers/staging/omapdrm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/omapdrm/Kconfig b/drivers/staging/omapdrm/Kconfig index b724a41..09f65dc 100644 --- a/drivers/staging/omapdrm/Kconfig +++ b/drivers/staging/omapdrm/Kconfig @@ -3,8 +3,8 @@ config DRM_OMAP tristate "OMAP DRM" depends on DRM && !CONFIG_FB_OMAP2 depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM + depends on OMAP2_DSS select DRM_KMS_HELPER - select OMAP2_DSS select FB_SYS_FILLRECT select FB_SYS_COPYAREA select FB_SYS_IMAGEBLIT -- 1.7.10.4