From patchwork Thu Aug 4 09:21:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 73250 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp1289756qga; Thu, 4 Aug 2016 02:24:41 -0700 (PDT) X-Received: by 10.98.208.1 with SMTP id p1mr124487107pfg.10.1470302681012; Thu, 04 Aug 2016 02:24:41 -0700 (PDT) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id 80si13781494pfo.201.2016.08.04.02.24.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Aug 2016 02:24:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) smtp.mailfrom=linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bVEsQ-00061C-3b; Thu, 04 Aug 2016 09:23:42 +0000 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bVErg-0005O4-W8 for linux-arm-kernel@lists.infradead.org; Thu, 04 Aug 2016 09:22:59 +0000 Received: by mail-wm0-x22c.google.com with SMTP id i5so370062570wmg.0 for ; Thu, 04 Aug 2016 02:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RgSi+h6pV9nHNCmKfxb/s4IfrA5KmwMCV0HdS+ZRJ20=; b=Ev55S5cl4W9sWto8a543BCyWfQakXimb26o+mafhIpSiC+nMaoOdNq6gGPRJiXtfb2 zyLeUMKSHg1GYUtqP3g45Yx/ZSfgr5qMYpT2nFN/Evra27U+CPqtDePjiNi0yXToRklc r7QRAUzWS4+6flVGqt9Gn06+N3dlI1s/lvN5A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RgSi+h6pV9nHNCmKfxb/s4IfrA5KmwMCV0HdS+ZRJ20=; b=ZBtKgxtEypkVTM3NFEw4apIZvzi1gLvYLmVUZr7V/ITw4+XFrQzwPOg7d55s48EM1r kH/aNoLFUi0CB2Rcxkk/gddh5a/lbRvhg9zn4SH2GvUpmdZ1b9x3INRjNDVxBobHBxlC Ku9ckJYgiECP2bYqKxqj0njgp5OoNtM6z7N/7COZjEDfpDj8ot1xhEx/L+4G9cpiniTi vKPHamadCH0PVa1ekZ5MAVc8tHKThekGVFQbOmCY4IME414w9HOegxJj2lBlV8JAaVp0 pm1jcgm2lZeMzx6JYGpHOvxuXWIQgj9brUcL8UTXgN5yxLfx97xcHKpN+8+HDoZKP9fq 7z7w== X-Gm-Message-State: AEkoousSler+i3WrzHyLwWiz60e8//TV3VCQRCXkqJCo3R5HR/afinTO3C84a9Krq5lp7wGd X-Received: by 10.194.16.162 with SMTP id h2mr67392897wjd.52.1470302555122; Thu, 04 Aug 2016 02:22:35 -0700 (PDT) Received: from localhost.localdomain (host86-185-202-8.range86-185.btcentralplus.com. [86.185.202.8]) by smtp.gmail.com with ESMTPSA id d64sm2615461wmc.22.2016.08.04.02.22.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Aug 2016 02:22:34 -0700 (PDT) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/9] remoteproc: core: Trivial: Improve error checking, spelling and debug prints Date: Thu, 4 Aug 2016 10:21:46 +0100 Message-Id: <20160804092153.23032-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160804092153.23032-1-lee.jones@linaro.org> References: <20160804092153.23032-1-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160804_022257_391952_646F79DD X-CRM114-Status: GOOD ( 13.06 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:400c:c09:0:0:0:22c listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, kernel@stlinux.com, loic.pallardy@st.com, linux-remoteproc@vger.kernel.org, patrice.chotard@st.com, bjorn.andersson@linaro.org, Lee Jones MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org Trivial patch to clean up a couple of minor misgivings. Signed-off-by: Lee Jones --- drivers/remoteproc/remoteproc_core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.9.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 3566dc9..5654a81 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -457,8 +457,8 @@ static int rproc_handle_trace(struct rproc *rproc, struct fw_rsc_trace *rsc, rproc->num_traces++; - dev_dbg(dev, "%s added: va %p, da 0x%x, len 0x%x\n", name, ptr, - rsc->da, rsc->len); + dev_dbg(dev, "%s added: va %p, da 0x%x, len 0x%x\n", + name, ptr, rsc->da, rsc->len); return 0; } @@ -581,8 +581,8 @@ static int rproc_handle_carveout(struct rproc *rproc, return -EINVAL; } - dev_dbg(dev, "carveout rsc: da %x, pa %x, len 0x%x, flags %x\n", - rsc->da, rsc->pa, rsc->len, rsc->flags); + dev_dbg(dev, "carveout rsc: name: %s, da %x, pa %x, len 0x%x, flags %x\n", + rsc->name, rsc->da, rsc->pa, rsc->len, rsc->flags); carveout = kzalloc(sizeof(*carveout), GFP_KERNEL); if (!carveout) @@ -700,7 +700,7 @@ static rproc_handle_resource_t rproc_loading_handlers[RSC_LAST] = { [RSC_CARVEOUT] = (rproc_handle_resource_t)rproc_handle_carveout, [RSC_DEVMEM] = (rproc_handle_resource_t)rproc_handle_devmem, [RSC_TRACE] = (rproc_handle_resource_t)rproc_handle_trace, - [RSC_VDEV] = NULL, /* VDEVs were handled upon registrarion */ + [RSC_VDEV] = NULL, /* VDEVs were handled upon registration */ }; static rproc_handle_resource_t rproc_vdev_handler[RSC_LAST] = { @@ -918,7 +918,7 @@ static void rproc_fw_config_virtio(const struct firmware *fw, void *context) * Create a copy of the resource table. When a virtio device starts * and calls vring_new_virtqueue() the address of the allocated vring * will be stored in the cached_table. Before the device is started, - * cached_table will be copied into devic memory. + * cached_table will be copied into device memory. */ rproc->cached_table = kmemdup(table, tablesz, GFP_KERNEL); if (!rproc->cached_table)