From patchwork Fri Aug 8 07:38:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 35101 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ig0-f199.google.com (mail-ig0-f199.google.com [209.85.213.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A86992118A for ; Fri, 8 Aug 2014 07:38:13 +0000 (UTC) Received: by mail-ig0-f199.google.com with SMTP id l13sf2484016iga.2 for ; Fri, 08 Aug 2014 00:38:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :references:mime-version:in-reply-to:user-agent:sender:precedence :list-id:x-original-sender:x-original-authentication-results :mailing-list:list-post:list-help:list-archive:list-unsubscribe :content-type:content-disposition:content-transfer-encoding; bh=ds8B0NKgLBWKBXql35gYoXN6RgfGoh8JNHyZF9eM7NI=; b=iQcgn1sYmyKGFpqIqFu+ZthSE+L9Sya/T8HNTJeQ2o0fuqNdtjNoXdgaSI2knutrfZ tkxEgqEowmziP5I0tN4gwCuDBEr9AyGnZzHGn8aephkqfyPwMXuyg0PITyBsZRsTN/PF mRTb3/frSuhTqfC/kyKEK/KTr9BcI8RNfihxMrfYWqHiF7Ua6ovtta+nsP0uHBzeoD6u SbaRJRWAEb9Wn+Q2mWUCFh0A5JY7mkXmgYQ0bxqfnOKZZl6RbNxL3xriMcZJDdLUyirt BcDCE4y+QBBBleYGW4QLHlJwnfGofL4W8FNUOFaEB7zZBhtLK7/JRJCtRLpDU0AyWXCw dl6w== X-Gm-Message-State: ALoCoQk/kQVg+1Tg6wzVnzPOOrQQAbdofwZOlyoww7JmhN1aEHzbqK6Rd0rpX7W7cXfL+TROMzl1 X-Received: by 10.182.129.37 with SMTP id nt5mr11739981obb.8.1407483493187; Fri, 08 Aug 2014 00:38:13 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.94.210 with SMTP id g76ls411436qge.74.gmail; Fri, 08 Aug 2014 00:38:13 -0700 (PDT) X-Received: by 10.52.9.35 with SMTP id w3mr5742778vda.12.1407483493105; Fri, 08 Aug 2014 00:38:13 -0700 (PDT) Received: from mail-vc0-f169.google.com (mail-vc0-f169.google.com [209.85.220.169]) by mx.google.com with ESMTPS id z9si2630418veu.47.2014.08.08.00.38.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 08 Aug 2014 00:38:13 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) client-ip=209.85.220.169; Received: by mail-vc0-f169.google.com with SMTP id le20so7896640vcb.14 for ; Fri, 08 Aug 2014 00:38:13 -0700 (PDT) X-Received: by 10.52.28.231 with SMTP id e7mr7185vdh.55.1407483493004; Fri, 08 Aug 2014 00:38:13 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp100915vcb; Fri, 8 Aug 2014 00:38:12 -0700 (PDT) X-Received: by 10.70.27.161 with SMTP id u1mr22959742pdg.6.1407483491279; Fri, 08 Aug 2014 00:38:11 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w4si1834348pdi.112.2014.08.08.00.38.10 for ; Fri, 08 Aug 2014 00:38:11 -0700 (PDT) Received-SPF: none (google.com: devicetree-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755387AbaHHHiJ (ORCPT + 6 others); Fri, 8 Aug 2014 03:38:09 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:59847 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754080AbaHHHiI (ORCPT ); Fri, 8 Aug 2014 03:38:08 -0400 Received: by mail-ie0-f175.google.com with SMTP id x19so6058496ier.34 for ; Fri, 08 Aug 2014 00:38:07 -0700 (PDT) X-Received: by 10.50.61.140 with SMTP id p12mr2489519igr.41.1407483487447; Fri, 08 Aug 2014 00:38:07 -0700 (PDT) Received: from lee--X1 (host109-148-116-177.range109-148.btcentralplus.com. [109.148.116.177]) by mx.google.com with ESMTPSA id x3sm5986711igl.7.2014.08.08.00.38.05 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 08 Aug 2014 00:38:07 -0700 (PDT) Date: Fri, 8 Aug 2014 08:38:02 +0100 From: Lee Jones To: Thierry Reding Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, ajitpal.singh@st.com Subject: Re: [PATCH v2 06/11] pwm: sti: Add new driver for ST's PWM IP Message-ID: <20140808073802.GC21618@lee--X1> References: <1405348412-7352-1-git-send-email-lee.jones@linaro.org> <1405348412-7352-7-git-send-email-lee.jones@linaro.org> <20140807142344.GA11095@ulmo.nvidia.com> MIME-Version: 1.0 In-Reply-To: <20140807142344.GA11095@ulmo.nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lee.jones@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.169 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Content-Disposition: inline On Thu, 07 Aug 2014, Thierry Reding wrote: > On Mon, Jul 14, 2014 at 03:33:27PM +0100, Lee Jones wrote: > [...] > > +static int sti_pwm_probe(struct platform_device *pdev) > > +{ > [...] > > + pc->clk = of_clk_get_by_name(np, "pwm"); > > This didn't compile because the np variable isn't declared. It was easy > to fix up, so I did, but please be more careful next time that the > patches you submit at least compile (preferably without sparse warnings > of which I also fixed up a couple). That's annoying, I thought I did build test the final changes. However, there's a mistake in the Makefile meaning that it wasn't building with no warning/error messages - it actually wasn't building at all! Sorry about that Thierry. I guess if you can build the driver, you've already fixed that? After that change, I can see that you're absolutely correct: CC drivers/pwm/pwm-sti.o ../drivers/pwm/pwm-sti.c: In function ‘sti_pwm_config’: ../drivers/pwm/pwm-sti.c:202:3: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘int’ [-Wformat=] dev_dbg(dev, "prescale:%u, period:%lu, duty:%i, pwmvalx:%u\n", ^ ../drivers/pwm/pwm-sti.c: In function ‘sti_pwm_probe’: ../drivers/pwm/pwm-sti.c:352:31: error: ‘np’ undeclared pc->clk = of_clk_get_by_name(np, "pwm"); ^ Sorry for the fuss. diff --git a/drivers/pwm/Makefile b/drivers/pwm/Makefile index 878333a..79665e3 100644 --- a/drivers/pwm/Makefile +++ b/drivers/pwm/Makefile @@ -20,7 +20,7 @@ obj-$(CONFIG_PWM_PXA) += pwm-pxa.o obj-$(CONFIG_PWM_RENESAS_TPU) += pwm-renesas-tpu.o obj-$(CONFIG_PWM_SAMSUNG) += pwm-samsung.o obj-$(CONFIG_PWM_SPEAR) += pwm-spear.o -obj-$(CONFIG_PWM_STI) += pwm-st.o +obj-$(CONFIG_PWM_STI) += pwm-sti.o obj-$(CONFIG_PWM_TEGRA) += pwm-tegra.o obj-$(CONFIG_PWM_TIECAP) += pwm-tiecap.o obj-$(CONFIG_PWM_TIEHRPWM) += pwm-tiehrpwm.o