From patchwork Tue Nov 22 17:13:47 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 5282 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 79E6623E0C for ; Tue, 22 Nov 2011 17:14:01 +0000 (UTC) Received: from mail-gy0-f180.google.com (mail-gy0-f180.google.com [209.85.160.180]) by fiordland.canonical.com (Postfix) with ESMTP id 0A4C7A185E0 for ; Tue, 22 Nov 2011 17:14:00 +0000 (UTC) Received: by ghbg18 with SMTP id g18so524959ghb.11 for ; Tue, 22 Nov 2011 09:14:00 -0800 (PST) Received: by 10.152.135.166 with SMTP id pt6mr12579430lab.26.1321982040173; Tue, 22 Nov 2011 09:14:00 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.152.41.198 with SMTP id h6cs189804lal; Tue, 22 Nov 2011 09:13:59 -0800 (PST) Received: by 10.180.73.107 with SMTP id k11mr20186598wiv.50.1321982036052; Tue, 22 Nov 2011 09:13:56 -0800 (PST) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de. [92.198.50.35]) by mx.google.com with ESMTPS id fn17si6925407wbb.33.2011.11.22.09.13.55 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 22 Nov 2011 09:13:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of ukl@pengutronix.de designates 92.198.50.35 as permitted sender) client-ip=92.198.50.35; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of ukl@pengutronix.de designates 92.198.50.35 as permitted sender) smtp.mail=ukl@pengutronix.de Received: from dude.hi.pengutronix.de ([2001:6f8:1178:2:21e:67ff:fe11:9c5c]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1RStul-0001OP-Ka; Tue, 22 Nov 2011 18:13:47 +0100 Received: from ukl by dude.hi.pengutronix.de with local (Exim 4.77) (envelope-from ) id 1RStul-0007uf-Ht; Tue, 22 Nov 2011 18:13:47 +0100 Date: Tue, 22 Nov 2011 18:13:47 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Mark Brown Cc: Russell King - ARM Linux , "patches@linaro.org" , Sascha Hauer , Will Deacon , "kernel@pengutronix.de" , Shawn Guo , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] arm/imx: use Kconfig choice for low-level debug UART selection Message-ID: <20111122171347.GJ19986@pengutronix.de> References: <1313530873-24961-1-git-send-email-will.deacon@arm.com> <1313729819-30301-1-git-send-email-shawn.guo@linaro.org> <20111122085834.GB19986@pengutronix.de> <20111122115017.GK20518@mudshark.cambridge.arm.com> <20111122130233.GF19986@pengutronix.de> <20111122132055.GA32572@mudshark.cambridge.arm.com> <20111122133040.GG19986@pengutronix.de> <20111122154838.GZ9581@n2100.arm.linux.org.uk> <20111122163812.GH19986@pengutronix.de> <20111122164707.GJ6624@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20111122164707.GJ6624@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:21e:67ff:fe11:9c5c X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: patches@linaro.org On Tue, Nov 22, 2011 at 04:47:07PM +0000, Mark Brown wrote: > On Tue, Nov 22, 2011 at 05:38:12PM +0100, Uwe Kleine-K?nig wrote: > > On Tue, Nov 22, 2011 at 03:48:38PM +0000, Russell King - ARM Linux wrote: > > > > > Ah, I see the problem. It's more subtile than just failure to build: it > > > > autoselects DEBUG_ICEDCC then. > > > > At this point, I think the right answer is to remove the option in > > > linux-next, and tell anyone who complains that they need to convert > > > their platform properly. (We're going to need them converted in this > > > way anyway for the single zImage project.) > > > I agree. > > It'd be nice if things could be arranged so that the build breaks rather > than selecting ICEDCC on unconverted platforms - when you run into the > problem it's not that easy to diagnose. What about the patch below? It's a small step back as DEBUG_ICEDCC is moved out of the choice, but seems to work in my tests. Best regards Uwe --------->8------------------- From: Uwe Kleine-König Subject: [PATCH RFC] ARM: remove DEBUG_LL_UART_NONE from choice of debug UARTs Moreover move DEBUG_ICEDCC out of the choice. This way platforms that don't have an item to pick in the choice automatically fall back to the traditional behaviour instead of choosing DEBUG_ICEDCC when only removing DEBUG_LL_UART_NONE. Signed-off-by: Uwe Kleine-König --- arch/arm/Kconfig.debug | 32 ++++++++++++-------------------- 1 files changed, 12 insertions(+), 20 deletions(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index c5213e7..4cca427 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -77,28 +77,20 @@ config DEBUG_LL image on a different platform *will not work*, so this option should not be enabled for kernels that are intended to be portable. -choice - prompt "Kernel low-level debugging port" - depends on DEBUG_LL - - config DEBUG_LL_UART_NONE - bool "No low-level debugging UART" - help - Say Y here if your platform doesn't provide a UART option - below. This relies on your platform choosing the right UART - definition internally in order for low-level debugging to - work. +config DEBUG_ICEDCC + bool "Kernel low-level debugging via EmbeddedICE DCC channel" + help + Say Y here if you want the debug print routines to direct + their output to the EmbeddedICE macrocell's DCC channel using + co-processor 14. This is known to work on the ARM9 style ICE + channel and on the XScale with the PEEDI. - config DEBUG_ICEDCC - bool "Kernel low-level debugging via EmbeddedICE DCC channel" - help - Say Y here if you want the debug print routines to direct - their output to the EmbeddedICE macrocell's DCC channel using - co-processor 14. This is known to work on the ARM9 style ICE - channel and on the XScale with the PEEDI. + Note that the system will appear to hang during boot if there + is nothing connected to read from the DCC. - Note that the system will appear to hang during boot if there - is nothing connected to read from the DCC. +choice + prompt "Kernel low-level debugging port" + depends on DEBUG_LL && !DEBUG_ICEDCC config DEBUG_FOOTBRIDGE_COM1 bool "Kernel low-level debugging messages via footbridge 8250 at PCI COM1"