From patchwork Mon Jun 20 14:56:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 70460 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp1552162qgy; Mon, 20 Jun 2016 07:57:36 -0700 (PDT) X-Received: by 10.98.89.147 with SMTP id k19mr22045422pfj.156.1466434656095; Mon, 20 Jun 2016 07:57:36 -0700 (PDT) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id b188si33646134pfa.90.2016.06.20.07.57.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jun 2016 07:57:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) smtp.mailfrom=linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bF0cu-000070-TJ; Mon, 20 Jun 2016 14:56:36 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bF0cr-0008T1-L4 for linux-arm-kernel@lists.infradead.org; Mon, 20 Jun 2016 14:56:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 92DA13B0; Mon, 20 Jun 2016 07:57:03 -0700 (PDT) Received: from e107155-lin.cambridge.arm.com (unknown [10.1.207.44]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B0E7B3F246; Mon, 20 Jun 2016 07:56:16 -0700 (PDT) From: Sudeep Holla To: arm@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] arm64: Kconfig: select PM{, _GENERIC_DOMAINS} for ARCH_VEXPRESS Date: Mon, 20 Jun 2016 15:56:09 +0100 Message-Id: <1466434569-26449-1-git-send-email-sudeep.holla@arm.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160620_075633_697691_ED722C29 X-CRM114-Status: UNSURE ( 9.89 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -8.3 (--------) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-8.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [217.140.101.70 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Arnd Bergmann , Kevin Hilman , Catalin Marinas , Will Deacon , Sudeep Holla , Olof Johansson MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org The Linux AMBA bus framework probes the peripheral IDs when adding the AMBA devices very early on the boot. Generally they are on APB bus and just require APB clocks to be on even when most of the core logic of the IP is powered down. However on Juno, the entire debugsys domain needs to be ON to access even the coresight components' CID/PID registers and hence broken by design. Accessing those while debugsys power domain is off will lead to the bridge stalling the transactions instead of returning the slave error. Further, the AMBA framework can't deal with !CONFIG_PM_GENERIC_DOMAINS case: it ignores the error and proceeds to access the device region. It was suggested to always enable CONFIG_PM{,_GENERIC_DOMAINS} in order to handle above explained scenario. Cc: Arnd Bergmann Suggested-by: Ulf Hansson Signed-off-by: Sudeep Holla --- arch/arm64/Kconfig.platforms | 2 ++ 1 file changed, 2 insertions(+) (Resending as I missed ALKML before) Hi ARM-SoC team, The discussion on this happened on linux-pm list[1]. This is need on Juno once we introduce coresight components in the DT. With !PM_GENERIC_DOMAINS, the board stalls on boot and hence this patch is needed. This shouldn't change any thing in the defconfig as couple of other platforms already do the same. It's needed in case all other ARCH_* configs are disabled. Without this, we need a dirty trick in the DT[2] to handle !PM_GENERIC_DOMAINS Can you please pick this for v4.8 directly ? Regards, Sudeep v1->v2: Also added PM_GENERIC_DOMAINS dependency as suggested by Arnd[3] [1] http://marc.info/?l=linux-pm&m=146607608629880&w=2 [2] https://marc.info/?l=linux-arm-kernel&m=146522896503670&w=2 [3] https://marc.info/?l=linux-arm-kernel&m=146619230406662&w=2 -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 7ef1d05859ae..25c4595589af 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -160,6 +160,8 @@ config ARCH_VEXPRESS bool "ARMv8 software model (Versatile Express)" select ARCH_REQUIRE_GPIOLIB select COMMON_CLK_VERSATILE + select PM + select PM_GENERIC_DOMAINS select POWER_RESET_VEXPRESS select VEXPRESS_CONFIG help