From patchwork Thu Mar 3 16:31:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 63484 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp3820lbc; Thu, 3 Mar 2016 08:33:15 -0800 (PST) X-Received: by 10.98.34.205 with SMTP id p74mr4864342pfj.93.1457022794935; Thu, 03 Mar 2016 08:33:14 -0800 (PST) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id kv12si5433146pab.194.2016.03.03.08.33.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Mar 2016 08:33:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) smtp.mailfrom=linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1abWAU-00068q-De; Thu, 03 Mar 2016 16:32:02 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1abWAQ-0005vG-D4 for linux-arm-kernel@lists.infradead.org; Thu, 03 Mar 2016 16:31:59 +0000 Received: by mail-wm0-x231.google.com with SMTP id p65so38760321wmp.0 for ; Thu, 03 Mar 2016 08:31:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=/3K7yqez7QTMTAMO1NzViWiNklEuywU2oycknE53L5U=; b=ZwInbwIm0mZtWW1IqJhwkH2palqPNARXoZSPAhC6Yz1OSEnHfHPW7ctHauhNBNiTZH F6APy9bacTEyShhoniV1bdjd17N/DEvt8kQ17uqEglf/+xG+HlfwbSRHH5U5tImDo9eW imTgpR/UgxTXuKsyns4aEHypBOCeRL1HeHa2s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/3K7yqez7QTMTAMO1NzViWiNklEuywU2oycknE53L5U=; b=eNVnSryEIq5VnyrH0x4zW71LlHzNMnMh22XWq/BDf3Ssf7IwIXbmqCyiQpbgqKL4x2 0NS7mRSzazNqt0sscbGN8Xt7O23lcYBWsM11oZb13s0E++cA7Xr+rxPn4Owv8wOu7Yy1 uk+G1EV+/YERtyYOfFMa+p90RLO1/xViMqX8F+5Z0hhVKqBsNVcNXQaYtOJObsLSxPrh e5VVdQzcpylJrbw/CEVV4XHH3rm2AUfFwwHNi1L2v36UJA4APDWThX7TfLBZGdxbzY2S QtgxelCTvDEGcd3/jt6fK8BoEvxXLA7QqO6Ri1FDcBa1VozviGeCpn3DQl421Fu2V215 RtVg== X-Gm-Message-State: AD7BkJJlc3XQ55bkUn06nGXDd7XS05bsMAefCcCBaVljuifWrbzfXykRGXi/naqASiB/sqGt X-Received: by 10.28.211.130 with SMTP id k124mr6984591wmg.7.1457022696288; Thu, 03 Mar 2016 08:31:36 -0800 (PST) Received: from localhost.localdomain ([195.55.142.58]) by smtp.gmail.com with ESMTPSA id u4sm41503560wjz.4.2016.03.03.08.31.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 03 Mar 2016 08:31:35 -0800 (PST) From: Ard Biesheuvel To: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com Subject: [PATCH] arm64: efi: add missing frame pointer assignment Date: Thu, 3 Mar 2016 17:31:32 +0100 Message-Id: <1457022692-14043-1-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.5.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160303_083158_597214_8860B576 X-CRM114-Status: GOOD ( 11.12 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:400c:c09:0:0:0:231 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Ard Biesheuvel MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org The prologue of the EFI entry point pushes x29 and x30 onto the stack but fails to create the stack frame correctly by omitting the assignment of x29 to the new value of the stack pointer. So fix that. Signed-off-by: Ard Biesheuvel --- arch/arm64/kernel/efi-entry.S | 1 + 1 file changed, 1 insertion(+) -- 2.5.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/arch/arm64/kernel/efi-entry.S b/arch/arm64/kernel/efi-entry.S index 936022f0655e..e88c064b845c 100644 --- a/arch/arm64/kernel/efi-entry.S +++ b/arch/arm64/kernel/efi-entry.S @@ -35,6 +35,7 @@ ENTRY(entry) * for image_addr variable passed to efi_entry(). */ stp x29, x30, [sp, #-32]! + mov x29, sp /* * Call efi_entry to do the real work.