From patchwork Mon Feb 1 22:02:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 60969 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp348313lbb; Mon, 1 Feb 2016 14:04:23 -0800 (PST) X-Received: by 10.66.237.66 with SMTP id va2mr41951246pac.87.1454364263117; Mon, 01 Feb 2016 14:04:23 -0800 (PST) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id fm8si26869802pab.17.2016.02.01.14.04.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Feb 2016 14:04:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) smtp.mailfrom=linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aQMZ7-0007wC-Nd; Mon, 01 Feb 2016 22:03:21 +0000 Received: from mail-lb0-x232.google.com ([2a00:1450:4010:c04::232]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aQMZ3-0007tm-0L for linux-arm-kernel@lists.infradead.org; Mon, 01 Feb 2016 22:03:18 +0000 Received: by mail-lb0-x232.google.com with SMTP id cl12so83389531lbc.1 for ; Mon, 01 Feb 2016 14:02:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=CTP2qcM/GwC0APkEkkSKNBM+c7kEtmreZojE/VKnPP8=; b=koeLYCZiJhgWYUi75uU1S8PHe63xANS7cDlrVa/Q87KHvBnNgHdDuTDpfIV/TC3NcY 4O9KC8N5wb9lzWG4RfCZ50EXRvIMihbH9zfjcwsBVBLg2wSv4H9gUqnG82kINH2sPAqP II1cvp+OXfJzp8XloBi29k4xtbsOrPBZ+NW/Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=CTP2qcM/GwC0APkEkkSKNBM+c7kEtmreZojE/VKnPP8=; b=aHm4mBnXF6BPqfOvR+ovCLKGy7ksLRCfX90LhZXQOJPdIPAYRPnPA/v4oscOu6F1Ed kkwtqLheWevJP/9GmPixl2aJjok3/vzLG4CGjLH6RPLekvoaiRzT5TzcFS3ytn2z2jY1 gu3CYbvI0tNl/QZLk2V2m0ShbWL4VnJ/oxbqxE4sTl4Wh2Utx5z/M8Gkt7q9yrQk41Np xvRAetdWQg4GtKaIb4JeotOt3jOCwLw+vBfUtv7KtW95ljDRF6gy+Rmqnl2xNLl2MgLm chjbvv6urU9ikvWro60vADjCQpctfIGgUDPKxxZxsHKOIBb6gr2tlTa2Dc9vlj5eolVo GLoQ== X-Gm-Message-State: AG10YOTXZ7z6lObl/bRBj7IqfzPB/bonG3O5+VFZWIKtZzTj10E4gYQime+m/3+nSryXaogF X-Received: by 10.112.14.102 with SMTP id o6mr9238347lbc.87.1454364174296; Mon, 01 Feb 2016 14:02:54 -0800 (PST) Received: from localhost.localdomain.localdomain (c-3d95db54.01-192-6c756e10.cust.bredbandsbolaget.se. [84.219.149.61]) by smtp.gmail.com with ESMTPSA id ax1sm4372385lbc.20.2016.02.01.14.02.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Feb 2016 14:02:53 -0800 (PST) From: Linus Walleij To: David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org Subject: [PATCH] mtd: map: fix .set_vpp() documentation Date: Mon, 1 Feb 2016 23:02:48 +0100 Message-Id: <1454364168-1342-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 2.4.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160201_140317_262868_A2840AB5 X-CRM114-Status: GOOD ( 14.57 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:4010:c04:0:0:0:232 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , Russell King , linux-arm-kernel@lists.infradead.org, Paul Parsons MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org As of commit 876fe76d793d03077eb61ba3afab4a383f46c554 "mtd: maps: physmap: Add reference counter to set_vpp()" the comment in the header file is incorrect and misleading. Fix it up. Cc: Russell King Cc: Paul Parsons Fixes: 876fe76d793d ("mtd: maps: physmap: Add reference counter to set_vpp()") Signed-off-by: Linus Walleij --- include/linux/mtd/map.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.4.3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h index 58f3ba709ade..5e0eb7ccabd4 100644 --- a/include/linux/mtd/map.h +++ b/include/linux/mtd/map.h @@ -240,8 +240,11 @@ struct map_info { If there is no cache to care about this can be set to NULL. */ void (*inval_cache)(struct map_info *, unsigned long, ssize_t); - /* set_vpp() must handle being reentered -- enable, enable, disable - must leave it enabled. */ + /* This will be called with 1 as parameter when the first map user + * needs VPP, and called with 0 when the last user exits. The map + * core maintains a reference counter, and assumes that VPP is a + * global resource applying to all mapped flash chips on the system. + */ void (*set_vpp)(struct map_info *, int); unsigned long pfow_base;