From patchwork Wed Oct 28 13:02:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Auger Eric X-Patchwork-Id: 55675 Delivered-To: patches@linaro.org Received: by 10.112.61.134 with SMTP id p6csp106409lbr; Wed, 28 Oct 2015 06:03:11 -0700 (PDT) X-Received: by 10.28.16.203 with SMTP id 194mr1523780wmq.55.1446037383179; Wed, 28 Oct 2015 06:03:03 -0700 (PDT) Return-Path: Received: from mail-wi0-x229.google.com (mail-wi0-x229.google.com. [2a00:1450:400c:c05::229]) by mx.google.com with ESMTPS id ju5si32158164wjc.28.2015.10.28.06.03.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Oct 2015 06:03:03 -0700 (PDT) Received-SPF: pass (google.com: domain of eric.auger@linaro.org designates 2a00:1450:400c:c05::229 as permitted sender) client-ip=2a00:1450:400c:c05::229; Authentication-Results: mx.google.com; spf=pass (google.com: domain of eric.auger@linaro.org designates 2a00:1450:400c:c05::229 as permitted sender) smtp.mailfrom=eric.auger@linaro.org; dkim=pass header.i=@linaro_org.20150623.gappssmtp.com Received: by wicll6 with SMTP id ll6so11671495wic.1 for ; Wed, 28 Oct 2015 06:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RqJb8H7yMT8y+8JOYNS2SYxXEa6FIjfZXSlw7NUXxKE=; b=ASxZAVeyX6Mv6/elGV9mCkbCWJdZazsnQVsIKfE5orlehdryUA2Uxakjc5vFGtQ2wC lFtoEKjHKZq5MWtPqZZsFbrLOydHLScm6sfDJkHa1GI2ynJL1zUHo/OXnqY3Ulyi6ifi s9n5DO+3afmYw5Bzqj26RJ8evD0nNTwL2Is6TGmcC83lqChtXXqY/g6qAG5zHYKDkyYF 0N9U3uh4tTlzraXjf49WuR681TeheTBElWMvwl9CdMwRwteH7sa+I3nhjdrU0sG6sx6l 55eOj6NCZhOjWTJM00mtqWDGfl9z6RNJxl8Wa3532b4kZXTH2hh0Mt/7Hyju6pm++nph n01g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RqJb8H7yMT8y+8JOYNS2SYxXEa6FIjfZXSlw7NUXxKE=; b=VIzWrj863XGwNXKPKTFSZpft/W/pVYUjrvwzZ48JpBqDMXpasVPxf1dvdB5qxLrAox ofVMimm+4S0mwLZoB4YeDqeInc3pZXOH5LpxF9wuNZBurTJyhVBmA3Ap7p1fEeOvw36n /mkJGqQBn4Oq8gk46qznIsG9oWw67CPweQSkVUCWOGebiB7ndapbYra1iCdjCZwj3o2e F5Us0nTgvoHRj5V2mdyp2lCCPqlYim25qIRze24xKfzg1RBQ4YAAUQoMaw725N8ARJ0E eNXez6iQEsNwISfAdDMkFD4NOelfLBRmqW60ii07RdMqCUk5UqOduB5U5mwypgvYXNTj 4MnQ== X-Gm-Message-State: ALoCoQkthqJoch8+O9a8KkkA9LDNhvBBYxPhkTu8Mx2jybORM8rHaE3uhnBvBW3GMkbsj7gZ356Y X-Received: by 10.194.216.34 with SMTP id on2mr30072835wjc.109.1446037382577; Wed, 28 Oct 2015 06:03:02 -0700 (PDT) Return-Path: Received: from new-host-2.home (LMontsouris-657-1-37-90.w80-11.abo.wanadoo.fr. [80.11.198.90]) by smtp.gmail.com with ESMTPSA id gl9sm49894196wjb.10.2015.10.28.06.03.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Oct 2015 06:03:01 -0700 (PDT) From: Eric Auger To: eric.auger@st.com, eric.auger@linaro.org, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Cc: christoffer.dall@linaro.org, linux-kernel@vger.kernel.org, patches@linaro.org Subject: [PATCH v5 7/7] vfio: platform: add dev_info on device reset Date: Wed, 28 Oct 2015 13:02:38 +0000 Message-Id: <1446037358-2079-8-git-send-email-eric.auger@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1446037358-2079-1-git-send-email-eric.auger@linaro.org> References: <1446037358-2079-1-git-send-email-eric.auger@linaro.org> It might be helpful for the end-user to check the device reset function was found by the vfio platform reset framework. Lets store a pointer to the struct device in vfio_platform_device and trace when the reset function is called or not found. Signed-off-by: Eric Auger --- v3: creation --- drivers/vfio/platform/vfio_platform_common.c | 14 ++++++++++++-- drivers/vfio/platform/vfio_platform_private.h | 1 + 2 files changed, 13 insertions(+), 2 deletions(-) -- 1.9.1 diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c index f74836a..376d289 100644 --- a/drivers/vfio/platform/vfio_platform_common.c +++ b/drivers/vfio/platform/vfio_platform_common.c @@ -144,8 +144,12 @@ static void vfio_platform_release(void *device_data) mutex_lock(&driver_lock); if (!(--vdev->refcnt)) { - if (vdev->reset) + if (vdev->reset) { + dev_info(vdev->device, "reset\n"); vdev->reset(vdev); + } else { + dev_warn(vdev->device, "no reset function found!\n"); + } vfio_platform_regions_cleanup(vdev); vfio_platform_irq_cleanup(vdev); } @@ -174,8 +178,12 @@ static int vfio_platform_open(void *device_data) if (ret) goto err_irq; - if (vdev->reset) + if (vdev->reset) { + dev_info(vdev->device, "reset\n"); vdev->reset(vdev); + } else { + dev_warn(vdev->device, "no reset function found!\n"); + } } vdev->refcnt++; @@ -551,6 +559,8 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev, return -EINVAL; } + vdev->device = dev; + group = iommu_group_get(dev); if (!group) { pr_err("VFIO: No IOMMU group for device %s\n", vdev->name); diff --git a/drivers/vfio/platform/vfio_platform_private.h b/drivers/vfio/platform/vfio_platform_private.h index d1b0668..42816dd 100644 --- a/drivers/vfio/platform/vfio_platform_private.h +++ b/drivers/vfio/platform/vfio_platform_private.h @@ -59,6 +59,7 @@ struct vfio_platform_device { struct module *parent_module; const char *compat; struct module *reset_module; + struct device *device; /* * These fields should be filled by the bus specific binder